See attach patch
Responsible Changed From-To: freebsd-ports-bugs->perl perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Maintainer of devel/p5-Test-Class-Most, Please note that PR ports/170839 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/170839 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: perl->swills I'll take it.
There is a problem with this. Let us suppose that the mentioned PLIST_DIRS have other files by other packages like p5-Test-Class-*. So in that case we will have to move for pkg-plist files. Waiting for your feedback. Regards, Muhammad On Wed, Aug 22, 2012 at 7:20 AM, Edwin Groothuis <edwin@freebsd.org> wrote: > Maintainer of devel/p5-Test-Class-Most, > > Please note that PR ports/170839 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/170839 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org >
On 09/05/12 05:00, Muhammad Moinur Rahman wrote: > The following reply was made to PR ports/170839; it has been noted by GNATS. > > From: Muhammad Moinur Rahman <5u623l20@gmail.com> > To: bug-followup@freebsd.org > Cc: > Subject: Re: ports/170839: [patch] Fix plist for devel/p5-Test-Class-Most > Date: Wed, 5 Sep 2012 14:50:29 +0600 > > --047d7bf162e47ed79c04c8f0770c > Content-Type: text/plain; charset=UTF-8 > > There is a problem with this. Let us suppose that the mentioned PLIST_DIRS > have other files by other packages like p5-Test-Class-*. > So in that case we will have to move for pkg-plist files. Waiting for your > feedback. > > Regards, > Muhammad > We could make it PLIST_DIRSTRY instead, so that the dirs won't be deleted if they aren't empty: Index: Makefile =================================================================== --- Makefile (revision 303426) +++ Makefile (working copy) @@ -7,9 +7,10 @@ PORTNAME= Test-Class-Most PORTVERSION= 0.06 +PORTREVISION= 1 CATEGORIES= devel perl5 MASTER_SITES= CPAN -MASTER_SITE_SUBDIR= ../by-authors/id/O/OV/OVID +MASTER_SITE_SUBDIR= CPAN:OVID PKGNAMEPREFIX= p5- MAINTAINER= 5u623l20@gmail.com @@ -21,6 +22,7 @@ PERL_MODBUILD= yes PLIST_FILES= %%SITE_PERL%%/Test/Class/Most.pm +PLIST_DIRSTRY= %%SITE_PERL%%/Test/Class %%SITE_PERL%%/Test MAN3= Test::Class::Most.3
Approved. On Thu, Sep 6, 2012 at 12:00 PM, Steve Wills <swills@freebsd.org> wrote: > On 09/05/12 05:00, Muhammad Moinur Rahman wrote: > >> The following reply was made to PR ports/170839; it has been noted by >> GNATS. >> >> From: Muhammad Moinur Rahman <5u623l20@gmail.com> >> To: bug-followup@freebsd.org >> Cc: >> Subject: Re: ports/170839: [patch] Fix plist for devel/p5-Test-Class-Most >> Date: Wed, 5 Sep 2012 14:50:29 +0600 >> >> --047d7bf162e47ed79c04c8f0770c >> Content-Type: text/plain; charset=UTF-8 >> >> >> There is a problem with this. Let us suppose that the mentioned >> PLIST_DIRS >> have other files by other packages like p5-Test-Class-*. >> So in that case we will have to move for pkg-plist files. Waiting for >> your >> feedback. >> >> Regards, >> Muhammad >> >> > We could make it PLIST_DIRSTRY instead, so that the dirs won't be deleted > if they aren't empty: > > Index: Makefile > ==============================**==============================**======= > --- Makefile (revision 303426) > +++ Makefile (working copy) > @@ -7,9 +7,10 @@ > > PORTNAME= Test-Class-Most > PORTVERSION= 0.06 > +PORTREVISION= 1 > CATEGORIES= devel perl5 > MASTER_SITES= CPAN > -MASTER_SITE_SUBDIR= ../by-authors/id/O/OV/OVID > +MASTER_SITE_SUBDIR= CPAN:OVID > PKGNAMEPREFIX= p5- > > MAINTAINER= 5u623l20@gmail.com > @@ -21,6 +22,7 @@ > PERL_MODBUILD= yes > > PLIST_FILES= %%SITE_PERL%%/Test/Class/Most.**pm > +PLIST_DIRSTRY= %%SITE_PERL%%/Test/Class %%SITE_PERL%%/Test > > MAN3= Test::Class::Most.3 > > > > > >
State Changed From-To: feedback->closed Committed. Thanks!
Author: swills Date: Thu Sep 6 07:28:21 2012 New Revision: 303747 URL: http://svn.freebsd.org/changeset/ports/303747 Log: - Fix plist - Use CPAN macro for SUBDIR PR: ports/170839 Approved by: Muhammad Moinur Rahman <5u623l20@gmail.com> (maintainer) Modified: head/devel/p5-Test-Class-Most/Makefile (contents, props changed) Modified: head/devel/p5-Test-Class-Most/Makefile ============================================================================== --- head/devel/p5-Test-Class-Most/Makefile Thu Sep 6 06:15:28 2012 (r303746) +++ head/devel/p5-Test-Class-Most/Makefile Thu Sep 6 07:28:21 2012 (r303747) @@ -7,9 +7,10 @@ PORTNAME= Test-Class-Most PORTVERSION= 0.06 +PORTREVISION= 1 CATEGORIES= devel perl5 MASTER_SITES= CPAN -MASTER_SITE_SUBDIR= ../by-authors/id/O/OV/OVID +MASTER_SITE_SUBDIR= CPAN:OVID PKGNAMEPREFIX= p5- MAINTAINER= 5u623l20@gmail.com @@ -21,6 +22,7 @@ BUILD_DEPENDS= p5-Test-Class>0:${PORTSDI PERL_MODBUILD= yes PLIST_FILES= %%SITE_PERL%%/Test/Class/Most.pm +PLIST_DIRSTRY= %%SITE_PERL%%/Test/Class %%SITE_PERL%%/Test MAN3= Test::Class::Most.3 _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"