Bug 171117 - [PATCH] security/knock: Duplicated flags
Summary: [PATCH] security/knock: Duplicated flags
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sofian Brabez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-27 14:30 UTC by changlp
Modified: 2012-08-29 12:00 UTC (History)
1 user (show)

See Also:

Attachments
knock-0.5_1,1.patch (897 bytes, patch)
2012-08-27 14:30 UTC, changlp 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description changlp 2012-08-27 14:30:16 UTC 
/etc/rc.subr already loads ${name}_flags as part of command line arguments.

Putting $knockd_flags into $command_args causes the flags to be duplicated twice.

e.g.
root         75681   0.0  0.0  12324   1064  ??  Rs    9:18PM     0:00.88 /usr/local/bin/knockd -d -d 



Port maintainer (sbz@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-27 14:30:29 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sbz

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-08-29 11:54:57 UTC 
Author: sbz
Date: Wed Aug 29 10:54:47 2012
New Revision: 303331
URL: http://svn.freebsd.org/changeset/ports/303331

Log:
  - Fix duplicated flags
  
  PR:		ports/171117
  Submitted by:	Lung-Pin Chang <changlp at cs.nctu.edu.tw>

Modified:
  head/security/knock/Makefile
  head/security/knock/files/knockd.in

Modified: head/security/knock/Makefile
==============================================================================
--- head/security/knock/Makefile	Wed Aug 29 10:07:06 2012	(r303330)
+++ head/security/knock/Makefile	Wed Aug 29 10:54:47 2012	(r303331)
@@ -7,6 +7,7 @@
 
 PORTNAME=	knock
 PORTVERSION=	0.5
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	security
 MASTER_SITES=	http://www.zeroflux.org/proj/knock/files/ \

Modified: head/security/knock/files/knockd.in
==============================================================================
--- head/security/knock/files/knockd.in	Wed Aug 29 10:07:06 2012	(r303330)
+++ head/security/knock/files/knockd.in	Wed Aug 29 10:54:47 2012	(r303331)
@@ -27,7 +27,6 @@ load_rc_config $name
 : ${knockd_flags="-d"}
 
 command="%%PREFIX%%/bin/knockd"
-command_args=${knockd_flags}
 pidfile="/var/run/knockd.pid"
 required_files=${knockd_conf}
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Sofian Brabez freebsd_committer freebsd_triage 2012-08-29 11:56:02 UTC 
State Changed
From-To: open->closed

Committed. Thanks!