The patch attached fixes lang/otcl when building against Tcl/Tk 8.6. This new release has made obsolete direct access to the members of Tcl_Interp errorLine and result. Legacy code can define USE_INTERP_ERRORLINE and USE_INTERP_RESULT to directly get to the members. Moreover, I have removed the limitation on using an unthreaded version of Tk. I have successfully built and run otcl linked against Tcl/Tk 8.6 with threads. Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->gahr Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of lang/otcl, Please note that PR ports/171142 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171142 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Approved On Tue, Aug 28, 2012 at 9:40 PM, Edwin Groothuis <edwin@freebsd.org> wrote: > Maintainer of lang/otcl, > > Please note that PR ports/171142 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171142 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org >
Author: gahr Date: Wed Aug 29 07:28:18 2012 New Revision: 303320 URL: http://svn.freebsd.org/changeset/ports/303320 Log: - Fix build against Tcl/Tk 8.6 - Remove limitation on using a non-threaded version of Tcl/Tk PR: 171142 Submitted by: gahr Approved by: Muhammad Moinur Rahman <5u623l20@gmail.com> (maintainer) Modified: head/lang/otcl/Makefile Modified: head/lang/otcl/Makefile ============================================================================== --- head/lang/otcl/Makefile Wed Aug 29 07:02:49 2012 (r303319) +++ head/lang/otcl/Makefile Wed Aug 29 07:28:18 2012 (r303320) @@ -19,7 +19,6 @@ LICENSE= MIT WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} USE_TK= 82+ -USE_TK_NO_THREADS= yes USE_XORG= xext USE_AUTOTOOLS= autoconf @@ -37,6 +36,10 @@ PORTDOCS= ${DOCS:S/doc\///} CFLAGS+= -DHAVE_UNISTD_H CONFIGURE_ARGS+= --with-tcl-ver=${TCL_VER} --with-tk-ver=${TK_VER} +.if ${USE_TCL} > 85 +CFLAGS+= -DUSE_INTERP_ERRORLINE -DUSE_INTERP_RESULT +.endif + post-patch: @${REINPLACE_CMD} -e 's|/usr/X11R6|${LOCALBASE}|g' \ -e's|X11/Intrinsic.h|X11/Xlib.h|g' \ _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!