Bug 171267 - [PATCH] games/madbomber: Makefile changed, OptionsNG, take maintainership
Summary: [PATCH] games/madbomber: Makefile changed, OptionsNG, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-03 01:00 UTC by nemysis
Modified: 2012-09-10 04:10 UTC (History)
1 user (show)

See Also:

Attachments
madbomber-0.2.5_12.patch (8.19 KB, patch)
2012-09-03 01:00 UTC, nemysis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-09-03 01:00:21 UTC 
Makefile changed:

Added

- MASTER_SITES=	ftp://ftp.tuxpaint.org/unix/x/madbomber/src/
- LICENSE=	GPLv2
- PLIST_FILES=
- PORTDATA=	*
- PORTDOCS=
- Pixmaps
- OptionsNG

- Take maintainership

Removed file(s):
- pkg-plist

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
Comment 1 Steve Wills freebsd_committer freebsd_triage 2012-09-09 03:29:16 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->swills

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-09-10 04:08:28 UTC 
Author: swills
Date: Mon Sep 10 03:08:16 2012
New Revision: 304018
URL: http://svn.freebsd.org/changeset/ports/304018

Log:
  - Add second MASTER_SITES entry
  - Avoid pkg-plist due to short plist
  - Set LICENSE
  - Convert to OptionsNG
  - Give maintainership to submitter
  
  PR:		ports/171267
  Submitted by:	nemysis <nemysis@gmx.ch>

Deleted:
  head/games/madbomber/pkg-plist
Modified:
  head/games/madbomber/Makefile   (contents, props changed)

Modified: head/games/madbomber/Makefile
==============================================================================
--- head/games/madbomber/Makefile	Mon Sep 10 03:02:02 2012	(r304017)
+++ head/games/madbomber/Makefile	Mon Sep 10 03:08:16 2012	(r304018)
@@ -7,28 +7,52 @@
 
 PORTNAME=	madbomber
 PORTVERSION=	0.2.5
-PORTREVISION=	11
+PORTREVISION=	12
 CATEGORIES=	games
-MASTER_SITES=	ftp://ftp.billsgames.com/unix/x/madbomber/src/
+MASTER_SITES=	ftp://ftp.tuxpaint.org/unix/x/madbomber/src/ \
+		ftp://ftp.billsgames.com/unix/x/madbomber/src/
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	nemysis@gmx.ch
 COMMENT=	A clone of Activision's classic Atari 2600 console game "Kaboom!"
 
+LICENSE=	GPLv2
+
 USE_SDL=	mixer image sdl
 
 CPPFLAGS+=	`${SDL_CONFIG} --cflags` -DDATA_PREFIX=\"${DATADIR}/\"
 LDFLAGS+=	`${SDL_CONFIG} --libs`
 
+PLIST_FILES=	bin/${PORTNAME} \
+		share/pixmaps/${PORTNAME}.png
+
+PORTDATA=	*
+PORTDOCS=	AUTHORS.txt CHANGES.txt README.txt TODO.txt
+
+.include <bsd.port.options.mk>
+
 do-build:
 	cd ${WRKSRC} && ${CC} ${CFLAGS} ${CPPFLAGS} -o ${PORTNAME} \
 		${PORTNAME}.c ${LDFLAGS} -lSDL_mixer -lSDL_image
 
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/madbomber ${PREFIX}/bin
-	@${MKDIR} ${DATADIR}
-	${TAR} -C ${WRKSRC}/data  --exclude embedded -cf - . | \
-		${TAR} -C ${DATADIR} --unlink -xf -
-	@${FIND} ${DATADIR} | ${XARGS} ${CHOWN} ${SHAREOWN}:${SHAREGRP}
-	@${FIND} ${DATADIR} -type f | ${XARGS} ${CHMOD} ${SHAREMODE}
+# Executable
+	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
+
+# Data
+	${MKDIR} ${DATADIR}
+.for d in images music sounds
+	@(cd ${WRKSRC}/data && ${COPYTREE_SHARE} ${d} ${DATADIR})
+.endfor
+
+# Pixmaps
+	${INSTALL_DATA} ${WRKSRC}/data/images/icon.png ${PREFIX}/share/pixmaps/${PORTNAME}.png
+
+# Documentation
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${DOCSDIR}
+.  for f in ${PORTDOCS}
+	${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
+.  endfor
+.endif
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Steve Wills freebsd_committer freebsd_triage 2012-09-10 04:08:38 UTC 
State Changed
From-To: open->closed

Committed. Thanks!