Please can we add the patch below to bsd.options.mk. This will allow to detect WITH... command param and make.conf usage in the apache ports so we can give the user a hint start reading about options NG. Until now many users have build the apache ports with parameters WITH... and WITHOUT... which do no longer work if options NG is full implemented in a port. I suspect the we will see many more requests about the WITH/WITHOUT usage in next time and without this hack it is not possible to see if a command line parameter was used or it comes from the framework. The following addition to bsd.apache.mk allows us then to give the user a hint if we add the following snippet to the apache files. Index: www/apache22/Makefile =================================================================== @@ -23,6 +23,7 @@ apache-2.0.* apache-*-2.0.* \ apache-*-2.2.* apache22-*-2.2.* +OPTNGONLY= yes USE_APACHE= common22 USE_BZIP2= yes USE_ICONV= yes Index: Mk/bsd.apache.mk =================================================================== @@ -138,6 +138,12 @@ detected (make.conf), they shoud be UPPERCASE .endif +.for module in ${AVAILABLE_MODULES} +. if defined(WITH_${module}) +BROKEN= Please use the new options NG parameters, start by reading http://wiki.freebsd.org/Ports/Options/OptionsNG +. endif +.endfor
Instead of patching bsd.options.mk, you could simply put the .if ... BROKEN stanza in apache/Makefile before the .include <bsd.port.options.mk>; WITH variables are only defined after that unless in make.conf. .for o in ${OPTIONS_DEFINE} . if defined(WITH_$o) || defined(WITHOUT_$o) BROKEN=BLAH . endif .endfor I suggest this because I see it as an unusual situation. Have I been clear enough, or should I provide a patch? Chris
Thanks, thats also an Idea, will do some tests.
Author: ohauer Date: Sun Sep 9 17:01:30 2012 New Revision: 303982 URL: http://svn.freebsd.org/changeset/ports/303982 Log: - notice the users that old WITH/WITHOUT parameters are obsolete. Point them to the wiki Thanks to crees@ for this suggestion to implement this direct in the port PR: 171509 Modified: head/www/apache22/Makefile Modified: head/www/apache22/Makefile ============================================================================== --- head/www/apache22/Makefile Sun Sep 9 16:53:12 2012 (r303981) +++ head/www/apache22/Makefile Sun Sep 9 17:01:30 2012 (r303982) @@ -47,6 +47,24 @@ WITH_HTTP_PORT?= 80 MPM_ITK_VERSION?= 20110321-01 .include "${APACHEDIR}/Makefile.options" + +# stop users from using old WITH/WITHOUT parameters +.for opt in ${OPTIONS_DEFINE} +. if defined(WITH_${opt}) || defined(WITHOUT_${opt}) +BROKEN= WITH/WITHOUT parameters are obsolete. \ + The port use the new options NG framework. Please read\ + http://wiki.freebsd.org/Ports/Options/OptionsNG +. endif +.endfor + +.for cat in ${ALL_MODULES_CATEGORIES} +. if defined(WITH_${cat}_MODULES) +BROKEN= WITH/WITHOUT_..._MODULES parameters are obsolete. \ + The port use the new options NG framework. Please read\ + http://wiki.freebsd.org/Ports/Options/OptionsNG +. endif +.endfor + .include <bsd.port.options.mk> .include "${APACHEDIR}/Makefile.doc" _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Implemented the suggestion from crees@
Responsible Changed From-To: freebsd-ports-bugs->ohauer