- Update to 0.8.7.1 - Fix installation so it doesn't overwrite your config files every time you upgrade the port - Fix some space/tab issues to make portlint happy - Use dirrmtry in a few places because some people have their own custom filters, actions, etc. Added file(s): - files/patch-setup.py Port maintainer (theis@gmx.at) is cc'd. Generated with FreeBSD Port Tools 0.99_6 (mode: update, diff: suffix)
Responsible Changed From-To: freebsd-ports-bugs->swills swills@ wants his PRs (via the GNATS Auto Assign Tool)
Maintainer of security/py-fail2ban, Please note that PR ports/171708 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171708 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
> Port maintainer (theis@gmx.at) is cc'd. I had it on my TODO list ... Most is OK (and straightforward, anyway). But: Overwriting files (that was keeping me from submitting the patch so far): According to http://www.fail2ban.org/wiki/index.php/MANUAL_0_8#Configuration local modifications may / should be done in a file named "<something>.local", e.g. "jail.local". It would be nice to remind people to do it that way and don't mess around with the .conf files in a installation message and / or UPDATE message. Are you now using the .dist files instead of the .conf files? I don't think that would be a good idea because then people have to copy them to .conf for their local modifications and thus deviate from the manual. Best regards Christoph
On Mon, 17 Sep 2012 09:08:25 -0500, Christoph Theis <theis@gmx.at> wrote: > Are you now using the .dist files instead of the .conf files? I don't > think that would be a good idea because then people have to copy them to > .conf for their local modifications and thus deviate from the manual. I was going to have it install to .dist files and then the user has to copy to .conf before using the software. Like most people, I've never read their entire manual because the software is pretty self explanatory. I never even knew about the .local files until you pointed it out now. This is sort of bizarre; not many programs work like this. In that case I think it's probably best to ignore this patch and instead update the port with a big warning saying to use .local files instead. I'll be replying with those changes. Thanks
Hi! Am 17.09.2012 16:31, schrieb Mark Felder: > I was going to have it install to .dist files and then the user has to > copy to .conf before using the software. Like most people, I've never > read their entire manual because the software is pretty self > explanatory. I never even knew about the .local files until you pointed > it out now. This is sort of bizarre; not many programs work like this. Yes, it is. And was the source of some discussions in the past. Other ports install configuration files as .default or something else, copy them to the intended file if they don't exist (e.g. in the post-install step) and on deinstall remove both files if they are identical (e.g. in pkg-plist). But it is not really the fail2ban way to do the configuration. > In that case I think it's probably best to ignore this patch and instead > update the port with a big warning saying to use .local files instead. > I'll be replying with those changes. OK. And thanks for the patch. Best regards Christoph
Please review the attached patch. Thanks!
Am 17.09.2012 17:43, schrieb Mark Felder: > Please review the attached patch. It's OK. Thanks Christoph
State Changed From-To: feedback->open Maintainer approved.
State Changed From-To: open->closed Committed, with minor changes. Thanks!