Bug 171808 - Option error in ports Makefile of multimedia/xbmc
Summary: Option error in ports Makefile of multimedia/xbmc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 10:00 UTC by Manuel
Modified: 2012-09-20 10:32 UTC (History)
0 users

See Also:

Attachments
file.diff (311 bytes, patch)
2012-09-20 10:00 UTC, Manuel 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel 2012-09-20 10:00:23 UTC 
Option checking for avahi support in multimedia/xbmc's Makefile is mispelled.
See attached patch for correction.

Fix: patch for the Makefile :
--- Makefile.orig       2012-09-20 10:39:08.000000000 +0200
+++ Makefile    2012-09-20 10:37:51.000000000 +0200
@@ -101,7 +101,7 @@
 PLIST_SUB+=    ARCH="x86_64"
 .endif

-.if ${PORT_OPTIONS:MAVAHAHI}
+.if ${PORT_OPTIONS:MAVAHI}
 CONFIGURE_ARGS+=       --enable-avahi
 LIB_DEPENDS+=  avahi-common:${PORTSDIR}/net/avahi-app
 .else


Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-20 10:00:34 UTC 
Maintainer of multimedia/xbmc,

Please note that PR ports/171808 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171808

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-20 10:00:36 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 mickael.maillot 2012-09-20 10:08:31 UTC 
you are right, thanks for the report !
Comment 4 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2012-09-20 10:20:36 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->rm

I will take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-09-20 10:29:13 UTC 
Author: rm
Date: Thu Sep 20 09:28:55 2012
New Revision: 304571
URL: http://svn.freebsd.org/changeset/ports/304571

Log:
  - fix avahi option name
  
  PR:		171808
  Submitted by:	Manuel <manuel.creach at gmail dot com>
  Approved by:	Mickael Maillot <mickael.maillot at gmail dot com> (maintainer)

Modified:
  head/multimedia/xbmc/Makefile

Modified: head/multimedia/xbmc/Makefile
==============================================================================
--- head/multimedia/xbmc/Makefile	Thu Sep 20 09:19:34 2012	(r304570)
+++ head/multimedia/xbmc/Makefile	Thu Sep 20 09:28:55 2012	(r304571)
@@ -101,7 +101,7 @@ PLIST_SUB+=	ARCH="x86"
 PLIST_SUB+=	ARCH="x86_64"
 .endif
 
-.if ${PORT_OPTIONS:MAVAHAHI}
+.if ${PORT_OPTIONS:MAVAHI}
 CONFIGURE_ARGS+=	--enable-avahi
 LIB_DEPENDS+=	avahi-common:${PORTSDIR}/net/avahi-app
 .else
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2012-09-20 10:32:16 UTC 
State Changed
From-To: feedback->closed

Committed, thank you!