- switch back to cgit snapshot[1][2] - switch to XZ format, it's smaller: 139k (gz) vs. 129k (bz2) vs. 124k (xz) - don't overwrite .cfg upon install - drop gmake(1) dep as docs aren't built anyway - properly USE_AUTOTOOLS which implies GNU_CONFIGURE [1] with cgit we can easily switch between tags or branches with downside being increased buildtime due to autotools [2] gzip(1) stores original name (FNAME) and modification time (MTIME) in its header by default which causes cgit/gitweb snapshots to have different checksum every time snapshot is generated. http://www.gzip.org/zlib/rfc-gzip.html
Responsible Changed From-To: eadler->freebsd-ports-bugs how did I get this one? I can't deal with it now - sorry.
Responsible Changed From-To: freebsd-ports-bugs->madpilot I'll take it.
Hi, I'm testing your patch. I have converted the port to optionsng also. Would you be interested in becoming the maintainer for this port? In sucha case just state it and I also need your approval for this patch. Thank you. -- Guido Falsi <madpilot@FreeBSD.org>
State Changed From-To: open->feedback Ask for submitter approval.
PLease ignore previous patch, it's wrong. See attached one. Sorry! :) -- Guido Falsi <madpilot@FreeBSD.org>
Guido Falsi <madpilot@FreeBSD.org> writes: > Hi, > > I'm testing your patch. I have converted the port to optionsng also. > > Would you be interested in becoming the maintainer for this port? In > sucha case just state it and I also need your approval for this patch. No. > -.include <bsd.port.pre.mk> > +.include <bsd.options.mk> * it should be <bsd.port.options.mk> * last line still has <bsd.port.post.mk> > -.if defined(WITH_DEBUG) > +.if ${PORT_OPTIONS:MDEBUG ^^ typo > -.if defined(STRIP) && ${STRIP} != "" > +.if {PORT_OPTIONS:MSTRIP} ^^ typo STRIP is an undocumented feature of WITH_DEBUG (in bsd.port.mk) and DEBUG_FLAGS (in bsd.own.mk). It governs stripping binaries in bsd.prog.mk, bsd.lib.mk and also ports that use INSTALL_MACROS in bsd.port.mk. Currently, to build/install a port and its dependencies with debug symbols one would $ make install WITH_DEBUG= # old way $ make install WITH=DEBUG # optionsNG way If you're going to suddenly require STRIP option being defined for *some* ports please document it, alongside changed WITH_DEBUG in bsd.port.mk.
On 10/22/12 18:20, Jan Beich wrote: > Guido Falsi <madpilot@FreeBSD.org> writes: > >> Hi, >> >> I'm testing your patch. I have converted the port to optionsng also. >> >> Would you be interested in becoming the maintainer for this port? In >> sucha case just state it and I also need your approval for this patch. > > No. > >> -.include <bsd.port.pre.mk> >> +.include <bsd.options.mk> > > * it should be <bsd.port.options.mk> > * last line still has <bsd.port.post.mk> > >> -.if defined(WITH_DEBUG) >> +.if ${PORT_OPTIONS:MDEBUG > ^^ typo > >> -.if defined(STRIP) && ${STRIP} != "" >> +.if {PORT_OPTIONS:MSTRIP} > ^^ typo > Sorry for these mistakes. I should really have checked better before sending the diff. > STRIP is an undocumented feature of WITH_DEBUG (in bsd.port.mk) and > DEBUG_FLAGS (in bsd.own.mk). It governs stripping binaries in bsd.prog.mk, > bsd.lib.mk and also ports that use INSTALL_MACROS in bsd.port.mk. Currently, > to build/install a port and its dependencies with debug symbols one would > > $ make install WITH_DEBUG= # old way > $ make install WITH=DEBUG # optionsNG way > > If you're going to suddenly require STRIP option being defined for *some* > ports please document it, alongside changed WITH_DEBUG in bsd.port.mk. > I stand corrected for this. I did not know about this STRIP feature. Since at this time we're in a feature freeze I can't touch bsd.port.mk and friends. I'll check on it and see if I can make a good patchset for this. In the while I'll remove these options. Thanks a lot for pointing this out! -- Guido Falsi <madpilot@FreeBSD.org>
This patch should work correctly. I thought I could take maintainership, since I maintain olther video acceleration pieces. PORTREVISION bump is needed since the package does change. -- Guido Falsi <madpilot@FreeBSD.org>
State Changed From-To: feedback->closed Committed. Thanks!