Partially revert r289869. readline removal from base was met with flak[1]. [1] http://marc.info/?l=freebsd-current&m=132254304216015
Maintainer of devel/gdb, Please note that PR ports/172077 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172077 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->zeising I'll take it.
unfortunately, I could not accept this patch... I tried to build gdb with this patch on redports and it failed on every system I tried... Moreover, I think it's better to use the ports readline library, it's more consistent with the actual gdb source... Best regards, Luca On Wed, Sep 26, 2012 at 3:20 AM, Edwin Groothuis <edwin@freebsd.org> wrote: > Maintainer of devel/gdb, > > Please note that PR ports/172077 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172077 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org
(please CC me, I don't get replies otherwise) Luca Pizzamiglio <luca.pizzamiglio@gmail.com> writes: > I tried to build gdb with this patch on redports and it failed on > every system I tried... bsd.port.mk adds port CFLAGS/LDFLAGS unconditionally on 10.0. This makes my patch fail there due to readline_echoing_p not being present in devel/readline. It's a known bug, see ports/172079. https://redports.org/buildarchive/20121011010307-18811/ # 10.0 not built https://redports.org/buildarchive/20121011020007-63264/ > Moreover, I think it's better to use the ports readline library, it's > more consistent with the actual gdb source... How about an option to choose the color then?
Hi, I integrated your patch in this Pr ports/172828, that also close the current one. I found and correct a small error: the line: .if ! ${PORT_OPTIONS:MBUNDLED_READLINE} doesn't work, the right one is: .if empty(PORT_OPTIONS:MBUNDLED_READLINE) Thanks for the support Luca
Luca Pizzamiglio <luca.pizzamiglio@gmail.com> writes: > Hi, I integrated your patch in this Pr ports/172828, that also close > the current one. > > I found and correct a small error: the line: > .if ! ${PORT_OPTIONS:MBUNDLED_READLINE} > > doesn't work, http://marc.info/?l=freebsd-ports&m=134951696126022 > the right one is: > .if empty(PORT_OPTIONS:MBUNDLED_READLINE) It's not "the" right one, just another way of spelling. > > Thanks for the support > Luca
State Changed From-To: feedback->closed Closing since this was committed as part of ports/172828.