Bug 172331 - [PATCH] games/castlevox: Makefile changed, OptionsNG, DESKTOP_ENTRIES...
Summary: [PATCH] games/castlevox: Makefile changed, OptionsNG, DESKTOP_ENTRIES...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-04 19:50 UTC by nemysis
Modified: 2013-03-08 08:40 UTC (History)
1 user (show)

See Also:


Attachments
CastleVox-1.2.patch (6.47 KB, patch)
2012-10-04 19:50 UTC, nemysis
no flags Details | Diff
castlevox.diff (4.31 KB, patch)
2013-02-22 17:52 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-10-04 19:50:10 UTC
Makefile changed

+DISTNAME=	${PORTNAME}-linux
+DIST_SUBDIR=	java

+COMMENT=	Fast world domination game

+WRKSRC=		${WRKDIR}/${PORTNAME}PC

+PLIST_FILES=	bin/${PORTNAME} \
+		share/pixmaps/${PORTNAME}.png

+PORTDATA=	*
+PORTDOCS=	README_Vox.txt docs/

+SUB_FILES=	${PORTNAME}

+DESKTOP_ENTRIES="Castle Vox" "${COMMENT}" "${PORTNAME}" \
+		"${PORTNAME}" "Game;StrategyGame;" ${FALSE}


- OptionsNG
+.include <bsd.port.options.mk>

- Rework do-install:
do-install:

- Rework CastleVox.in
files/CastleVox.in

Removed file(s):
- pkg-plist

Port maintainer (gamato@users.sf.net) is cc'd.

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: only one MASTER_SITE configured.  Consider adding additional mirrors.
0 fatal errors and 2 warnings found.

port test: clean
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2013-02-21 13:22:27 UTC
State Changed
From-To: open->feedback

Awaiting maintainer feedback 


Comment 2 Rene Ladan freebsd_committer freebsd_triage 2013-02-21 13:22:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Awaiting maintainer feedback
Comment 3 nemysis 2013-02-22 17:52:13 UTC
Restored pkg-plist


Port need docs in ${DATADIR}

@(cd ${WRKSRC} && ${COPYTREE_SHARE} "Support docs *.jar" ${DATADIR})


Changed all to ${PORTNAME}
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-03-08 08:34:58 UTC
Author: rene
Date: Fri Mar  8 08:34:49 2013
New Revision: 313626
URL: http://svnweb.freebsd.org/changeset/ports/313626

Log:
  - Add desktop entry
  - Convert to optionsNG
  - Trim leading article from COMMENT
  - Cleanups, overhaul installation
  - Sort pkg-plist
  - Bump PORTREVISION
  
  PR:		ports/172331
  Submitted by:	nemysis <nemysis@gmx.ch>
  Approved by:	maintainer timeout (months)

Modified:
  head/games/castlevox/Makefile
  head/games/castlevox/files/CastleVox.in
  head/games/castlevox/pkg-plist

Modified: head/games/castlevox/Makefile
==============================================================================
--- head/games/castlevox/Makefile	Fri Mar  8 08:33:07 2013	(r313625)
+++ head/games/castlevox/Makefile	Fri Mar  8 08:34:49 2013	(r313626)
@@ -1,32 +1,41 @@
-# Created by:			Martin Otto
-#
+# Created by: Martin Otto
 # $FreeBSD$
 
 PORTNAME=	CastleVox
 PORTVERSION=	1.2
+PORTREVISION=	1
 CATEGORIES=	games java
 MASTER_SITES=	http://sillysoft.net/download/
-DISTNAME=	CastleVox-linux
+DISTNAME=	${PORTNAME}-linux
 
 MAINTAINER=	gamato@users.sf.net
-COMMENT=	A fast world domination game
+COMMENT=	Fast world domination game
 
 FETCH_ARGS=	-Fpr
 USE_JAVA=	yes
 JAVA_VERSION=	1.6+
+NO_BUILD=	yes
 
-WRKSRC=		${WRKDIR}/CastleVoxPC
+WRKSRC=		${WRKDIR}/${PORTNAME}PC
+PORTDOCS=	README_Vox.txt
 DATADIR=	${JAVASHAREDIR}/${PORTNAME}
-NO_BUILD=	yes
 
-SUB_FILES=	CastleVox
+SUB_FILES=	${PORTNAME}
+
+DESKTOP_ENTRIES="Castle Vox" "${COMMENT}" \
+		"${PREFIX}/share/pixmaps/${PORTNAME}.png" \
+		"${PORTNAME}" "Game;StrategyGame;" false
+
+.include <bsd.port.options.mk>
 
 do-install:
-	@${MKDIR} ${DATADIR}
-	(cd ${WRKSRC}/ && ${COPYTREE_SHARE} \*.jar ${DATADIR})
-	${INSTALL_DATA} ${WRKSRC}/VoxIcon.png ${DATADIR}
-	(cd ${WRKSRC}/ && ${COPYTREE_SHARE} Support ${DATADIR})
-	(cd ${WRKSRC}/ && ${COPYTREE_SHARE} docs ${DATADIR})
-	${INSTALL_SCRIPT} ${WRKDIR}/CastleVox ${PREFIX}/bin
+	${INSTALL_SCRIPT} ${WRKDIR}/${PORTNAME} ${PREFIX}/bin
+	@(cd ${WRKSRC} && ${COPYTREE_SHARE} "Support docs *.jar" ${DATADIR})
+	${INSTALL_DATA} ${WRKSRC}/VoxIcon.png ${PREFIX}/share/pixmaps/${PORTNAME}.png
+
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
 
 .include <bsd.port.mk>

Modified: head/games/castlevox/files/CastleVox.in
==============================================================================
--- head/games/castlevox/files/CastleVox.in	Fri Mar  8 08:33:07 2013	(r313625)
+++ head/games/castlevox/files/CastleVox.in	Fri Mar  8 08:34:49 2013	(r313626)
@@ -2,7 +2,7 @@
 #
 # $FreeBSD$
 
-echo "Castle Vox: Starting up..."
-cd "%%DATADIR%%"
-JAVA_VERSION="%%JAVA_VERSION%%" exec "%%LOCALBASE%%/bin/java" \
--Djava.ext.dirs="%%DATADIR%%" -jar "%%DATADIR%%/VoxCore.jar" "$@"
+export JAVA_VERSION="%%JAVA_VERSION%%"
+
+cd "%%DATADIR%%" && exec "%%LOCALBASE%%/bin/java" \
+-Djava.ext.dirs="%%DATADIR%%" -jar "%%DATADIR%%/VoxCore.jar" "${@}"

Modified: head/games/castlevox/pkg-plist
==============================================================================
--- head/games/castlevox/pkg-plist	Fri Mar  8 08:33:07 2013	(r313625)
+++ head/games/castlevox/pkg-plist	Fri Mar  8 08:34:49 2013	(r313626)
@@ -1,12 +1,4 @@
 bin/CastleVox
-%%DATADIR%%/VoxCore.jar
-%%DATADIR%%/VoxIcon.png
-%%DATADIR%%/jide-charts.jar
-%%DATADIR%%/jide-common.jar
-%%DATADIR%%/jogg-0.0.7.jar
-%%DATADIR%%/jorbis-0.0.15.jar
-%%DATADIR%%/tritonus_share.jar
-%%DATADIR%%/vorbisspi1.0.3.jar
 %%DATADIR%%/Support/Maps/Hex Barons.voxb
 %%DATADIR%%/Support/Maps/Tutorial Map.voxb
 %%DATADIR%%/Support/Maps/World War II.voxb
@@ -43,6 +35,7 @@ bin/CastleVox
 %%DATADIR%%/Support/Themes/Tutorial Map/updater3.txt
 %%DATADIR%%/Support/Themes/Tutorial Map/updater4.txt
 %%DATADIR%%/Support/Themes/Tutorial Map/updater5.txt
+%%DATADIR%%/VoxCore.jar
 %%DATADIR%%/docs/Castle_Vox_Instructions.html
 %%DATADIR%%/docs/Castle_Vox_Shortcuts.html
 %%DATADIR%%/docs/Castle_Vox_Version_History.html
@@ -63,6 +56,13 @@ bin/CastleVox
 %%DATADIR%%/docs/docs_files/prefs.png
 %%DATADIR%%/docs/docs_files/recruit.png
 %%DATADIR%%/docs/docs_files/teammate.png
+%%DATADIR%%/jide-charts.jar
+%%DATADIR%%/jide-common.jar
+%%DATADIR%%/jogg-0.0.7.jar
+%%DATADIR%%/jorbis-0.0.15.jar
+%%DATADIR%%/tritonus_share.jar
+%%DATADIR%%/vorbisspi1.0.3.jar
+share/pixmaps/CastleVox.png
 @dirrm %%DATADIR%%/docs/docs_files
 @dirrm %%DATADIR%%/docs
 @dirrm %%DATADIR%%/Support/Themes/Tutorial Map
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2013-03-08 08:35:15 UTC
State Changed
From-To: feedback->closed

Committed, thanks