Bug 172859 - lang/python27 -- python2.7-config --clags wrong value when using clang
Summary: lang/python27 -- python2.7-config --clags wrong value when using clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Marcus von Appen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-18 21:10 UTC by martin
Modified: 2013-01-14 18:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description martin 2012-10-18 21:10:00 UTC
If I use clang to build python2.7, I get the following output from
python2.7-config --cflags

-I/usr/local/include/python2.7 -I/usr/local/include/python2.7 -fno-strict-aliasing -OPT:Olimit=0 -O2 -pipe -fno-strict-aliasing -DNDEBUG -O2 -pipe -fno-strict-aliasing

Note the `-OPT:Olimit=0'

If I use GCC4.2 from the base I don't have this:

-I/usr/local/include/python2.7 -I/usr/local/include/python2.7 -fno-strict-aliasing -O2 -pipe -fno-strict-aliasing -DNDEBUG -O2 -pipe -fno-strict-aliasing

I built the port twice with clang. Got the same results.

This is problematic, because all ports using python2.7-config to get their
CFLAGS won't build.

I would guess this line is the culpritm but I didn't investigate:
CONFIGURE_ENV+= OPT="${CFLAGS} ${_PTH_CPPFLAGS}"

Note this problem does not seem to exist with Python 3.2
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-18 21:10:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Marcus von Appen freebsd_committer freebsd_triage 2013-01-14 14:36:12 UTC
Responsible Changed
From-To: freebsd-python->mva

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-01-14 17:57:00 UTC
Author: mva
Date: Mon Jan 14 17:56:47 2013
New Revision: 310398
URL: http://svnweb.freebsd.org/changeset/ports/310398

Log:
  - Fix the -OPT:Olimit=X detection for clang, which could pollute the
    output of python27-config --cflags
  
  PR:		ports/172859 ports/161494 ports/174525
  Submitted by:	Oleg Nauman <oleg.nauman@gmail.com>

Added:
  head/lang/python27/files/patch-configure   (contents, props changed)
Modified:
  head/lang/python27/Makefile

Modified: head/lang/python27/Makefile
==============================================================================
--- head/lang/python27/Makefile	Mon Jan 14 17:55:58 2013	(r310397)
+++ head/lang/python27/Makefile	Mon Jan 14 17:56:47 2013	(r310398)
@@ -3,7 +3,7 @@
 
 PORTNAME=	python27
 PORTVERSION=	2.7.3
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	lang python ipv6
 MASTER_SITES=	${PYTHON_MASTER_SITES}
 MASTER_SITE_SUBDIR=	${PYTHON_MASTER_SITE_SUBDIR}

Added: head/lang/python27/files/patch-configure
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/lang/python27/files/patch-configure	Mon Jan 14 17:56:47 2013	(r310398)
@@ -0,0 +1,13 @@
+--- configure.orig	2013-01-14 13:38:53.000000000 +0000
++++ configure	2013-01-14 13:39:14.000000000 +0000
+@@ -5642,8 +5642,8 @@
+ 	BASECFLAGS="$BASECFLAGS $ac_arch_flags"
+ fi
+ 
+-# disable check for icc since it seems to pass, but generates a warning
+-if test "$CC" = icc
++# disable check for icc and clang since it seems to pass, but generates a warning
++if test "$CC" = icc -o "$CC" = clang
+ then
+   ac_cv_opt_olimit_ok=no
+ fi
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Marcus von Appen freebsd_committer freebsd_triage 2013-01-14 17:57:32 UTC
State Changed
From-To: open->closed

A fix has been committed. Thanks for reporting!