Bug 173207 - [PATCH] graphics/batik: Makefile changed, OptionsNG, take maintainership
Summary: [PATCH] graphics/batik: Makefile changed, OptionsNG, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-30 10:40 UTC by nemysis
Modified: 2012-11-04 10:54 UTC (History)
1 user (show)

See Also:

Attachments
batik-1.7_3.patch (3.67 KB, patch)
2012-10-30 10:40 UTC, nemysis 		no flags Details | Diff
batik.diff (1.78 KB, patch)
2012-11-04 10:03 UTC, nemysis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-10-30 10:40:00 UTC 
- Take maintainership

Removed file(s):
- pkg-plist

Makefile changed:
+LICENSE=	AL2
+PORTDATA=	*
+PORTDOCS=
+.include <bsd.port.options.mk>
+post-install:
+.if ${PORT_OPTIONS:MDOCS}

Changed:
pkg-descr

Generated and tested manually, tested with port test and with RedPorts (all RELEASES, CLANG), sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
looks fine.

port test: clean

Build log

https://redports.org/buildarchive/20121029231916-30691/
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2012-11-04 09:21:04 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jhale

I'll take it.
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2012-11-04 09:30:52 UTC 
The PORTDATA macro shouldn't be used here.  It should only be used if the 
installed data is optional and wrapped by:
.if !defined(NOPORTDATA)
    foo
.endif

If a user has NOPORTDATA defined, then the plist will be broken.  You should 
just keep the pkg-plist as is and remove the PORTDATA line.  I believe we have 
discussed this before.

Also for pkg-descr, we don't need all of that extra stuff explaining the 
project's goals and such.  A simple explaination of what the port does is 
sufficient.

-- 
Jason E. Hale - jhale@
FreeBSD Ports Committer
KDE/FreeBSD Team
Comment 3 nemysis 2012-11-04 10:03:49 UTC 
On Sun, 04 Nov 2012 04:30:52 -0500
"Jason E. Hale" <jhale@freebsd.org> wrote:

> The PORTDATA macro shouldn't be used here.  It should only be used if the 
> installed data is optional and wrapped by:
> .if !defined(NOPORTDATA)
>     foo
> .endif
> 
> If a user has NOPORTDATA defined, then the plist will be broken.  You should 
> just keep the pkg-plist as is and remove the PORTDATA line.  I believe we have 
> discussed this before.
> 
> Also for pkg-descr, we don't need all of that extra stuff explaining the 
> project's goals and such.  A simple explaination of what the port does is 
> sufficient.
> 

Thanks for yours suggestions i have used this.
Comment 4 Jason E. Hale freebsd_committer freebsd_triage 2012-11-04 10:54:39 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!