Bug 173447 - devel/st makefile is missing a file
Summary: devel/st makefile is missing a file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Felippe de Meirelles Motta
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 17:30 UTC by kevin
Modified: 2013-02-07 19:29 UTC (History)
0 users

See Also:

Attachments
file.diff (298 bytes, patch)
2012-11-07 17:30 UTC, kevin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kevin 2012-11-07 17:30:01 UTC 
ports devel/st has a FreeBSD supplied makefile in files/Makefile.main which builds okay, but is missing a file. Attempting to use libst anywhere produces:

/usr/local/lib/libst.so: undefined reference to `_st_eventsys'
/usr/local/lib/libst.so: undefined reference to `st_set_eventsys'

How-To-Repeat: Build and link anything to libst
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-07 17:30:09 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->lippe

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-02-07 19:18:03 UTC 
Author: lippe
Date: Thu Feb  7 19:17:55 2013
New Revision: 311880
URL: http://svnweb.freebsd.org/changeset/ports/311880

Log:
  - Fix Makefile to install event module recently added
  - Make portlint happy
  
  PR:		ports/162602, ports/173447
  Submitted by:	Mark Delany <z2n@delta.emu.st>, Kevin Day <kevin@your.org>

Modified:
  head/devel/st/Makefile   (contents, props changed)
  head/devel/st/files/Makefile.main   (contents, props changed)

Modified: head/devel/st/Makefile
==============================================================================
--- head/devel/st/Makefile	Thu Feb  7 19:07:07 2013	(r311879)
+++ head/devel/st/Makefile	Thu Feb  7 19:17:55 2013	(r311880)
@@ -1,12 +1,10 @@
-# New ports collection makefile for:    st
-# Date created:         Sun Feb 18 2001
-# Whom:                 tobez@tobez.org
-#
+# Created by: tobez
 # $FreeBSD$
 #
 
 PORTNAME=	st
 PORTVERSION=	1.9
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	SF/${PORTNAME}ate-threads/${PORTNAME}ate-threads/${PORTVERSION}
 
@@ -30,9 +28,11 @@ post-patch:
 
 post-install:
 	@${CP} ${WRKSRC}/public.h ${PREFIX}/include/st.h
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
 	@${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/docs/,} ${DOCSDIR}/
+.endif
+.if ${PORT_OPTIONS:MEXAMPLES}
 	@${MKDIR} ${EXAMPLESDIR}
 	@${INSTALL_DATA} ${EXAMPLES:S,^,${WRKSRC}/examples/,} ${EXAMPLESDIR}/
 .endif

Modified: head/devel/st/files/Makefile.main
==============================================================================
--- head/devel/st/files/Makefile.main	Thu Feb  7 19:07:07 2013	(r311879)
+++ head/devel/st/files/Makefile.main	Thu Feb  7 19:17:55 2013	(r311880)
@@ -8,7 +8,7 @@ SHLIB_MINOR=	1
 LIB=		st
 NO_PROFILE=	yes
 
-SRCS=		io.c key.c sched.c stk.c sync.c
+SRCS=		io.c key.c sched.c stk.c sync.c event.c
 CFLAGS+=	-DFREEBSD
 
 .include <bsd.lib.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Felippe de Meirelles Motta freebsd_committer freebsd_triage 2013-02-07 19:29:00 UTC 
State Changed
From-To: open->closed

Committed. Thanks!