Update to 3.8.3. Take maintainership.
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Maintainer of sysutils/logrotate, Please note that PR ports/173496 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/173496 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
A few quetsions about the patch: - Why logrotate.conf.sample has to be changed? This is just a sample. - Why custom logrotate files go to /etc? Don't every port config go to /usr/local/etc? - 'take maintainership' haven't been explained. Please elaborate. Regards, -- -jul-=
It looks like my previous email hasn't arrived. Here you are: - Why logrotate.conf.sample has to be changed? This is just a sample. - Why custom logrotate files go to /etc? Don't every port config go to = /usr/local/etc? - 'take maintainership' haven't been explained. Please elaborate. Regards, --=20 -jul- On Nov 9, 2012, at 12:20 PM, Edwin Groothuis <edwin@FreeBSD.org> wrote: > Maintainer of sysutils/logrotate, >=20 > Please note that PR ports/173496 has just been submitted. >=20 > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. >=20 > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/173496 >=20 > --=20 > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org
Responsible Changed From-To: freebsd-ports-bugs->wxs I'll take it.
Balazs, You raise valid points and while the submitter has been non-responsive to them parts of his PR are still valid. What do you think of the attached patch. It should eliminate all of your concerns (it does not touch logrotate.conf.sample, does not put anything in /etc and does not touch MAINTAINER) but it does update the port to the newer version. Do you have any thoughts on this patch? Do I have your approval to commit it? Would you just like me to close this PR and you'll eventually open another one with an update when you are ready? Please let me know how you want to proceed from here. Thanks! -- WXS
Wesley, I'm fine with all the other changes if the code is functional. However, my old patch used to contain some changes, which become inconsistent: - patch-config.h has not been touched, and it defines /usr/bin/mailx as default mail command. - patch-logrotate.8 has been changed, to remove mentioning mailx as the default mail command. I haven't tested the latest logrotate myself yet, but it looks like logrotate sets close-on-exec more or less the same as the FreeBSD port handled it (see https://fedorahosted.org/logrotate/changeset/296/trunk/config.c). The other big difference is to add another string length check to mbrtowc call, which was also been addressed (see https://fedorahosted.org/logrotate/changeset/343/trunk/config.c). To sum up, please leave out logrotate.conf.sample (it contains changes affecting logrotate.d being read from /etc), MAINTAINER, and patch-logrotate.8. All the other changes can be imported. Regards, -- -jul- On Dec 3, 2012, at 8:51 PM, Wesley Shields <wxs@FreeBSD.org> wrote: > Balazs, > > You raise valid points and while the submitter has been non-responsive > to them parts of his PR are still valid. What do you think of the > attached patch. It should eliminate all of your concerns (it does not > touch logrotate.conf.sample, does not put anything in /etc and does not > touch MAINTAINER) but it does update the port to the newer version. > > Do you have any thoughts on this patch? Do I have your approval to > commit it? Would you just like me to close this PR and you'll eventually > open another one with an update when you are ready? > > Please let me know how you want to proceed from here. Thanks! > > -- WXS
On Mon, Dec 03, 2012 at 09:48:49PM +0100, Balazs Nagy wrote: > Wesley, > > I'm fine with all the other changes if the code is functional. > However, my old patch used to contain some changes, which become > inconsistent: > > - patch-config.h has not been touched, and it defines /usr/bin/mailx > as default mail command. - patch-logrotate.8 has been changed, to > remove mentioning mailx as the default mail command. > > I haven't tested the latest logrotate myself yet, but it looks like > logrotate sets close-on-exec more or less the same as the FreeBSD port > handled it (see > https://fedorahosted.org/logrotate/changeset/296/trunk/config.c). The > other big difference is to add another string length check to mbrtowc > call, which was also been addressed (see > https://fedorahosted.org/logrotate/changeset/343/trunk/config.c). > > To sum up, please leave out logrotate.conf.sample (it contains changes > affecting logrotate.d being read from /etc), MAINTAINER, and > patch-logrotate.8. All the other changes can be imported. I think I forgot to attach the patch I referenced in my email. Please see the attached. I think it will address most of your concerns. Sorry about that! -- WXS
State Changed From-To: feedback->closed Committed. Thanks!