OptionsNG Changes Fix: Patch attached with submission follows:
Maintainer of audio/asunder, Please note that PR ports/173779 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/173779 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Well, let's upgrade to asunder-2.2 while we're at it. Thanks for your optionsng patch! Fraser Index: Makefile =================================================================== --- Makefile (revision 307711) +++ Makefile (working copy) @@ -1,12 +1,8 @@ -# New ports collection makefile for: asunder -# Date created: 14 September 2007 -# Whom: frase@frase.id.au -# +# Created by: frase@frase.id.au # $FreeBSD$ PORTNAME= asunder -PORTVERSION= 2.0 -PORTREVISION?= 2 +PORTVERSION= 2.2 CATEGORIES= audio MASTER_SITES= http://littlesvr.ca/asunder/releases/ @@ -16,38 +12,38 @@ LIB_DEPENDS= cddb.4:${PORTSDIR}/audio/libcddb RUN_DEPENDS= ${LOCALBASE}/bin/cdparanoia:${PORTSDIR}/audio/cdparanoia -OPTIONS= LAME "lame support" on \ - OGG "ogg-vorbis support" on \ - FLAC "FLAC support" on \ - WAVPACK "WavPack support" off \ - MONKEYAUDIO "Monkey's Audio support" off \ - WINDOWS_CHARS "Allow Windows special chars in filenames" off +OPTIONS_DEFINE= LAME OGG FLAC WAVPACK MONKEYAUDIO WINDOWS_CHARS +OPTIONS_DEFAULT= LAME OGG FLAC +MONKEYAUDIO_DESC= Monkey's Audio support +WINDOWS_CHARS_DESC= Allow Windows special chars in filenames + USE_BZIP2= yes GNU_CONFIGURE= yes +USE_GMAKE= yes USE_GNOME= gtk20 PORTDOCS= AUTHORS COPYING ChangeLog INSTALL NEWS README TODO -.include <bsd.port.pre.mk> +.include <bsd.port.options.mk> -.if defined(WITH_LAME) +.if ${PORT_OPTIONS:MLAME} RUN_DEPENDS+= lame:${PORTSDIR}/audio/lame .endif -.if defined(WITH_OGG) +.if ${PORT_OPTIONS:MOGG} RUN_DEPENDS+= oggenc:${PORTSDIR}/audio/vorbis-tools .endif -.if defined(WITH_FLAC) +.if ${PORT_OPTIONS:MFLAC} RUN_DEPENDS+= flac:${PORTSDIR}/audio/flac .endif -.if defined(WITH_WAVPACK) +.if ${PORT_OPTIONS:MWAVPACK} RUN_DEPENDS+= wavpack:${PORTSDIR}/audio/wavpack .endif -.if defined(WITH_MONKEYAUDIO) +.if ${PORT_OPTIONS:MMONKEYAUDIO} RUN_DEPENDS+= mac:${PORTSDIR}/audio/mac .endif @@ -62,4 +58,4 @@ @${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${DOCSDIR}/ .endif -.include <bsd.port.post.mk> +.include <bsd.port.mk> Index: distinfo =================================================================== --- distinfo (revision 307711) +++ distinfo (working copy) @@ -1,2 +1,2 @@ -SHA256 (asunder-2.0.tar.bz2) = f86539f3cbccf0727f654cbfad4f6b7dde4e5668973b5c74b3cf5041b70b9f4d -SIZE (asunder-2.0.tar.bz2) = 220593 +SHA256 (asunder-2.2.tar.bz2) = bb608c1cdefcce2f533fb5d5cc23838846b2810ec89d0ebb083507cf27e7822f +SIZE (asunder-2.2.tar.bz2) = 208936 Index: pkg-plist =================================================================== --- pkg-plist (revision 307711) +++ pkg-plist (working copy) @@ -1,4 +1,110 @@ bin/asunder +lib/locale/ar/LC_MESSAGES/asunder.mo +lib/locale/be@latin/LC_MESSAGES/asunder.mo +lib/locale/bg/LC_MESSAGES/asunder.mo +lib/locale/bs_BA/LC_MESSAGES/asunder.mo +lib/locale/ca/LC_MESSAGES/asunder.mo +lib/locale/cs/LC_MESSAGES/asunder.mo +lib/locale/da/LC_MESSAGES/asunder.mo +lib/locale/de/LC_MESSAGES/asunder.mo +lib/locale/el/LC_MESSAGES/asunder.mo +lib/locale/eo/LC_MESSAGES/asunder.mo +lib/locale/es/LC_MESSAGES/asunder.mo +lib/locale/eu/LC_MESSAGES/asunder.mo +lib/locale/fi/LC_MESSAGES/asunder.mo +lib/locale/fr/LC_MESSAGES/asunder.mo +lib/locale/hr/LC_MESSAGES/asunder.mo +lib/locale/hu/LC_MESSAGES/asunder.mo +lib/locale/it/LC_MESSAGES/asunder.mo +lib/locale/ja/LC_MESSAGES/asunder.mo +lib/locale/lv/LC_MESSAGES/asunder.mo +lib/locale/nb/LC_MESSAGES/asunder.mo +lib/locale/nl/LC_MESSAGES/asunder.mo +lib/locale/nn/LC_MESSAGES/asunder.mo +lib/locale/pl/LC_MESSAGES/asunder.mo +lib/locale/pt/LC_MESSAGES/asunder.mo +lib/locale/pt_BR/LC_MESSAGES/asunder.mo +lib/locale/ru/LC_MESSAGES/asunder.mo +lib/locale/sk/LC_MESSAGES/asunder.mo +lib/locale/sl/LC_MESSAGES/asunder.mo +lib/locale/sq/LC_MESSAGES/asunder.mo +lib/locale/sr/LC_MESSAGES/asunder.mo +lib/locale/sr@latin/LC_MESSAGES/asunder.mo +lib/locale/sv/LC_MESSAGES/asunder.mo +lib/locale/tr/LC_MESSAGES/asunder.mo +lib/locale/ur_PK/LC_MESSAGES/asunder.mo +lib/locale/zh_TW/LC_MESSAGES/asunder.mo share/applications/asunder.desktop share/pixmaps/asunder.png +@dirrmtry lib/locale/zh_TW/LC_MESSAGES +@dirrmtry lib/locale/zh_TW +@dirrmtry lib/locale/ur_PK/LC_MESSAGES +@dirrmtry lib/locale/ur_PK +@dirrmtry lib/locale/tr/LC_MESSAGES +@dirrmtry lib/locale/tr +@dirrmtry lib/locale/sv/LC_MESSAGES +@dirrmtry lib/locale/sv +@dirrmtry lib/locale/sr@latin/LC_MESSAGES +@dirrmtry lib/locale/sr@latin +@dirrmtry lib/locale/sr/LC_MESSAGES +@dirrmtry lib/locale/sr +@dirrmtry lib/locale/sq/LC_MESSAGES +@dirrmtry lib/locale/sq +@dirrmtry lib/locale/sl/LC_MESSAGES +@dirrmtry lib/locale/sl +@dirrmtry lib/locale/sk/LC_MESSAGES +@dirrmtry lib/locale/sk +@dirrmtry lib/locale/ru/LC_MESSAGES +@dirrmtry lib/locale/ru +@dirrmtry lib/locale/pt_BR/LC_MESSAGES +@dirrmtry lib/locale/pt_BR +@dirrmtry lib/locale/pt/LC_MESSAGES +@dirrmtry lib/locale/pt +@dirrmtry lib/locale/pl/LC_MESSAGES +@dirrmtry lib/locale/pl +@dirrmtry lib/locale/nn/LC_MESSAGES +@dirrmtry lib/locale/nn +@dirrmtry lib/locale/nl/LC_MESSAGES +@dirrmtry lib/locale/nl +@dirrmtry lib/locale/nb/LC_MESSAGES +@dirrmtry lib/locale/nb +@dirrmtry lib/locale/lv/LC_MESSAGES +@dirrmtry lib/locale/lv +@dirrmtry lib/locale/ja/LC_MESSAGES +@dirrmtry lib/locale/ja +@dirrmtry lib/locale/it/LC_MESSAGES +@dirrmtry lib/locale/it +@dirrmtry lib/locale/hu/LC_MESSAGES +@dirrmtry lib/locale/hu +@dirrmtry lib/locale/hr/LC_MESSAGES +@dirrmtry lib/locale/hr +@dirrmtry lib/locale/fr/LC_MESSAGES +@dirrmtry lib/locale/fr +@dirrmtry lib/locale/fi/LC_MESSAGES +@dirrmtry lib/locale/fi +@dirrmtry lib/locale/eu/LC_MESSAGES +@dirrmtry lib/locale/eu +@dirrmtry lib/locale/es/LC_MESSAGES +@dirrmtry lib/locale/es +@dirrmtry lib/locale/eo/LC_MESSAGES +@dirrmtry lib/locale/eo +@dirrmtry lib/locale/el/LC_MESSAGES +@dirrmtry lib/locale/el +@dirrmtry lib/locale/de/LC_MESSAGES +@dirrmtry lib/locale/de +@dirrmtry lib/locale/da/LC_MESSAGES +@dirrmtry lib/locale/da +@dirrmtry lib/locale/cs/LC_MESSAGES +@dirrmtry lib/locale/cs +@dirrmtry lib/locale/ca/LC_MESSAGES +@dirrmtry lib/locale/ca +@dirrmtry lib/locale/bs_BA/LC_MESSAGES +@dirrmtry lib/locale/bs_BA +@dirrmtry lib/locale/bg/LC_MESSAGES +@dirrmtry lib/locale/bg +@dirrmtry lib/locale/be@latin/LC_MESSAGES +@dirrmtry lib/locale/be@latin +@dirrmtry lib/locale/ar/LC_MESSAGES +@dirrmtry lib/locale/ar +@dirrmtry lib/locale @dirrmtry share/applications
State Changed From-To: feedback->open Maintainer has replied with updated patch.
Responsible Changed From-To: freebsd-ports-bugs->madpilot I'll take it.
Hi, The port installs locale data to ${PREFIX}/lib/locale. In FreeBSD such files live in share/locale. I have patched to fix this. I also finished the optionsng patch to cater for the default DOCS and NLS options while there, and added them to the OPTIONS_DEFINE variable, to make them also show up in the dialog. I have trimmed the Makefile header and added full identity for the port creator too. Hope there is no problem with this. If you'd rather leave just the email there, just tell me. Can you approve this patch? Thanks. -- Guido Falsi <madpilot@FreeBSD.org>
State Changed From-To: open->feedback Ask for maintainer approval.
State Changed From-To: feedback->open Maintainer has approved via private email.
State Changed From-To: open->closed Committed. Thanks!