Bug 173797 - [PATCH] audio/gnormalize optionsng
Summary: [PATCH] audio/gnormalize optionsng
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 22:30 UTC by Chris Petrik
Modified: 2013-01-10 17:55 UTC (History)
0 users

See Also:


Attachments
file.diff (2.56 KB, patch)
2012-11-21 22:30 UTC, Chris Petrik
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Petrik 2012-11-21 22:30:01 UTC
OptionsNG Changes

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-21 22:30:18 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-21 22:30:18 UTC
Maintainer of audio/gnormalize,

Please note that PR ports/173797 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/173797

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Wesley Shields freebsd_committer freebsd_triage 2012-11-29 16:37:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-01-08 16:22:47 UTC
Author: wxs
Date: Tue Jan  8 16:22:39 2013
New Revision: 310097
URL: http://svnweb.freebsd.org/changeset/ports/310097

Log:
  Convert to new options.
  Trim header.
  
  PR:		ports/173797
  Submitted by:	Chris Petrik <c.petrik.sosa@gmail.com>
  Approved by:	maintainer timeout

Modified:
  head/audio/gnormalize/Makefile   (contents, props changed)

Modified: head/audio/gnormalize/Makefile
==============================================================================
--- head/audio/gnormalize/Makefile	Tue Jan  8 16:19:46 2013	(r310096)
+++ head/audio/gnormalize/Makefile	Tue Jan  8 16:22:39 2013	(r310097)
@@ -1,9 +1,6 @@
-# New ports collection makefile for:	gnormalize
-# Date created:				27 Oct 2007
-# Whom:				Denise H. G. <darcsis@gmail.com>
+# Created by: Denise H. G. <darcsis@gmail.com>
 #
 # $FreeBSD$
-#
 
 PORTNAME=	gnormalize
 PORTVERSION=	0.63
@@ -24,58 +21,51 @@ NO_BUILD=	yes
 
 MAN1=		gnormalize.1
 
-OPTIONS=	\
-	GNORMALIZE_MP3	"WAV <-> MP3 Support"	on	\
-	GNORMALIZE_OGG	"Ogg Encoding and Playback"	on	\
-	GNORMALIZE_MP4	"WAV <-> MP4 Support"	on	\
-	GNORMALIZE_CDRIP	"CD Ripping"	off	\
-	GNORMALIZE_CDDB	"CDDB Support"	off	\
-	GNORMALIZE_CDPLAY	"CD Playback"	off	\
-	GNORMALIZE_FLAC	"FLAC Encoding and Playback"	off	\
-	GNORMALIZE_MAC	"Monkey's Audio Encoding and Playback"	off	\
-	GNORMALIZE_MPC	"MPC (musepack) Audio"	off
+OPTIONS_DEFINE=	MP3 OGG MP4 CDPARANOIA CDDB CDPLAY PLAC MAC MUSEPACK
+OPTIONS_DEFAULT=	MP3 OGG MP4
+
+MAC_DESC=	Monkey's Audio Encoding and Playback
+CDPLAY_DESC=	CD Playback
 
-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
-.if defined(WITH_GNORMALIZE_MP3)
+.if ${PORT_OPTIONS:MMP3}
 RUN_DEPENDS+=	lame:${PORTSDIR}/audio/lame \
 	p5-MP3-Info>=0:${PORTSDIR}/audio/p5-MP3-Info
 .endif
 
-.if defined(WITH_GNORMALIZE_OGG)
+.if ${PORT_OPTIONS:MOGG}
 RUN_DEPENDS+=	oggenc:${PORTSDIR}/audio/vorbis-tools
 .endif
 
-.if defined(WITH_GNORMALIZE_MP4)
+.if ${PORT_OPTIONS:MMP4}
 RUN_DEPENDS+=	faac:${PORTSDIR}/audio/faac \
 	faad:${PORTSDIR}/audio/faad
 .endif
 
-.if defined(WITH_GNORMALIZE_CDRIP)
-.if defined(WITH_CDDA2WAV)
-RUN_DEPENDS+=	cdda2wav:${PORTSDIR}/sysutils/cdrtools
+.if ${PORT_OPTIONS:MCDPARANOIA} || ${PORT_OPTIONS:MCDDA2WAV}
+USE_CDRTOOLS=	yes
 .else
 RUN_DEPENDS+=	cdparanoia:${PORTSDIR}/audio/cdparanoia
 .endif
-.endif
 
-.if defined(WITH_GNORMALIZE_CDDB)
+.if ${PORT_OPTIONS:MCDDB}
 RUN_DEPENDS+=	cddb.pl:${PORTSDIR}/audio/p5-CDDB_get
 .endif
 
-.if defined(WITH_GNORMALIZE_CDPLAY)
+.if ${PORT_OPTIONS:MCDPLAY}
 RUN_DEPENDS+=	p5-Audio-CD>=0:${PORTSDIR}/audio/p5-Audio-CD
 .endif
 
-.if defined(WITH_GNORMALIZE_FLAC)
+.if ${PORT_OPTIONS:MFLAC}
 RUN_DEPENDS+=	flac:${PORTSDIR}/audio/flac
 .endif
 
-.if defined(WITH_GNORMALIZE_MAC)
+.if ${PORT_OPTIONS:MMAC}
 RUN_DEPENDS+=	mac:${PORTSDIR}/audio/mac
 .endif
 
-.if defined(WITH_GNORMALIZE_MPC)
+.if ${PORT_OPTIONS:MMUSEPACK}
 RUN_DEPENDS+=	mppenc:${PORTSDIR}/audio/musepack
 .endif
 
@@ -91,4 +81,4 @@ post-patch:
 	@${REINPLACE_CMD} -e 's,/usr/share/gnormalize,${DATADIR},' \
 		${WRKSRC}/gnormalize
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Wesley Shields freebsd_committer freebsd_triage 2013-01-10 17:55:38 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!