Bug 173852 - I have fixed x11/slim so that the slim login manager terminates properly
Summary: I have fixed x11/slim so that the slim login manager terminates properly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-23 06:10 UTC by Douglas Carmichael
Modified: 2012-11-27 23:11 UTC (History)
0 users

See Also:

Attachments
file.diff (420 bytes, patch)
2012-11-23 06:10 UTC, Douglas Carmichael 		no flags Details | Diff
slim_rc.patch (427 bytes, patch)
2012-11-24 05:04 UTC, Henry Hu 		no flags Details | Diff
slim.diff (1.61 KB, patch)
2012-11-25 21:37 UTC, Guido Falsi 		no flags Details | Diff
slim.diff (2.08 KB, patch)
2012-11-26 19:33 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Carmichael 2012-11-23 06:10:00 UTC 
I have fixed the startup/shutdown script for the slim login manager so that slim can terminate properly upon a 'stop' command.

(The PID was not being properly found from the output of ps.)

Fix: A patch is attached.

Patch attached with submission follows:
How-To-Repeat: n/a
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-23 06:10:07 UTC 
Maintainer of x11/slim,

Please note that PR ports/173852 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/173852

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-23 06:10:08 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Henry Hu 2012-11-24 20:04:57 UTC 
The new patch is tested and verified. Please commit it.

-- 
Cheers,
Henry
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2012-11-24 20:12:52 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2012-11-25 17:18:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->madpilot

I'll take it.
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2012-11-25 21:37:20 UTC 
Hi,

I have noticed that slim fails compilation with clang. Here is an 
updated patch with a solution.

I obtained the modification to log.h from the project's own svn repository:

http://svn.berlios.de/viewvc/slim/trunk/log.h?r1=228&r2=227&pathrev=228

Can you approve this? Thanks.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2012-11-25 21:38:51 UTC 
State Changed
From-To: open->feedback

Ask for maintainer approval.
Comment 8 Guido Falsi freebsd_committer freebsd_triage 2012-11-26 19:33:25 UTC 
I also forgot, the ABI version numbers should be removed from 
LIB_DEPENDS. Also I forgot to bump PORTREVISION.

I'm attaching a revised patch for approval.
-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 9 Henry Hu 2012-11-27 04:43:36 UTC 
The patch looks ok. Shall we combine the two #ifdef?

-- 
Cheers,
Henry
Comment 10 Guido Falsi freebsd_committer freebsd_triage 2012-11-27 12:15:51 UTC 
On 11/27/12 05:43, Henry Hu wrote:
> The patch looks ok. Shall we combine the two #ifdef?
>

I thought about this myself, but since I have extracted it from the 
project's own svn repository I'd rather leave it unmodified.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 11 Henry Hu 2012-11-27 17:33:49 UTC 
OK, then let's commit this.


On Tue, Nov 27, 2012 at 7:15 AM, Guido Falsi <madpilot@freebsd.org> wrote:

> On 11/27/12 05:43, Henry Hu wrote:
>
>> The patch looks ok. Shall we combine the two #ifdef?
>>
>>
> I thought about this myself, but since I have extracted it from the
> project's own svn repository I'd rather leave it unmodified.
>
> --
> Guido Falsi <madpilot@FreeBSD.org>
>



-- 
Cheers,
Henry
Comment 12 Guido Falsi freebsd_committer freebsd_triage 2012-11-27 23:11:38 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!