Bug 173894 - [PATCH] net-mgmt/collectd5: enable users and zfs_arc plugins
Summary: [PATCH] net-mgmt/collectd5: enable users and zfs_arc plugins
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-24 18:40 UTC by pguyot
Modified: 2012-12-01 12:15 UTC (History)
0 users

See Also:


Attachments
collectd5.diff (16.16 KB, patch)
2012-11-24 18:40 UTC, pguyot
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pguyot 2012-11-24 18:40:00 UTC
The attached patch does the following:
- enable users plugin, which works as is;
- enable zfs_arc plugin, which has been ported to FreeBSD (patch has also been submitted upstream);
- make write_graphite optional, allowing it as the single output plugin (otherwise, at least another output plugin is required).

The port epoch hasn't been updated.
The patch includes a new file (to be added in svn): files/patch-src__zfs_arc.c
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-24 18:40:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

crees@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-24 18:40:33 UTC
Maintainer of net-mgmt/collectd5,

Please note that PR ports/173894 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/173894

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-24 18:40:34 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Krzysztof 2012-11-26 07:45:54 UTC
Hello,

On Sat, Nov 24, 2012 at 06:40:33PM +0000, Edwin Groothuis wrote:
> Maintainer of net-mgmt/collectd5,
> 
> Please note that PR ports/173894 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/173894
> 
> -- 
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
> 

Yes, I approve this patch.

Greetings,
-- 
Krzysztof Stryjek
UNIX administrator/Juniper Networks Specialist
email: wtp (at) bsdserwis (dot) com
http://www.linkedin.com/in/KrzysztofStryjek
GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C  91CD 1292 8959 DC61 0E76

In theory, there is no difference between theory and practice.
In practice, there is.
Comment 5 Chris Rees freebsd_committer freebsd_triage 2012-12-01 12:15:48 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!