Bug 174021 - Port sysutils/coreutils won't build when NLS is disabled
Summary: Port sysutils/coreutils won't build when NLS is disabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 18:50 UTC by rnejdl
Modified: 2013-02-07 16:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rnejdl 2012-11-30 18:50:00 UTC
If you disabled NLS support, then this port failed to build:

...

  CCLD   src/env
  CC     src/expand.o
  CCLD   src/expand
  CC     src/expr.o
  CCLD   src/expr
  CC     src/factor.o
  CCLD   src/factor
lib/libcoreutils.a(striconv.o): In function `str_cd_iconv':
striconv.c:(.text+0x63): undefined reference to `libiconv'
striconv.c:(.text+0xfa): undefined reference to `libiconv'
striconv.c:(.text+0x17a): undefined reference to `libiconv'
lib/libcoreutils.a(striconv.o): In function `str_iconv':
striconv.c:(.text+0x258): undefined reference to `libiconv_open'
striconv.c:(.text+0x27c): undefined reference to `libiconv_close'
striconv.c:(.text+0x2b5): undefined reference to `libiconv_close'
lib/libcoreutils.a(striconv.o): In function `mem_cd_iconv':
striconv.c:(.text+0x2fb): undefined reference to `libiconv'
striconv.c:(.text+0x382): undefined reference to `libiconv'
striconv.c:(.text+0x3cd): undefined reference to `libiconv'
striconv.c:(.text+0x432): undefined reference to `libiconv'
striconv.c:(.text+0x490): undefined reference to `libiconv'
lib/libcoreutils.a(striconv.o):striconv.c:(.text+0x4db): more undefined references to `libiconv' follow
gmake[2]: *** [src/factor] Error 1
gmake[2]: Leaving directory `/usr/ports/sysutils/coreutils/work/coreutils-8.20'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/sysutils/coreutils/work/coreutils-8.20'
gmake: *** [all] Error 2
*** [do-build] Error code 1

Stop in /usr/ports/sysutils/coreutils.
*** [build] Error code 1

Stop in /usr/ports/sysutils/coreutils.
Exit 1

How-To-Repeat: Disable NLS port and attempt to build the port.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-30 18:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bdrewery

bdrewery@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-30 18:50:09 UTC
Maintainer of sysutils/coreutils,

Please note that PR ports/174021 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174021

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-11-30 18:50:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Bryan Drewery freebsd_committer freebsd_triage 2012-12-24 15:47:44 UTC
Responsible Changed
From-To: bdrewery->freebsd-ports-bugs

Return to pool
Comment 5 Bryan Drewery freebsd_committer freebsd_triage 2013-02-07 16:05:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bdrewery

I'll take it.
Comment 6 Bryan Drewery freebsd_committer freebsd_triage 2013-02-07 16:40:24 UTC
State Changed
From-To: feedback->closed

Fixed.
Comment 7 dfilter service freebsd_committer freebsd_triage 2013-02-07 16:40:24 UTC
Author: bdrewery
Date: Thu Feb  7 16:40:11 2013
New Revision: 311871
URL: http://svnweb.freebsd.org/changeset/ports/311871

Log:
  - Fix build when NLS is disabled
  
  PR:		ports/174021 [1]
  PR:		ports/175745 [2]
  Reported by:	Rusty Nejdl <rnejdl@ringofsaturn.com> [1]
  Reported by:	Z Beeblebrox <zaphod@berentweb.com> [2]
  Approved by:	maintainer timeout
  Obtained from:	http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=88a6201

Added:
  head/sysutils/coreutils/files/patch-Makefile.in   (contents, props changed)
Modified:
  head/sysutils/coreutils/Makefile

Modified: head/sysutils/coreutils/Makefile
==============================================================================
--- head/sysutils/coreutils/Makefile	Thu Feb  7 15:40:02 2013	(r311870)
+++ head/sysutils/coreutils/Makefile	Thu Feb  7 16:40:11 2013	(r311871)
@@ -3,7 +3,7 @@
 
 PORTNAME=	coreutils
 PORTVERSION=	8.20
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	sysutils textproc
 MASTER_SITES=	${MASTER_SITE_GNU}
 MASTER_SITE_SUBDIR=	${PORTNAME}

Added: head/sysutils/coreutils/files/patch-Makefile.in
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/sysutils/coreutils/files/patch-Makefile.in	Thu Feb  7 16:40:11 2013	(r311871)
@@ -0,0 +1,11 @@
+--- Makefile.in.orig	2013-02-07 10:21:58.916462288 -0600
++++ Makefile.in	2013-02-07 10:22:05.081459567 -0600
+@@ -3114,7 +3114,7 @@
+ 
+ # for various GMP functions
+ src_expr_LDADD = $(LDADD) $(LIB_GMP)
+-src_factor_LDADD = $(LDADD) $(LIB_GMP)
++src_factor_LDADD = $(LDADD) $(LIB_GMP) $(LIBICONV)
+ src_false_LDADD = $(LDADD)
+ src_fmt_LDADD = $(LDADD)
+ src_fold_LDADD = $(LDADD)
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"