Bug 174022 - [PATCH] games/gnurobots: Added OptionsNG, license, desktop entry, icon, take maintainership
Summary: [PATCH] games/gnurobots: Added OptionsNG, license, desktop entry, icon, take ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rusmir Dusko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 20:20 UTC by nemysis
Modified: 2014-02-02 14:10 UTC (History)
0 users

See Also:


Attachments
gnurobots-1.2.0_9.patch (5.50 KB, patch)
2012-11-30 20:20 UTC, nemysis
no flags Details | Diff
gnurobots.diff (5.57 KB, patch)
2013-02-23 18:39 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-11-30 20:20:00 UTC
- Take maintainership

Added file(s):
- files/pkg-install.in
- files/pkg-message.in

Removed file(s):
- pkg-message

Makefile changed:
+MASTER_SITES=
+LICENSE=	GPLv3
+SUB_FILES=	pkg-install \
+		pkg-message
+DESKTOP_ENTRIES=
+.include <bsd.port.options.mk>
+.if ${PORT_OPTIONS:MDOCS}

Changed and refined:
Documentation
+PORTDOCS=	*
+DOCSRCDIR1=
+DOCSRCDIR2=

 post-install:
 pkg-plist

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
looks fine.

port test: clean
Comment 1 nemysis 2013-02-23 18:39:26 UTC
Changed

+DESKTOP_ENTRIES="GNU Robots" "${COMMENT}" \
+               "${PREFIX}/share/pixmaps/${PORTNAME}.png" \
+               "${PORTNAME}" "Game;ArcadeGame;" false
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2013-08-14 10:29:52 UTC
Responsible Changed
From-To: freebsd-ports-bugs->nemysis

submitter is now committer.
Comment 3 Rusmir Dusko freebsd_committer freebsd_triage 2014-02-02 13:50:37 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-02-02 14:08:26 UTC
Author: nemysis
Date: Sun Feb  2 14:08:17 2014
New Revision: 342296
URL: http://svnweb.freebsd.org/changeset/ports/342296
QAT: https://qat.redports.org/buildarchive/r342296/

Log:
  - Bump PORTREVISION
  - Change master sites and add icon
  - Take maintainership
  - Add license (GPLv3)
  - Use the new format for LIB_DEPENDS
  - Disable all warnings with -w
  - Support STAGEDIR
  - Change DOCS, add DOCS Option
  - Add files/pkg-install.in and files/pkg-message.in
  - Remove pkg-message
  - Add Desktop entry file
  - Change pkg-plist, add icon, remove DOCS
  
  PR:		ports/174022
  Submitted by:	nemysis (self)

Added:
  head/games/gnurobots/files/
  head/games/gnurobots/files/pkg-install.in   (contents, props changed)
  head/games/gnurobots/files/pkg-message.in   (contents, props changed)
Deleted:
  head/games/gnurobots/pkg-message
Modified:
  head/games/gnurobots/Makefile
  head/games/gnurobots/distinfo
  head/games/gnurobots/pkg-plist

Modified: head/games/gnurobots/Makefile
==============================================================================
--- head/games/gnurobots/Makefile	Sun Feb  2 14:04:43 2014	(r342295)
+++ head/games/gnurobots/Makefile	Sun Feb  2 14:08:17 2014	(r342296)
@@ -3,34 +3,55 @@
 
 PORTNAME=	gnurobots
 PORTVERSION=	1.2.0
-PORTREVISION=	8
+PORTREVISION=	9
 CATEGORIES=	games
-MASTER_SITES=	GNU
+MASTER_SITES=	GNU \
+		SF/nemysisfreebsdp/${CATEGORIES}/:icons
+DISTFILES=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX} \
+		${PORTNAME}.png:icons
+EXTRACT_ONLY=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX}
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	nemysis@FreeBSD.org
 COMMENT=	GNU diversion wherein Scheme-coded robots explore a world
 
-LIB_DEPENDS=	guile.21:${PORTSDIR}/lang/guile
+LICENSE=	GPLv3
+
+LIB_DEPENDS=	libguile.so:${PORTSDIR}/lang/guile
 
 USES=		pkgconfig
 USE_GNOME=	vte
 GNU_CONFIGURE=	yes
 
-CPPFLAGS+=	-I${LOCALBASE}/include ${PTHREAD_CFLAGS}
+CPPFLAGS+=	-I${LOCALBASE}/include ${PTHREAD_CFLAGS} -w
 LDFLAGS+=	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
 
-NO_STAGE=	yes
+PORTDOCS=	*
+
+DOCSRCDIR1=	${WRKSRC}
+DOC_FILES1=	AUTHORS ChangeLog NEWS README THANKS TODO
+
+DOCSRCDIR2=	${WRKSRC}/doc
+DOCSDIR2=	${DOCSDIR}/doc
+DOC_FILES2=	Robots-HOWTO contrib
+
+OPTIONS_DEFINE=	DOCS
+
+SUB_FILES=	pkg-install pkg-message
+
+DESKTOP_ENTRIES="GNU Robots" "" "${PORTNAME}" \
+		"${PORTNAME}" "Game;ArcadeGame;" ""
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|^CFLAGS=|#CFLAGS=|g' ${WRKSRC}/configure
 	@${REINPLACE_CMD} -e 's|#include <pty.h>||g' ${WRKSRC}/src/ui-cmdwin.c
 
 post-install:
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
-.for f in AUTHORS ChangeLog NEWS README THANKS doc/Robots-HOWTO doc/contrib
-	${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
-.endfor
-.endif
-	@${CAT} ${PKGMESSAGE}
+	${INSTALL_DATA} ${_DISTDIR}/${PORTNAME}.png \
+		${STAGEDIR}${PREFIX}/share/pixmaps/
+
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${DOC_FILES1:S|^|${DOCSRCDIR1}/|} ${STAGEDIR}${DOCSDIR}
+	@${MKDIR} ${STAGEDIR}${DOCSDIR2}
+	${INSTALL_DATA} ${DOC_FILES2:S|^|${DOCSRCDIR2}/|} ${STAGEDIR}${DOCSDIR2}
 
 .include <bsd.port.mk>

Modified: head/games/gnurobots/distinfo
==============================================================================
--- head/games/gnurobots/distinfo	Sun Feb  2 14:04:43 2014	(r342295)
+++ head/games/gnurobots/distinfo	Sun Feb  2 14:08:17 2014	(r342296)
@@ -1,2 +1,4 @@
 SHA256 (gnurobots-1.2.0.tar.gz) = 8b6f4f0d40bef5cfdfb7eb7c82ea1402d2747c37b2c7b7aa92faff55351df11d
 SIZE (gnurobots-1.2.0.tar.gz) = 176642
+SHA256 (gnurobots.png) = b5b422f26cd8a380a7891a3d894b5bac1cad744e5d1f29d32ff024b7c019158b
+SIZE (gnurobots.png) = 3052

Added: head/games/gnurobots/files/pkg-install.in
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/games/gnurobots/files/pkg-install.in	Sun Feb  2 14:08:17 2014	(r342296)
@@ -0,0 +1,17 @@
+#!/bin/sh
+#
+# $FreeBSD$
+#
+
+echo "This example maps you can use:"
+echo ""
+
+ls -x %%DATADIR%%/maps
+echo ""
+
+echo "This example robots you can use:"
+echo ""
+
+ls -x %%DATADIR%%/scheme
+echo ""
+echo ""

Added: head/games/gnurobots/files/pkg-message.in
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/games/gnurobots/files/pkg-message.in	Sun Feb  2 14:08:17 2014	(r342296)
@@ -0,0 +1,12 @@
+===============================================================================
+
+GNU Robots has been installed.
+
+Where to find things
+
+  - A place to start: %%DOCSDIR%%/doc/Robots-HOWTO
+  - Example maps:     %%DATADIR%%/maps/
+  - Example robots:   %%DATADIR%%/scheme/
+  - Binaries:         gnurobots
+
+===============================================================================

Modified: head/games/gnurobots/pkg-plist
==============================================================================
--- head/games/gnurobots/pkg-plist	Sun Feb  2 14:04:43 2014	(r342295)
+++ head/games/gnurobots/pkg-plist	Sun Feb  2 14:08:17 2014	(r342296)
@@ -1,11 +1,4 @@
 bin/gnurobots
-%%PORTDOCS%%%%DOCSDIR%%/AUTHORS
-%%PORTDOCS%%%%DOCSDIR%%/ChangeLog
-%%PORTDOCS%%%%DOCSDIR%%/NEWS
-%%PORTDOCS%%%%DOCSDIR%%/README
-%%PORTDOCS%%%%DOCSDIR%%/Robots-HOWTO
-%%PORTDOCS%%%%DOCSDIR%%/THANKS
-%%PORTDOCS%%%%DOCSDIR%%/contrib
 %%DATADIR%%/maps/maze.map
 %%DATADIR%%/maps/pattern.map
 %%DATADIR%%/maps/small.map
@@ -15,7 +8,7 @@ bin/gnurobots
 %%DATADIR%%/scheme/simple.scm
 %%DATADIR%%/scheme/stop.scm
 %%DATADIR%%/scheme/zap.scm
+share/pixmaps/gnurobots.png
 @dirrm %%DATADIR%%/scheme
 @dirrm %%DATADIR%%/maps
 @dirrm %%DATADIR%%
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"