The patch is attached to this PR. textproc/libxslt is added to the build dependencies because Darktable's CMakeLists.txt requires xsltproc(1) or saxon-xslt. The missing dependency was spotted thanks to poudriere. Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->danfe Over to maintainer (via the GNATS Auto Assign Tool)
Jean-Sébastien Pédron wrote on 02.12.2012 19:35: > >> Number: 174058 >> Category: ports >> Synopsis: [PATCH] Update graphics/darktable to 1.1 [...] > --- graphics/darktable/pkg-plist (revision 308074) > +++ graphics/darktable/pkg-plist (working copy) > @@ -1,16 +1,29 @@ > bin/darktable > +bin/darktable-cli > bin/darktable-cltest > %%DATADIR%%/darktable.gtkrc > %%DATADIR%%/gdb_commands > +%%DATADIR%%/js/.DS_Store ^^^^^^^^^ This guy shouldn't be there. Please remove it before install. -- Regards, Ruslan Tinderboxing kills... the drives.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02.12.2012 20:44, Ruslan Makhmatkhanov wrote: >> +%%DATADIR%%/js/.DS_Store > ^^^^^^^^^ This guy shouldn't be there. Please remove it before > install. I already reported the problem upstream but forgot to fix this in the port. Thanks! While here, I changed two other things in the patch: 1. Fix the path to the archive on Sourceforge, because the version has only two part (X.Y), not three (X.Y.Z). 2. Remove the "s,_XOPEN_SOURCE 700,_WITH_DPRINTF," patch to darktable.h because it's fixed upstream. - -- Jean-Sébastien Pédron -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iEYEARECAAYFAlC8cJoACgkQa+xGJsFYOlMcwgCfQYdT08KalCJDKqWklXVvhKvF L+IAn3otSauUaRl6IiN28U3jcjzZPxyz =LA4J -----END PGP SIGNATURE-----
Jean-Sébastien Pédron wrote on 03.12.2012 13:27: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 02.12.2012 20:44, Ruslan Makhmatkhanov wrote: >>> +%%DATADIR%%/js/.DS_Store >> ^^^^^^^^^ This guy shouldn't be there. Please remove it before >> install. > > I already reported the problem upstream but forgot to fix this in the > port. Thanks! > > While here, I changed two other things in the patch: > > 1. Fix the path to the archive on Sourceforge, because the version > has only two part (X.Y), not three (X.Y.Z). > > 2. Remove the "s,_XOPEN_SOURCE 700,_WITH_DPRINTF," patch to > darktable.h because it's fixed upstream. Thank you, it's now up to danfe to commit. -- Regards, Ruslan Tinderboxing kills... the drives.
State Changed From-To: open->analyzed Thank you (both) for your submissions (pkg-plist part is the most useful). Unfortunately, update to 1.1 takes more than just that. There are two new options that must be taken care of (to prevent silent dependency injection) as well as several build fixes. Stay tuned, it should be updated soonish.
State Changed From-To: analyzed->closed Port was updated to version 1.1, thanks!