Bug 174063 - [PATCH] misc/figlet-fonts: update to 20121202, take maintainership
Summary: [PATCH] misc/figlet-fonts: update to 20121202, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-02 21:30 UTC by nemysis
Modified: 2012-12-07 06:04 UTC (History)
0 users

See Also:

Attachments
figlet-fonts-20121202.patch (45.78 KB, patch)
2012-12-02 21:30 UTC, nemysis 		no flags Details | Diff
figlet-fonts.diff (45.86 KB, patch)
2012-12-04 17:58 UTC, nemysis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-12-02 21:30:00 UTC 
- Update to 20121202
- Take maintainership

Removed file(s):
- files/fontfiles

Makefile changed:
+DIST_SUBDIR=	figlet
+DATADIR=	${PREFIX}/share/figlet
+PLIST_SUB=	DATADIR=${DATADIR:S|^${PREFIX}/||}
+post-extract:

Changed and refined:
 do-install:

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: update, diff: ports)

How-To-Repeat: 
portlint -A
looks fine.

port test: clean
Comment 1 David E. O'Brien freebsd_committer freebsd_triage 2012-12-04 17:48:14 UTC 
copied from PR 174064:

On Tue, Dec 04, 2012 at 11:31:54AM +0100, nemysis wrote:
> Yes PkgNG is better but normally binary packages not have Options, and this
> is needed to install additional Fonts, for this i have made an other PR
> 
> ports/174063 : [PATCH] misc/figlet-fonts: update to 20121202, take maintainership

I took a quick look at PR 174063:

-RUN_DEPENDS=   figlet:${PORTSDIR}/misc/figlet

You may want to leave that in.  I won't be adding a RUN_DEPENDS for
figlet on the optional figlet-fonts.

-- 
-- David  (obrien@FreeBSD.org)
Comment 2 David E. O'Brien freebsd_committer freebsd_triage 2012-12-04 17:53:21 UTC 
-# Generate pkg-plist from files/fontfiles.
-
-makelist:
-	${CAT} ${FILESDIR}/fontfiles | ${SED} 's;^[^/]*/;share/figlet/;' \
-		> ${PLIST}

I may have missed someting, but why remove this helper?
The "share/figlet/" should be "%%DATADIR%%" instead.
But otherwise this is a very useful function.
Comment 3 nemysis 2012-12-04 17:58:21 UTC 
Add

RUN_DEPENDS=   figlet:${PORTSDIR}/misc/figlet
Comment 4 nemysis 2012-12-04 18:05:28 UTC 
On Tue, 4 Dec 2012 09:53:21 -0800
David O'Brien <obrien@FreeBSD.org> wrote:

> -# Generate pkg-plist from files/fontfiles.
> -
> -makelist:
> -	${CAT} ${FILESDIR}/fontfiles | ${SED} 's;^[^/]*/;share/figlet/;' \
> -		> ${PLIST}
> 
> I may have missed someting, but why remove this helper?
> The "share/figlet/" should be "%%DATADIR%%" instead.


Yes this was faulty in old Port i use %%DATADIR%% in all mine Ports.

> But otherwise this is a very useful function.


Please look there is now

pkg-plist

%%DATADIR%%/1943____.flf
...
Comment 5 David E. O'Brien freebsd_committer freebsd_triage 2012-12-04 18:15:20 UTC 
On Tue, Dec 04, 2012 at 07:05:28PM +0100, nemysis wrote:
> On Tue, 4 Dec 2012 09:53:21 -0800 David O'Brien <obrien@FreeBSD.org> wrote:
> > -# Generate pkg-plist from files/fontfiles.
> > -
> > -makelist:
> > -	${CAT} ${FILESDIR}/fontfiles | ${SED} 's;^[^/]*/;share/figlet/;' \
> > -		> ${PLIST}
> > 
> > I may have missed someting, but why remove this helper?
> > The "share/figlet/" should be "%%DATADIR%%" instead.
> 
> Yes this was faulty in old Port i use %%DATADIR%% in all mine Ports.

I believe you're missing my point.  Rather than delete all those lines,
just make this change:

-	${CAT} ${FILESDIR}/fontfiles | ${SED} 's;^[^/]*/;share/figlet/;' \
+	${CAT} ${FILESDIR}/fontfiles | ${SED} 's;^[^/]*/;%%DATADIR%%/;' \

-- 
-- David  (obrien@FreeBSD.org)
Comment 6 Beech Rintoul freebsd_committer freebsd_triage 2012-12-06 08:00:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->beech

I'll take it
Comment 7 Beech Rintoul freebsd_committer freebsd_triage 2012-12-07 06:03:53 UTC 
State Changed
From-To: open->closed

Committed, Thanks!