- Update to version 2.14.0 [audio/timidity++] New file: files/patch-interface__Makefile.in files/patch-timidity__Makefile.in Remove file: files/patch-configure files/patch-dynamic files/patch-playmidi files/patch-x_sherry.c files/patch-xaw_i.c
Responsible Changed From-To: freebsd-ports-bugs->araujo I'll take it.
State Changed From-To: open->feedback Please, send me a diff and not a sha file.
Here is the corrected patches.
State Changed From-To: feedback->open Feedback received.
Remake of the patch against current tree.
-Wl, --export-dynamic must be both Makefile and Makefile.interface files (PR 174939). Another way moved it LDFLAGS to place before .if !defined(PKGNAMESUFFIX). With Timidity++ can use audio/eawplus instead audio/eawpats, because format timidity.cfg from eawplus support only Timidity++ (used new option for tonebank). -- sorry for bad english.
green dog (fiziologus@gmail.com) wrote: > -Wl, --export-dynamic must be both Makefile and Makefile.interface files (PR 174939). Another way moved it LDFLAGS to place before .if !defined(PKGNAMESUFFIX). Although LDFLAGS in master Makefile is passed to interface modules, it isn't referred during linking at all. To use this flag correctly, it has to be put in options for SHLD. Meanwhile, I've never seen any particular problem without adding -Wl,--export-dynamic to interface modules. Could you tell me what will happen with or without this flag? > With Timidity++ can use audio/eawplus instead audio/eawpats, because format timidity.cfg from eawplus support only Timidity++ (used new option for tonebank). I'll soon add it as optional RUN_DEPENDS.
runtime error for slave (interface) ports: connot find <some>.so 2013/3/15 KATO Tsuguru <tkato432@yahoo.com> > green dog (fiziologus@gmail.com) wrote: > > > -Wl, --export-dynamic must be both Makefile and Makefile.interface files > (PR 174939). Another way moved it LDFLAGS to place before .if > !defined(PKGNAMESUFFIX). > > Although LDFLAGS in master Makefile is passed to interface > modules, it isn't referred during linking at all. To use this flag > correctly, it has to be put in options for SHLD. > > Meanwhile, I've never seen any particular problem without adding > -Wl,--export-dynamic to interface modules. Could you tell me what > will happen with or without this flag? > > > With Timidity++ can use audio/eawplus instead audio/eawpats, because > format timidity.cfg from eawplus support only Timidity++ (used new option > for tonebank). > > I'll soon add it as optional RUN_DEPENDS. > -- sorry for bad english.
green dog (fiziologus@gmail.com) wrote: > runtime error for slave (interface) ports: connot find <some>.so I've seen that error previously with some unusual configuration, but I can't figure out how to reproduce at present. As a matter of fact, it doesn't seem that additional linker flag would be necessary. Even on version 2.13.2 with concealing that flag from both Makefile and Makefile.interface, timidity++ can list dynamic load interfaces and show GUI properly. This behavior probably shouldn't be unexpected since linker flag in master port contains -rdynamic, which is practically the same as -Wl,--export-dynamic. Do you know an infallible method to cause the error?
Sorry. My memory fails me. I'm getting old. Only Makefile. 2013/3/17 KATO Tsuguru <tkato432@yahoo.com> > green dog (fiziologus@gmail.com) wrote: > > > runtime error for slave (interface) ports: connot find <some>.so > > I've seen that error previously with some unusual configuration, > but I can't figure out how to reproduce at present. > > As a matter of fact, it doesn't seem that additional linker flag > would be necessary. Even on version 2.13.2 with concealing that > flag from both Makefile and Makefile.interface, timidity++ can > list dynamic load interfaces and show GUI properly. > > This behavior probably shouldn't be unexpected since linker flag > in master port contains -rdynamic, which is practically the same > as -Wl,--export-dynamic. > > Do you know an infallible method to cause the error? > -- sorry for bad english.
Responsible Changed From-To: araujo->freebsd-ports-bugs - I have no time to take care of it anymore.
Responsible Changed From-To: freebsd-ports-bugs->miwi I'll take it.
State Changed From-To: open->feedback configure patch rejected in audio/timidity++
Here is the corrected patch.
State Changed From-To: feedback->open Submitter has fixed.
State Changed From-To: open->feedback Kato, patch -p2 < audio_timidity++.diff , patch-configure fails and rejecte, after solving that make patch fails with patch-Makefile.in Could u please revisit that. thanks in advance.
Oh, it's likely that some unforeseen modifications happened inside the GNATS.
State Changed From-To: feedback->open .
State Changed From-To: open->feedback files/patch-configure fails and reject.
State Changed From-To: feedback->open got a new patch
State Changed From-To: open->feedback http://pkgdev.miwibox.org/data/84amd64-default/2014-05-21_05h04m45s/logs/errors/timidity++-2.14.0.log
State Changed From-To: feedback->open new patch
State Changed From-To: open->feedback I am sorry ... > Found saved configuration for timidity++-2.14.0 ===> timidity++-2.14.0 depends on file: /usr/local/sbin/pkg - found ===> Fetching all distfiles required by timidity++-2.14.0 for building ===> Extracting for timidity++-2.14.0 => SHA256 Checksum OK for TiMidity++-2.14.0.tar.bz2. ===> Patching for timidity++-2.14.0 ===> Applying FreeBSD patches for timidity++-2.14.0 Ignoring previously applied (or reversed) patch. 1 out of 1 hunks ignored--saving rejects to interface/tk_c.c.rej Ignoring previously applied (or reversed) patch. 1 out of 1 hunks ignored--saving rejects to interface/tk_c.c.rej Ignoring previously applied (or reversed) patch. 1 out of 1 hunks ignored--saving rejects to interface/tk_c.c.rej => Patch patch-interface__tk_c.c failed to apply cleanly. => Patch(es) patch-Makefile.in patch-interface__Makefile.in applied cleanly. *** Error code 1 Stop. make[1]: stopped
It would be probably due to empty files left in port directory after applying the patch.
reopen
Committed.
A commit references this bug: Author: miwi Date: Thu Jun 5 07:31:05 UTC 2014 New revision: 356603 URL: http://svnweb.freebsd.org/changeset/ports/356603 Log: - Update to version 2.14.0 PR: 174176 Submitted by: ports fury Changes: head/audio/timidity++/Makefile head/audio/timidity++/Makefile.interface head/audio/timidity++/distinfo head/audio/timidity++/files/patch-Makefile.in head/audio/timidity++/files/patch-configure head/audio/timidity++/files/patch-dynamic head/audio/timidity++/files/patch-interface__Makefile.in head/audio/timidity++/files/patch-interface__tk_c.c head/audio/timidity++/files/patch-playmidi head/audio/timidity++/files/patch-timidity__Makefile.in head/audio/timidity++/files/patch-x_sherry.c head/audio/timidity++/files/patch-xaw_i.c head/audio/timidity++/pkg-descr head/audio/timidity++/pkg-plist head/audio/timidity++-emacs/Makefile head/audio/timidity++-gtk/Makefile head/audio/timidity++-motif/Makefile head/audio/timidity++-slang/Makefile head/audio/timidity++-tcltk/Makefile head/audio/timidity++-tcltk/pkg-plist head/audio/timidity++-xaw/Makefile head/audio/timidity++-xaw/pkg-plist head/audio/timidity++-xskin/Makefile head/audio/timidity++-xskin/pkg-plist head/japanese/timidity++-slang/Makefile head/japanese/timidity++-tcltk/Makefile head/japanese/timidity++-tcltk/pkg-plist