Bug 174548 - textproc/asciidoc pkg-plist incorrect
Summary: textproc/asciidoc pkg-plist incorrect
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 20:00 UTC by Dan McGregor
Modified: 2012-12-19 22:48 UTC (History)
0 users

See Also:


Attachments
file.diff (4.05 KB, patch)
2012-12-18 20:00 UTC, Dan McGregor
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan McGregor 2012-12-18 20:00:00 UTC
The pkg-plist for textproc/asciidoc is incorrectly specified, the files for @exec and @unexec statements are coming after the respective statement, not before.

This causes interesting things like asciidoc.conf.sample to be copied to /usr/local/bin. The net effect for me is that x11-wm/awesome doesn't build, and fails with this message:

[ 52%] Generating manpages/man1/awesome.1.xml
asciidoc: ERROR: [attributes] missing 'attributelist-pattern' entry
asciidoc: FAILED: unexpected error:
asciidoc: ------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/bin/asciidoc", line 5939, in asciidoc
    AttributeList.initialize()
  File "/usr/local/bin/asciidoc", line 1923, in initialize
    AttributeList.pattern = document.attributes['attributelist-pattern']
  File "/usr/local/bin/asciidoc", line 115, in __getitem__
    return dict.__getitem__(self, key.lower())
KeyError: 'attributelist-pattern'
*** [manpages/man1/awesome.1.xml] Error code 1

Fix: The attached patch worked for me.

Patch attached with submission follows:
How-To-Repeat: Use a recent portsnap, pkgng, and:

cd /usr/ports/textproc/asciidoc
make
make install

then try to use it, for example building awesome:

cd /usr/ports/x11-wm/awesome
make

Note: this does work on 10-CURRENT
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2012-12-19 22:48:44 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!