Bug 174904 - [patch] devel/p5-Return-Value backout last update
Summary: [patch] devel/p5-Return-Value backout last update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Anton Berezin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-02 18:10 UTC by Olli Hauer
Modified: 2013-01-03 09:30 UTC (History)
1 user (show)

See Also:


Attachments
diff (890 bytes, patch)
2013-01-02 18:10 UTC, Olli Hauer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer freebsd_committer freebsd_triage 2013-01-02 18:10:00 UTC
The last update for p5-Return-Value has no technical changes except to throw deprecated messages.
I suspect this was the reason why a link to the changelog was posted instead the two line change ...

> Release history for Return-Value
> 1.666002  2012-12-24
>          finally started issuing long-promised warnings
>          Merry Christmas!


Unfortunately p5-Return-Value is used by p5-Email-Send which is used by all bugzilla ports and a view others.
Within every whine/news/... bugzilla cronjob additional deprecated messages will be generated.

There is already a PR for bugzilla
https://bugzilla.mozilla.org/show_bug.cgi?id=502625

Please backout the last update.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-01-02 18:10:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->tobez

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-01-03 09:21:37 UTC
Author: tobez
Date: Thu Jan  3 09:21:29 2013
New Revision: 309859
URL: http://svnweb.freebsd.org/changeset/ports/309859

Log:
  Remove deprecation warning introduced with the last update.
  
  Unfortunately, this port is depended on by quite a few other ports,
  so we do not want the deprecation warning at this stage.
  
  Patch up the sources instead of a more drastic PORTEPOCH bump.
  
  PR:			174904
  Submitted by:	Olli Hauer

Modified:
  head/devel/p5-Return-Value/Makefile

Modified: head/devel/p5-Return-Value/Makefile
==============================================================================
--- head/devel/p5-Return-Value/Makefile	Thu Jan  3 09:08:10 2013	(r309858)
+++ head/devel/p5-Return-Value/Makefile	Thu Jan  3 09:21:29 2013	(r309859)
@@ -3,6 +3,7 @@
 
 PORTNAME=	Return-Value
 PORTVERSION=	1.666002
+PORTREVISION=	1
 CATEGORIES=	devel perl5
 MASTER_SITES=	CPAN
 MASTER_SITE_SUBDIR=	CPAN:RJBS
@@ -15,4 +16,7 @@ PERL_CONFIGURE=	yes
 
 MAN3=	Return::Value.3
 
+post-patch:
+	${PERL} -pi -e 's/^Carp::cluck/# Carp::cluck/' ${WRKSRC}/lib/Return/Value.pm
+
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Anton Berezin freebsd_committer freebsd_triage 2013-01-03 09:22:04 UTC
State Changed
From-To: open->closed

A somewhat different fix has been committed.  Thank you for your 
submission.