Bug 174952 - [patch] textproc/docproj fails to build
Summary: [patch] textproc/docproj fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Document Engineering Group (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-03 18:00 UTC by Mark Johnston
Modified: 2013-01-03 23:10 UTC (History)
0 users

See Also:

Attachments
file.diff (366 bytes, patch)
2013-01-03 18:00 UTC, Mark Johnston 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Johnston freebsd_committer freebsd_triage 2013-01-03 18:00:00 UTC 
The build failed for me with

===>  docproj-1.17_6 user must set WITH_JADETEX variable to 'yes' or 'no'.
*** [install] Error code 1

Stop in /usr/ports/textproc/docproj.

Fix: Use the attached patch.

Patch attached with submission follows:
How-To-Repeat: Build /usr/ports/textproc/docproj. I see there are textproc/docproj-{,no}jadetex ports as well, which set WITH_JADETEX appropriately.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2013-01-03 21:31:21 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

reassign.
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-01-03 21:31:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->doceng

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2013-01-03 22:53:09 UTC 
Did you try building as it is suggested?

make -DWITH_JADETEX
or
make -DWITHOUT_JADETEX

This should work, as designed. That being said, maybe the port can be
massaged to be more user friendly in the way of ports/packages with an
option, and pkgsuffix (ie. similiar to -nox11)

-jgh

--
Jason Helfman          | FreeBSD Committer
jgh@FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve


On Thu, Jan 3, 2013 at 1:31 PM, <edwin@freebsd.org> wrote:

> Synopsis: [patch] textproc/docproj fails to build
>
> Responsible-Changed-From-To: freebsd-ports-bugs->doceng
> Responsible-Changed-By: edwin
> Responsible-Changed-When: Thu Jan 3 21:31:37 UTC 2013
> Responsible-Changed-Why:
> Over to maintainer (via the GNATS Auto Assign Tool)
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=174952
> _______________________________________________
> freebsd-ports-bugs@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
> To unsubscribe, send any mail to "
> freebsd-ports-bugs-unsubscribe@freebsd.org"
>
Comment 4 Glen Barber freebsd_committer freebsd_triage 2013-01-03 22:58:23 UTC 
On Thu, Jan 03, 2013 at 02:53:09PM -0800, Jason Helfman wrote:
> Did you try building as it is suggested?
> 
> make -DWITH_JADETEX
> or
> make -DWITHOUT_JADETEX
> 
> This should work, as designed. That being said, maybe the port can be
> massaged to be more user friendly in the way of ports/packages with an
> option, and pkgsuffix (ie. similiar to -nox11)


-jadetex and -nojadetex PKGSUFFIXes already exist.

I agree with Mark that the default behavior is wrong, and am waiting for
feedback before committing the proposed change.

Glen
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-01-03 23:04:07 UTC 
Author: gjb
Date: Thu Jan  3 23:04:00 2013
New Revision: 309908
URL: http://svnweb.freebsd.org/changeset/ports/309908

Log:
  Unset WITH_JADETEX if not otherwise specified.
  
  PR:		ports/174952
  Submitted by:	markj
  Approved by:	doceng (implicit), eadler (mentor)

Modified:
  head/textproc/docproj/Makefile

Modified: head/textproc/docproj/Makefile
==============================================================================
--- head/textproc/docproj/Makefile	Thu Jan  3 21:59:30 2013	(r309907)
+++ head/textproc/docproj/Makefile	Thu Jan  3 23:04:00 2013	(r309908)
@@ -53,7 +53,7 @@ RUN_DEPENDS+=	jade:${PORTSDIR}/textproc/
 .if defined(JADETEX)
 WITH_JADETEX=	${JADETEX}
 .endif
-WITH_JADETEX?=
+WITH_JADETEX?=	no
 
 .if defined(PACKAGE_BUILDING)
 WITH_JADETEX=	yes
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Glen Barber freebsd_committer freebsd_triage 2013-01-03 23:04:13 UTC 
State Changed
From-To: open->closed

Committed, thanks!