Bug 175482 - mail/claws-mail shouldn't enable the crash dialog if the DEBUG option is used
Summary: mail/claws-mail shouldn't enable the crash dialog if the DEBUG option is used
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-21 17:00 UTC by Fabian Keil
Modified: 2013-01-24 16:07 UTC (History)
0 users

See Also:

Attachments
file.txt (769 bytes, text/plain)
2013-01-21 17:00 UTC, Fabian Keil 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2013-01-21 17:00:00 UTC 
In my experience claws-mail's crash dialog causes more problems than it solves.

The stack trace is usually bogus, can't be generated or claws-mail simply becomes unresponsive instead of properly creating a core dump that would actually be useful.

In case of claws-mail 3.9.0 "killall -SIGSEGV claws-mail" merely causes the
following console messages to appear:

claws.c:102:Starting Claws Mail version Claws Mail 3.9.0
main.c:2378:another Claws Mail instance is already running.

No dialog is shown and the GUI becomes unresponsive.

If http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2862
wasn't reproducible, I wouldn't have been able to figure out the problem (which happened in the past).

Even if the crash dialog would work, I'd prefer it to be a separate option instead of being set depending on the DEBUG option. My expectation when compiling ports with DEBUG is getting usable core dumps.

Fix: The attached patch removes the --enable-crash-dialog configure option which solves the problem for me.

Patch attached with submission follows:
How-To-Repeat: 1. Build the claws-mail port with "DEBUG" support
2. Crash claws-mail
3. Notice that there is no core dump to analyze
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-01-21 17:00:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pawel

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-01-24 15:51:47 UTC 
Author: pawel
Date: Thu Jan 24 15:51:35 2013
New Revision: 310935
URL: http://svnweb.freebsd.org/changeset/ports/310935

Log:
  Don't enable crash dialog when DEBUG=on - this prevents
  coredump file creation.
  
  PR:		ports/175482
  Submitted by:	Fabian Keil <fk@fabiankeil.de>

Modified:
  head/mail/claws-mail/Makefile

Modified: head/mail/claws-mail/Makefile
==============================================================================
--- head/mail/claws-mail/Makefile	Thu Jan 24 15:48:20 2013	(r310934)
+++ head/mail/claws-mail/Makefile	Thu Jan 24 15:51:35 2013	(r310935)
@@ -151,7 +151,7 @@ CONFIGURE_ARGS+=	--disable-pgpmime-plugi
 .endif
 
 .if ${PORT_OPTIONS:MDEBUG}
-CONFIGURE_ARGS+=	--enable-maintainer-mode --enable-crash-dialog
+CONFIGURE_ARGS+=	--enable-maintainer-mode
 .endif
 
 .if ${PORT_OPTIONS:MDILLO}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2013-01-24 16:06:59 UTC 
State Changed
From-To: open->closed

Committed. Thanks!