Bug 175744 - [MAINTAINER] sysutils/gigolo: [SUMMARIZE CHANGES]
Summary: [MAINTAINER] sysutils/gigolo: [SUMMARIZE CHANGES]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-31 21:00 UTC by nemysis
Modified: 2013-06-26 08:10 UTC (History)
0 users

See Also:


Attachments
gigolo-0.4.1_1.patch (3.18 KB, patch)
2013-01-31 21:00 UTC, nemysis
no flags Details | Diff
gigolo.diff (3.43 KB, patch)
2013-03-11 15:45 UTC, nemysis
no flags Details | Diff
gigolo.diff (4.11 KB, patch)
2013-06-01 12:43 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-01-31 21:00:00 UTC
Makefile changed:
+		http://www.uvena.de/gigolo/:icons <--- As for PC-BSD PBI added an icon
+DIST_SUBDIR=	${PORTNAME} <-- That all from this Ports are in same directory
+	${INSTALL_DATA} ${_DISTDIR}/network.png ${PREFIX}/share/pixmaps/${PORTNAME}.png

Changed and refined:
pkg-plist <-- added for Documentation, order is changed because i use mine script for pkg-plist

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
WARN: /usr/local/ports/local/commited/sysutils/gigolo/pkg-plist: [3]: If and only if your port is DOCSDIR-safe (that is, a user can override DOCSDIR when building this port and the port will still work correctly) consider using DOCSDIR macro; if you are unsure if this this port is DOCSDIR-safe, then ignore this warning
WARN: /usr/local/ports/local/commited/sysutils/gigolo/pkg-plist: [4]: If and only if your port is DOCSDIR-safe (that is, a user can override DOCSDIR when building this port and the port will still work correctly) consider using DOCSDIR macro; if you are unsure if this this port is DOCSDIR-safe, then ignore this warning
WARN: /usr/local/ports/local/commited/sysutils/gigolo/pkg-plist: [5]: If and only if your port is DOCSDIR-safe (that is, a user can override DOCSDIR when building this port and the port will still work correctly) consider using DOCSDIR macro; if you are unsure if this this port is DOCSDIR-safe, then ignore this warning
WARN: /usr/local/ports/local/commited/sysutils/gigolo/pkg-plist: [6]: If and only if your port is DOCSDIR-safe (that is, a user can override DOCSDIR when building this port and the port will still work correctly) consider using DOCSDIR macro; if you are unsure if this this port is DOCSDIR-safe, then ignore this warning
WARN: /usr/local/ports/local/commited/sysutils/gigolo/pkg-plist: [7]: If and only if your port is DOCSDIR-safe (that is, a user can override DOCSDIR when building this port and the port will still work correctly) consider using DOCSDIR macro; if you are unsure if this this port is DOCSDIR-safe, then ignore this warning
WARN: /usr/local/ports/local/commited/sysutils/gigolo/pkg-plist: [8]: If and only if your port is DOCSDIR-safe (that is, a user can override DOCSDIR when building this port and the port will still work correctly) consider using DOCSDIR macro; if you are unsure if this this port is DOCSDIR-safe, then ignore this warning
WARN: Makefile: use ".if !defined(NOPORTDOCS)" to wrap installation of files into /usr/local/share/doc.
WARN: Makefile: Consider adding support for a WITHOUT_NLS knob to conditionally disable gettext support.
WARN: Makefile: [40]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 11 warnings found.

WARN: /usr/local/ports/local/commited/sysutils/gigolo/pkg-plist: because is used
+share/doc/gigolo
waf install this one questions


Now not more Documentation leftover
port test: clean
Comment 1 Po-Chien Lin freebsd_committer freebsd_triage 2013-02-25 14:33:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pclin

I'll take it.
Comment 2 Jason Helfman freebsd_committer freebsd_triage 2013-02-26 00:17:51 UTC
This port requires additional enhancements that should be addressed.

Per: Olivier Duchateau <duchateau.olivier@gmail.com>


In past, I worked on this port, but I think it needs to be enhanced:

- It's right it depends of devel/gvfs, but FUSE needs to be installed,
otherwise Gigolo don't work (my latest test was 2 years ago).
- As it needs FUSE, this port works only on i386 and amd64 architectures.

You can see my work here,
http://code.google.com/p/olivier-freebsd-ports/source/browse/sysutils/gigolo

-jgh

--
Jason Helfman          | FreeBSD Committer
jgh@FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve
Comment 3 nemysis 2013-03-11 15:45:38 UTC
Thanks i have added and refined for devel/gvfs FUSE and fusefs-kmod

Documentation is better only in Makefile, removed from pkg-plist.

+.include <bsd.port.pre.mk>
+
+.if ! exists(${LOCALBASE}/libexec/gvfs-fuse-daemon)
+IGNORE=        Enable FUSE support in ${PORTSDIR}/devel/gvfs
+.endif
+
+# Only i386/amd64 due to limitations of fusefs-kmod
+.if ${ARCH} != "i386" && ${ARCH} != "amd64"
+BROKEN=        Does not compile on other than i386/amd64
+.endif

...
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
Comment 4 nemysis 2013-06-01 12:43:52 UTC
https://redports.org/buildarchive/20130528154400-52432/

ignored: enable fuse support in /usr/ports/devel/gvfs

- Bump portrevision
- Trim Makefile header
- Trim master sites
- Add Icons
- Fix docs
- Add OptionsNG
- Add test and warning if devel/gvfs not have FUSE support
- Add test and warning for i386/amd64
- Trim pkg-plist
Comment 5 Jason Helfman freebsd_committer freebsd_triage 2013-06-01 18:09:10 UTC
There are several issues with this patch that need addressing.
I can work with nemysis or submit my own follow-up for testing.

-jgh

--
Jason Helfman          | FreeBSD Committer
jgh@FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve
Comment 6 Po-Chien Lin freebsd_committer freebsd_triage 2013-06-02 02:47:10 UTC
Yes! Please feel free to work on it. :)

- pclin
Comment 7 dfilter service freebsd_committer freebsd_triage 2013-06-26 08:00:06 UTC
Author: jgh
Date: Wed Jun 26 06:59:57 2013
New Revision: 321783
URL: http://svnweb.freebsd.org/changeset/ports/321783

Log:
  - Trim historical header, master sites and pkg-plist
  - Add Icons
  - Fix docs and nls
  - Bump portrevision
  
  PR:		175744 (based on)
  Submitted by:	nemysis@gmx.ch (maintainer)

Modified:
  head/sysutils/gigolo/Makefile
  head/sysutils/gigolo/distinfo
  head/sysutils/gigolo/pkg-plist

Modified: head/sysutils/gigolo/Makefile
==============================================================================
--- head/sysutils/gigolo/Makefile	Wed Jun 26 04:35:10 2013	(r321782)
+++ head/sysutils/gigolo/Makefile	Wed Jun 26 06:59:57 2013	(r321783)
@@ -1,10 +1,16 @@
-# Created by: nemysis@gmx.ch
+# Created by: nemysis <nemysis@gmx.ch>
 # $FreeBSD$
 
 PORTNAME=	gigolo
 PORTVERSION=	0.4.1
+PORTREVISION=	1
 CATEGORIES=	sysutils
-MASTER_SITES=	http://files.uvena.de/gigolo/
+MASTER_SITES=	http://files.uvena.de/gigolo/ \
+		http://www.uvena.de/gigolo/:icons
+DISTFILES=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX} \
+		network.png:icons
+DIST_SUBDIR=	${PORTNAME}
+EXTRACT_ONLY=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX}
 
 MAINTAINER=	nemysis@gmx.ch
 COMMENT=	Frontend to easily manage filesystem connections
@@ -15,22 +21,49 @@ BUILD_DEPENDS=	p5-XML-Parser>=0:${PORTSD
 LIB_DEPENDS=	cairo:${PORTSDIR}/graphics/cairo
 
 USE_BZIP2=	yes
+USES=		fuse
 USE_GNOME=	gtk20 gvfs
 USE_XORG=	x11
 USE_PYTHON=	yes
-USES=		gettext
 
 MAN1=		gigolo.1
 
-PORTDOCS=	AUTHORS ChangeLog NEWS README TODO COPYING
+PORTDOCS=	AUTHORS ChangeLog NEWS README TODO
+
+OPTIONS_DEFINE=	DOCS NLS
+OPTIONS_SUB=	yes
+
+NLS_USES=	gettext
+
+ONLY_FOR_ARCHS=	i386 amd64
+ONLY_FOR_ARCHS_REASON=	Does not compile
+
+.include <bsd.port.options.mk>
+
+post-patch:
+	@${REINPLACE_CMD} -e 's|COPYING ||' ${WRKSRC}/wscript
+
+.if ! ${PORT_OPTIONS:MDOCS}
+	${REINPLACE_CMD} -e 's|bld.install_files|#bld.install_files|' ${WRKSRC}/wscript
+.endif
+
+.if ! ${PORT_OPTIONS:MNLS}
+	${REINPLACE_CMD} -e "s|= 'po'|= ''|" ${WRKSRC}/wscript
+.endif
 
 do-configure:
-	@cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ./waf configure --mandir=${PREFIX}/man
+	@cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ./waf configure --mandir=${MANPREFIX}/man
 
 do-build:
 	@cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ./waf build
 
 do-install:
 	@cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ./waf install
+	${INSTALL_DATA} ${_DISTDIR}/network.png ${PREFIX}/share/pixmaps/${PORTNAME}.png
+
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
 
 .include <bsd.port.mk>

Modified: head/sysutils/gigolo/distinfo
==============================================================================
--- head/sysutils/gigolo/distinfo	Wed Jun 26 04:35:10 2013	(r321782)
+++ head/sysutils/gigolo/distinfo	Wed Jun 26 06:59:57 2013	(r321783)
@@ -1,2 +1,4 @@
-SHA256 (gigolo-0.4.1.tar.bz2) = 82f3b5f0ce3ff19c1facac1c89117d67bdf1d4fac66e42fb7a98a8b0d74a17f9
-SIZE (gigolo-0.4.1.tar.bz2) = 194112
+SHA256 (gigolo/gigolo-0.4.1.tar.bz2) = 82f3b5f0ce3ff19c1facac1c89117d67bdf1d4fac66e42fb7a98a8b0d74a17f9
+SIZE (gigolo/gigolo-0.4.1.tar.bz2) = 194112
+SHA256 (gigolo/network.png) = c2307b0ac5b091fefd8d09fa83eae9bae236096d84de31c49a455bfc583807c6
+SIZE (gigolo/network.png) = 5689

Modified: head/sysutils/gigolo/pkg-plist
==============================================================================
--- head/sysutils/gigolo/pkg-plist	Wed Jun 26 04:35:10 2013	(r321782)
+++ head/sysutils/gigolo/pkg-plist	Wed Jun 26 06:59:57 2013	(r321783)
@@ -1,44 +1,46 @@
 bin/gigolo
 share/applications/gigolo.desktop
-share/locale/bg/LC_MESSAGES/gigolo.mo
-share/locale/ca/LC_MESSAGES/gigolo.mo
-share/locale/cs/LC_MESSAGES/gigolo.mo
-share/locale/da/LC_MESSAGES/gigolo.mo
-share/locale/de/LC_MESSAGES/gigolo.mo
-share/locale/el/LC_MESSAGES/gigolo.mo
-share/locale/es/LC_MESSAGES/gigolo.mo
-share/locale/eu/LC_MESSAGES/gigolo.mo
-share/locale/fi/LC_MESSAGES/gigolo.mo
-share/locale/fr/LC_MESSAGES/gigolo.mo
-share/locale/gl/LC_MESSAGES/gigolo.mo
-share/locale/hr/LC_MESSAGES/gigolo.mo
-share/locale/hu/LC_MESSAGES/gigolo.mo
-share/locale/id/LC_MESSAGES/gigolo.mo
-share/locale/it/LC_MESSAGES/gigolo.mo
-share/locale/ja/LC_MESSAGES/gigolo.mo
-share/locale/lv/LC_MESSAGES/gigolo.mo
-share/locale/nl/LC_MESSAGES/gigolo.mo
-share/locale/pl/LC_MESSAGES/gigolo.mo
-share/locale/pt/LC_MESSAGES/gigolo.mo
-share/locale/pt_BR/LC_MESSAGES/gigolo.mo
-share/locale/ru/LC_MESSAGES/gigolo.mo
-share/locale/sk/LC_MESSAGES/gigolo.mo
-share/locale/sv/LC_MESSAGES/gigolo.mo
-share/locale/tr/LC_MESSAGES/gigolo.mo
-share/locale/uk/LC_MESSAGES/gigolo.mo
-share/locale/zh_CN/LC_MESSAGES/gigolo.mo
-share/locale/ast/LC_MESSAGES/gigolo.mo
-share/locale/kk/LC_MESSAGES/gigolo.mo
-share/locale/ug/LC_MESSAGES/gigolo.mo
-share/locale/ur/LC_MESSAGES/gigolo.mo
-share/locale/ur_PK/LC_MESSAGES/gigolo.mo
-@dirrmtry share/locale/ur_PK/LC_MESSAGES
-@dirrmtry share/locale/ur_PK
-@dirrmtry share/locale/ur
-@dirrmtry share/locale/ug/LC_MESSAGES
-@dirrmtry share/locale/ug
-@dirrmtry share/locale/kk/LC_MESSAGES
-@dirrmtry share/locale/kk
-@dirrmtry share/locale/ast/LC_MESSAGES
-@dirrmtry share/locale/ast
+%%NLS%%share/locale/ast/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/bg/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/ca/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/cs/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/da/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/de/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/el/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/es/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/eu/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/fi/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/fr/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/gl/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/hr/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/hu/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/id/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/it/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/ja/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/kk/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/lv/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/nl/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/pl/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/pt/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/pt_BR/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/ru/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/sk/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/sv/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/tr/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/ug/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/uk/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/ur/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/ur_PK/LC_MESSAGES/gigolo.mo
+%%NLS%%share/locale/zh_CN/LC_MESSAGES/gigolo.mo
+share/pixmaps/gigolo.png
+%%NLS%%@dirrmtry share/locale/ur_PK/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/ur_PK
+%%NLS%%@dirrmtry share/locale/ur/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/ur
+%%NLS%%@dirrmtry share/locale/ug/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/ug
+%%NLS%%@dirrmtry share/locale/kk/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/kk
+%%NLS%%@dirrmtry share/locale/ast/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/ast
 @dirrmtry share/applications
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 8 Jason Helfman freebsd_committer freebsd_triage 2013-06-26 08:00:45 UTC
State Changed
From-To: open->closed

Commmitted, with minor changes. Thanks. 


Comment 9 Jason Helfman freebsd_committer freebsd_triage 2013-06-26 08:00:45 UTC
Responsible Changed
From-To: pclin->jgh

Commmitted, with minor changes. Thanks.