Makefile changed: +LICENSE= GPLv2 +SUB_FILES= +DESKTOP_ENTRIES= +.include <bsd.port.options.mk> Changed and refined: post-install: pkg-plist - Take maintainership Added file(s): - files/pkg-install.in - files/pkg-message.in Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports) How-To-Repeat: portlint -A WARN: Makefile: [26]: possible direct use of command "false" found. use ${FALSE} instead. WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. WARN: Makefile: new ports should not set PORTREVISION. 0 fatal errors and 3 warnings found. WARN: Makefile: [26]: because is used + "${PORTNAME}" "Settings;" false port test: clean
Added that user can store menu.xml chmod chmod 644 ~/.config/openbox/menu.xml
State Changed From-To: open->feedback your pkg-install script is wrong. you cant just simply symlink in a home dir. You need to respect existing configs. please review the handbook for that.
> your pkg-install script is wrong. you cant just simply symlink in a home > dir. You need to respect existing configs. please review the handbook > for that. Thanks i have reread http://www.freebsd.org/doc/en/books/porters-handbook/pkg-files.html But i don't symlink in pkg-install files/pkg-install.in ls -lh /home/*/.config/openbox | grep menu.xml this is only a Proposal from files/pkg-message.in cp -a %%LOCALBASE%%/etc/xdg/openbox/menu.xml ~/.config/openbox/menu.xml chmod chmod 644 ~/.config/openbox/menu.xml
I do not understand the purpose of the pkg-install, it seems useless, it is checking things that might has a very high chance to fail. I can have my home directories anywhere in the filesystem or even outside if I use to automount things. The pkg-message.in is wrong "chmod chmod..." Why a buggy -a on the cp line simply copy a file? Please review the wording of you pkg-message, the sentence are in very badly understandable english, ask some native to review it for example (that is usually what I do) regards, Bapt
- Bump portrevision - Add license - Add Desktop entry file - Convert to OptionsNG - Trim pkg-plist Added file(s): - files/pkg-install.in - files/pkg-message.in
Responsible Changed From-To: freebsd-ports-bugs->nemysis submitter is now committer.
State Changed From-To: feedback->open Submitter has fixed.
State Changed From-To: open->closed Committed. Thanks!
Author: nemysis Date: Sat Oct 19 17:00:05 2013 New Revision: 330913 URL: http://svnweb.freebsd.org/changeset/ports/330913 Log: - Change Makefile header - Bump PORTREVISION - Pass maintainership to submitter - Add license (GPLv2) - Support STAGEDIR - Add Desktop entry file and pkg-message PR: ports/175944 Submitted by: nemysis (self) Approved by: pawel (mentor) Added: head/x11-wm/obmenu/files/ head/x11-wm/obmenu/files/pkg-message.in (contents, props changed) Modified: head/x11-wm/obmenu/Makefile (contents, props changed) head/x11-wm/obmenu/pkg-plist (contents, props changed) Modified: head/x11-wm/obmenu/Makefile ============================================================================== --- head/x11-wm/obmenu/Makefile Sat Oct 19 16:58:27 2013 (r330912) +++ head/x11-wm/obmenu/Makefile Sat Oct 19 17:00:05 2013 (r330913) @@ -1,14 +1,17 @@ +# Created by: Doug Barton <dougb@FreeBSD.org> # $FreeBSD$ PORTNAME= obmenu PORTVERSION= 1.0 -PORTREVISION= 5 +PORTREVISION= 6 CATEGORIES= x11-wm MASTER_SITES= SF -MAINTAINER= ports@FreeBSD.org +MAINTAINER= nemysis@FreeBSD.org COMMENT= Menu manager for Openbox supporting both static and pipe menus +LICENSE= GPLv2 + USE_GNOME= pygtk2 USE_PYTHON= yes USE_PYDISTUTILS= yes @@ -16,13 +19,18 @@ PYDISTUTILS_PKGNAME= obMenu PORTDOCS= README -NO_STAGE= yes +SUB_FILES= pkg-message + +DESKTOP_ENTRIES="Obmenu" "Menu manager for Openbox" ${PORTNAME} \ + "${PORTNAME}" "Settings;" false + +.include <bsd.port.options.mk> + post-install: -.if !defined(NOPORTDOCS) - @${MKDIR} ${DOCSDIR} -.for file in ${PORTDOCS} - ${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR} -.endfor +.if ${PORT_OPTIONS:MDOCS} + @${MKDIR} ${STAGEDIR}${DOCSDIR} + ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR} .endif + ${LN} -sf ${DATADIR}/mnu48.png ${STAGEDIR}${PREFIX}/share/pixmaps/${PORTNAME}.png .include <bsd.port.mk> Added: head/x11-wm/obmenu/files/pkg-message.in ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/x11-wm/obmenu/files/pkg-message.in Sat Oct 19 17:00:05 2013 (r330913) @@ -0,0 +1,19 @@ +=============================================================================== + +Obmenu has been installed. + +If you don't have ~/.config/openbox/menu.xml + +the Obmenu config can be copied, please type as user: + + su user + + cp %%LOCALBASE%%/etc/xdg/openbox/menu.xml ~/.config/openbox/menu.xml + + chmod 644 ~/.config/openbox/menu.xml + + exit + +Have fun! + +=============================================================================== Modified: head/x11-wm/obmenu/pkg-plist ============================================================================== --- head/x11-wm/obmenu/pkg-plist Sat Oct 19 16:58:27 2013 (r330912) +++ head/x11-wm/obmenu/pkg-plist Sat Oct 19 17:00:05 2013 (r330913) @@ -9,6 +9,5 @@ bin/obmenu %%DATADIR%%/mnu16.png %%DATADIR%%/mnu48.png %%DATADIR%%/obmenu.glade +share/pixmaps/obmenu.png @dirrm %%DATADIR%% -@dirrmtry %%PYTHON_SITELIBDIR%% -@dirrmtry %%PYTHON_LIBDIR%% _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"