Multiple instances of iaxmodem are being spawned due to a badly placed closedir call. The fix has been submitted (and accepted) upstream, however there has been no new release since the fix was submitted. I've been running *my* patched version since November 2011 without a hickhup. http://sourceforge.net/tracker/?func=detail&aid=3438845&group_id=148814&atid=772727 Fix: Patch iaxmodem.c using the following patch Patch attached with submission follows: How-To-Repeat: Running an iaxmodem device will cause multiple instances of iaxmodem to spawn.
Maintainer of net/iaxmodem, Please note that PR ports/176178 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/176178 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Author: rakuco Date: Sat May 18 23:09:58 2013 New Revision: 318465 URL: http://svnweb.freebsd.org/changeset/ports/318465 Log: Implement upstream fix where multiple net/iaxmodem instances are spawned. Multiple instances of iaxmodem are being spawned due to a badly placed closedir call. The fix has been submitted (and accepted) upstream, however there has been no new release since the fix was submitted. PR: ports/176178 Submitted by: John Bayly <freebsd.ports@tipstrade.net> Approved by: maintainer timeout (93 days) Modified: head/net/iaxmodem/Makefile head/net/iaxmodem/files/patch-iaxmodem.c Modified: head/net/iaxmodem/Makefile ============================================================================== --- head/net/iaxmodem/Makefile Sat May 18 22:54:31 2013 (r318464) +++ head/net/iaxmodem/Makefile Sat May 18 23:09:58 2013 (r318465) @@ -1,13 +1,9 @@ -# New ports collection makefile for: iaxmodem -# Date created: 15 Jun 2006 -# Whom: Filippo Natali <filippo.natali@gmail.com> -# +# Created by: Filippo Natali <filippo.natali@gmail.com> # $FreeBSD$ -# PORTNAME= iaxmodem PORTVERSION= 1.2.0 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= net comms MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/${PORTNAME}-${PORTVERSION} Modified: head/net/iaxmodem/files/patch-iaxmodem.c ============================================================================== --- head/net/iaxmodem/files/patch-iaxmodem.c Sat May 18 22:54:31 2013 (r318464) +++ head/net/iaxmodem/files/patch-iaxmodem.c Sat May 18 23:09:58 2013 (r318465) @@ -49,3 +49,20 @@ #include <tiffio.h> #ifndef O_LARGEFILE +@@ -1645,8 +1666,6 @@ + } + } + +- closedir(cfdir); +- + if (pid == 0) { + /* Start the modem */ + iaxmodem(config, 0); +@@ -1654,6 +1673,8 @@ + return 1; + } + ++ closedir(cfdir); ++ + return 0; + } _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks. Next time please provide a proper patch against the ports tree (in this case, for example, files/patch-iaxmodem.c already exists), and since a patch like that has been changed PORTREVISION also needs to be bumped.