Bug 176267 - [patch] security/p5-Digest-SHA-PurePerl remove perl 5.10- support, various improvements
Summary: [patch] security/p5-Digest-SHA-PurePerl remove perl 5.10- support, various im...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-19 15:40 UTC by Alex Kozlov
Modified: 2013-03-09 21:30 UTC (History)
0 users

See Also:


Attachments
file.diff (1.55 KB, patch)
2013-02-19 15:40 UTC, Alex Kozlov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Kozlov 2013-02-19 15:40:00 UTC
- Remove perl 5.10- support (also fixes 'Use of SITE_PERL in dependencies' item from https://wiki.freebsd.org/PortsLongtermTargets)
- Convert to OptionsNG
- Use PORTEXAMPLES
- Convert Makefile headers to new style

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-02-19 17:21:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ashish

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2013-02-25 11:34:06 UTC
Hi Alex,

Thanks for the diff. I didn't get time to look at the diff last weekend, but
I'll get to it by this coming weekend.

-- 
Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
Sent from my Emacs
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-03-09 21:23:01 UTC
Author: ashish
Date: Sat Mar  9 21:22:52 2013
New Revision: 313756
URL: http://svnweb.freebsd.org/changeset/ports/313756

Log:
  - Remove support for Perl < 5.12
  - Convert to OptionsNG
  - Use PORTEXAMPLES
  - Convert Makefile headers to new style
  
  PR:		ports/176267
  Submitted by:	Alex Kozlov <spam at rm-rf.kiev.ua>

Modified:
  head/security/p5-Digest-SHA-PurePerl/Makefile
  head/security/p5-Digest-SHA-PurePerl/pkg-plist

Modified: head/security/p5-Digest-SHA-PurePerl/Makefile
==============================================================================
--- head/security/p5-Digest-SHA-PurePerl/Makefile	Sat Mar  9 21:02:26 2013	(r313755)
+++ head/security/p5-Digest-SHA-PurePerl/Makefile	Sat Mar  9 21:22:52 2013	(r313756)
@@ -1,6 +1,4 @@
-# Ports collection Makefile for:	p5-Digest-SHA-PurePerl
-# Date created:				21 Dec, 2005
-# Whom:					Gabor Kovesdan
+# Created by: Gabor Kovesdan <gabor@FreeBSD.org>
 # $FreeBSD$
 
 PORTNAME=	Digest-SHA-PurePerl
@@ -14,30 +12,19 @@ COMMENT=	Perl extension for SHA-1/224/25
 
 PERL_CONFIGURE=	yes
 
-MAN3=		Digest::SHA::PurePerl.3
+PORTEXAMPLES=	dups
+MAN3=	Digest::SHA::PurePerl.3
 
-.include <bsd.port.pre.mk>
-
-.if ${PERL_LEVEL} < 500803
-RUN_DEPENDS+=	${SITE_PERL}/Digest/base.pm:${PORTSDIR}/security/p5-Digest
-.endif
-
-.if ${PERL_LEVEL} >= 501000
-PLIST_SUB+=	EXE_FILES="@comment "
-.else
-PLIST_SUB+=	EXE_FILES=""
-MAN1=		shasum.1
-.endif
+.include <bsd.port.options.mk>
 
 post-patch:
-.if ${PERL_LEVEL} >= 501000
 	@${REINPLACE_CMD} -e '/EXE_FILES/d' ${WRKSRC}/Makefile.PL
-.endif
 
-.if !defined(NOPORTEXAMPLES)
+.if ${PORT_OPTIONS:MEXAMPLES}
 post-install:
 	@${MKDIR} ${EXAMPLESDIR}
-	@${INSTALL_DATA} ${WRKSRC}/examples/dups ${EXAMPLESDIR}
+	@${INSTALL_DATA} ${PORTEXAMPLES:S,^,${WRKSRC}/examples/,} ${EXAMPLESDIR}
+
 .endif
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

Modified: head/security/p5-Digest-SHA-PurePerl/pkg-plist
==============================================================================
--- head/security/p5-Digest-SHA-PurePerl/pkg-plist	Sat Mar  9 21:02:26 2013	(r313755)
+++ head/security/p5-Digest-SHA-PurePerl/pkg-plist	Sat Mar  9 21:22:52 2013	(r313756)
@@ -1,4 +1,3 @@
-%%EXE_FILES%%bin/shasum
 %%SITE_PERL%%/Digest/SHA/PurePerl.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Digest/SHA/PurePerl/.packlist
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Digest/SHA/PurePerl/
@@ -6,5 +5,3 @@
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Digest/
 @dirrmtry %%SITE_PERL%%/Digest/SHA/
 @dirrmtry %%SITE_PERL%%/Digest/
-%%PORTEXAMPLES%%%%EXAMPLESDIR%%/dups
-%%PORTEXAMPLES%%@dirrm %%EXAMPLESDIR%%
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2013-03-09 21:25:20 UTC
State Changed
From-To: open->closed

Committed. Thanks!