Bug 176336 - www/mysar: Fix paths to php, fix build with clang
Summary: www/mysar: Fix paths to php, fix build with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Edwin Groothuis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-21 22:20 UTC by Guido Falsi
Modified: 2013-03-24 14:30 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (1.02 KB, patch)
2013-02-21 22:20 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2013-02-21 22:20:01 UTC
- Fixed REINPLACE expressions to put correct path to php executable
  in scripts
- Remove deprecated mktime() usages from php files
- Fix build with clang by using USE_CSTD=gnu89
- While here I trimmed the Makefile headers
- Also removed a no more needed REINPLACE expression
- Bumped PORTREVISION
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-02-21 22:20:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->edwin

edwin@mavetju.org => edwin@ (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-02-21 22:20:17 UTC
Maintainer of www/mysar,

Please note that PR ports/176336 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/176336

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-02-21 22:20:18 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2013-03-24 14:19:57 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-03-24 14:19:57 UTC
Author: madpilot
Date: Sun Mar 24 14:19:44 2013
New Revision: 315122
URL: http://svnweb.freebsd.org/changeset/ports/315122

Log:
  - Fix REINPLACE expressions to put correct path to php executable
    in scripts
  - Remove deprecated mktime() usages from php files
  - Fix build with clang by using USE_CSTD=gnu89
  - While here I trim Makefile headers
  - Also remove a REINPLACE expression which is not needed anymore
  - Bumped PORTREVISION
  
  PR:		ports/176336
  Submitted by:	Myself
  Approved by:	Maintainer timeout (30 days)

Modified:
  head/www/mysar/Makefile   (contents, props changed)

Modified: head/www/mysar/Makefile
==============================================================================
--- head/www/mysar/Makefile	Sun Mar 24 14:19:01 2013	(r315121)
+++ head/www/mysar/Makefile	Sun Mar 24 14:19:44 2013	(r315122)
@@ -1,14 +1,9 @@
-#
-# ports collection makefile for:	mysar
-# Whom:					Edwin Groothuis <edwin@mavetju.org>
-# Date created:				2006-01-10
-#
+# Created by: Edwin Groothuis <edwin@mavetju.org>
 # $FreeBSD$
-#
 
 PORTNAME=	mySAR
 PORTVERSION=	2.1.4
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	www
 MASTER_SITES=	SF
 DISTNAME=	${PORTNAME:L}-${PORTVERSION}
@@ -23,6 +18,7 @@ WRKSRC=		${WRKROOT}/bin/mysar-binary-imp
 GNU_CONFIGURE=	yes
 USE_MYSQL=	yes
 USE_PHP=	mysql pcre
+USE_CSTD=	gnu89
 
 CONFIGURE_ARGS=	--with-mysql-lib=${LOCALBASE}
 
@@ -46,10 +42,8 @@ post-patch:
 		${WRKROOT}/etc/mysar.apache
 
 	${REINPLACE_CMD} \
-		-e 's,%%MYSARDIR%%,${MYSARDIR},g' \
-		`find ${WRKROOT}/etc -type f`
-	${REINPLACE_CMD} \
-		-e 's,%%PHP%%,${LOCALBASE}/bin/php,g' \
+		-e 's,/usr/bin/php,${LOCALBASE}/bin/php,g' \
+		-e 's,\([=,. ]\)mktime(),\1time(),g' \
 		`find ${WRKROOT}/bin -type f`
 	${REINPLACE_CMD} \
 		-e 's,/bin/sh,${LOCALBASE}/bin/bash,g' \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"