Bug 176386 - [patch] graphics/netpbm: manweb doesn't work
Summary: [patch] graphics/netpbm: manweb doesn't work
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-24 03:10 UTC by Lawrence Chen
Modified: 2013-02-25 19:05 UTC (History)
1 user (show)

See Also:

Attachments
patch.txt (1.74 KB, text/plain)
2013-02-24 03:10 UTC, Lawrence Chen 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Chen 2013-02-24 03:10:00 UTC 
	manweb doesn't work, can't find /etc/manweb.conf

Fix: - Change manweb to look for config at ${PREFIX}/etc/manweb.conf
        - Provide manweb.conf as buildtools/installnetpbm.pl would create
        - Provide netpbm.url/doc.url as GNUmakefile install.manweb would create

	The patch provides just the basic from the missing install steps,
	though adding 'browser=/usr/local/bin/lynx' to manweb.conf is helpful.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-02-24 03:10:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-02-25 18:50:01 UTC 
Author: dinoex
Date: Mon Feb 25 18:49:48 2013
New Revision: 312938
URL: http://svnweb.freebsd.org/changeset/ports/312938

Log:
  - drop manweb
  PR:		176386

Modified:
  head/graphics/netpbm/Makefile
  head/graphics/netpbm/pkg-plist   (contents, props changed)

Modified: head/graphics/netpbm/Makefile
==============================================================================
--- head/graphics/netpbm/Makefile	Mon Feb 25 18:30:16 2013	(r312937)
+++ head/graphics/netpbm/Makefile	Mon Feb 25 18:49:48 2013	(r312938)
@@ -3,6 +3,7 @@
 
 PORTNAME=	netpbm
 PORTVERSION=	10.35.88
+PORTREVISION=	1
 CATEGORIES=	graphics
 MASTER_SITES=	SF/netpbm/super_stable/${PORTVERSION}
 EXTRACT_SUFX=	.tgz
@@ -43,8 +44,9 @@ PLIST_SUB+=	X11='@comment '
 
 pre-configure:
 	@${REINPLACE_CMD} -e 's|%%PREFIX%%|${PREFIX}|g' \
-		 -e 's|%%LOCALBASE%%|${LOCALBASE}|g' \
-		 ${WRKSRC}/pm_config.in.h
+		-e 's|%%LOCALBASE%%|${LOCALBASE}|g' \
+		${WRKSRC}/pm_config.in.h
+	@${REINPLACE_CMD} -e 's|^SCRIPTS =.*|SCRIPTS =|' ${WRKSRC}/GNUmakefile
 	@${REINPLACE_CMD} -e 's|<shhopt.h>|<pm_shhopt.h>|g' ${WRKSRC}/lib/pm.h
 	@${REINPLACE_CMD} -e 's| jpeg2000||g' \
 		${WRKSRC}/converter/other/Makefile

Modified: head/graphics/netpbm/pkg-plist
==============================================================================
--- head/graphics/netpbm/pkg-plist	Mon Feb 25 18:30:16 2013	(r312937)
+++ head/graphics/netpbm/pkg-plist	Mon Feb 25 18:49:48 2013	(r312938)
@@ -31,7 +31,6 @@ bin/jpegtopnm
 bin/leaftoppm
 bin/lispmtopgm
 bin/macptopbm
-bin/manweb
 bin/mdatopbm
 bin/mgrtopbm
 bin/mrftopbm
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2013-02-25 19:01:13 UTC 
State Changed
From-To: open->closed

1. the tool should be patched to use PREFIX 
2. the file in etc should be preserved if a user modify it 
3. /usr/local/man/web violates fiesystem standard 
4. /usr/local/bin is no place for data files like doc.url 

because of the issues i have removed that tool from the port.