Bug 176795 - [PATCH] java/jakarta-commons-httpclient 3.1_1 fails to build
Summary: [PATCH] java/jakarta-commons-httpclient 3.1_1 fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alex Dupre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-09 22:20 UTC by Eric Kraußer
Modified: 2013-03-12 10:40 UTC (History)
0 users

See Also:


Attachments
file.diff (624 bytes, patch)
2013-03-09 22:20 UTC, Eric Kraußer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Kraußer 2013-03-09 22:20:00 UTC
jakarta-commons-httpclient fails to build because of non-UTF8 symbol,
see PR ports/165774


error message:
compile:
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/build.xml:184: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
    [javac] Compiling 139 source files to /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/target/classes
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/HttpContentTooLargeException.java:6: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl?ck
    [javac]                     ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/WireLogInputStream.java:40: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                     ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/WireLogInputStream.java:40: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                      ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/WireLogInputStream.java:40: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                       ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/auth/HttpAuthenticator.java:65: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                     ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/auth/HttpAuthenticator.java:65: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                      ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/auth/HttpAuthenticator.java:65: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                       ^
    [javac] 7 errors

BUILD FAILED
/usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/build.xml:184: Compile failed; see the compiler error output for details.

Fix: please apply the attached patch, it does reverse the change from revision 312555 to 312556

Patch attached with submission follows:
How-To-Repeat: try to build the port in a clean jail
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-09 22:20:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Alex Dupre freebsd_committer freebsd_triage 2013-03-12 10:39:39 UTC
State Changed
From-To: open->closed

Committed, thanks.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-03-12 10:39:43 UTC
Author: ale
Date: Tue Mar 12 10:39:30 2013
New Revision: 313961
URL: http://svnweb.freebsd.org/changeset/ports/313961

Log:
  Revert last commits and restore previous working fix [1].
  Switch to OptionsNG.
  
  PR:		ports/176795 [1]
  Submitted by:	Eric Krausser <eric@krausser-edv.de>

Modified:
  head/java/jakarta-commons-httpclient/Makefile

Modified: head/java/jakarta-commons-httpclient/Makefile
==============================================================================
--- head/java/jakarta-commons-httpclient/Makefile	Tue Mar 12 10:35:16 2013	(r313960)
+++ head/java/jakarta-commons-httpclient/Makefile	Tue Mar 12 10:39:30 2013	(r313961)
@@ -23,7 +23,7 @@ RUN_DEPENDS+=	${JAVAJARDIR}/commons-code
 USE_JAVA=	yes
 JAVA_VERSION=	1.6+
 USE_ANT=	yes
-MAKE_ENV=	ANT_INCLUDE_SHARED_JARS=YES LANG=C LC_ALL=C
+MAKE_ENV=	ANT_INCLUDE_SHARED_JARS=YES
 
 WRKSRC=		${WRKDIR}/${PORTNAME}-${DISTVERSION}
 ALL_TARGET=	dist
@@ -32,11 +32,18 @@ PLIST_FILES=	%%JAVAJARDIR%%/${PORTNAME}.
 
 PORTDOCS=	*
 
+.include <bsd.port.options.mk>
+
+post-patch:
+	@LANG=C ${REINPLACE_CMD} 's/Ortwin Gl.*ck/Ortwin Glueck/' \
+		${WRKSRC}/src/java/org/apache/commons/httpclient/*.java \
+		${WRKSRC}/src/java/org/apache/commons/httpclient/*/*.java
+
 do-install:
 	@${ECHO_MSG} -n ">> Installing JAR file as ${JAVAJARDIR}/${PORTNAME}.jar..."
 	@${INSTALL_DATA} ${WRKSRC}/dist/${PORTNAME}.jar ${JAVAJARDIR}/
 	@${ECHO_MSG} " [DONE]"
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	@${ECHO_MSG} -n ">> Installing documentation..."
 	@${MKDIR} ${DOCSDIR}
 	@cd ${WRKSRC}/dist/docs && ${FIND} api \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"