Bug 176890 - [maintainer-update] fix graphics/gimpfx-foundry dependency
Summary: [maintainer-update] fix graphics/gimpfx-foundry dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 19:40 UTC by Christoph Moench-Tegeder
Modified: 2013-03-17 23:30 UTC (History)
0 users

See Also:


Attachments
file.diff (784 bytes, patch)
2013-03-12 19:40 UTC, Christoph Moench-Tegeder
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Moench-Tegeder freebsd_committer freebsd_triage 2013-03-12 19:40:00 UTC
THe gimpfx-foundry port depends on gimp 2.6, which was recently updated
to version 2.8, breaking the dependency.

Fix: Until a gimp-2.8-reworked gimpfx-foundry is released, I'll just fix the
dependency (and while here, I'm doing some cleanup in the Makefile header).
Comment 1 Bryan Drewery freebsd_committer freebsd_triage 2013-03-13 16:20:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bdrewery

I'll take it.
Comment 2 Bryan Drewery freebsd_committer freebsd_triage 2013-03-13 16:23:03 UTC
Perhaps removing the specific version and depending on the pkgname would
be best. Something like:

RUN_DEPENDS= gimp-app>=0:${PORTSDIR}/graphics/gimp-app

Then this will not be a problem again.

-COMMENT=    A collection of scripts for The Gimp 2.6
+COMMENT=      A collection of scripts for The Gimp

The direction in ports has been to remove 'A' from COMMENTS: "Collection
of scripts for The Gimp"


-- 
Regards,
Bryan Drewery
bdrewery@freenode/EFNet

Comment 3 Bryan Drewery freebsd_committer freebsd_triage 2013-03-13 16:24:48 UTC
State Changed
From-To: open->feedback
Comment 4 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2013-03-17 17:33:15 UTC
Hi, thanks for your comments.

## Bryan Drewery (bdrewery@FreeBSD.org):

> Perhaps removing the specific version and depending on the pkgname would
> be best. Something like:
> 
> RUN_DEPENDS= gimp-app>=0:${PORTSDIR}/graphics/gimp-app
> 
> Then this will not be a problem again.


I'd rather have the version in the dependency, as some of the plugins
use rather internal interfaces of The Gimp which may change on a new
version (as I understand it, it's rather a lucky accident that the "old"
plugins work with the new Gimp).

> -COMMENT=    A collection of scripts for The Gimp 2.6
> +COMMENT=      A collection of scripts for The Gimp
> 
> The direction in ports has been to remove 'A' from COMMENTS: "Collection
> of scripts for The Gimp"

OK, that's fixed in the new diff.


Index: Makefile
===================================================================
--- Makefile	(revision 314471)
+++ Makefile	(working copy)
@@ -1,7 +1,4 @@
-# New ports collection makefile for:   gimpfx-foundry
-# Date created:        7 February 2008
-# Whom:                Christoph Moench-Tegeder <cmt@burggraben.net>
-#
+# Created by: Christoph Moench-Tegeder <cmt@burggraben.net>
 # $FreeBSD$
 #
 
@@ -13,9 +10,9 @@
 DISTNAME=	${PORTNAME}-${PORTVERSION}-1
 
 MAINTAINER=	cmt@burggraben.net
-COMMENT=	A collection of scripts for The Gimp 2.6
+COMMENT=	Collection of scripts for The Gimp
 
-RUN_DEPENDS=	gimp-2.6:${PORTSDIR}/graphics/gimp-app
+RUN_DEPENDS=	gimp-2.8:${PORTSDIR}/graphics/gimp-app
 
 NO_BUILD=	yes
 NO_WRKSUBDIR=	yes


Regards,
Christoph

-- 
Spare Space
Comment 5 Bryan Drewery freebsd_committer freebsd_triage 2013-03-17 18:15:45 UTC
State Changed
From-To: feedback->open

feedback received
Comment 6 Bryan Drewery freebsd_committer freebsd_triage 2013-03-17 23:29:21 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2013-03-17 23:29:29 UTC
Author: bdrewery
Date: Sun Mar 17 23:29:22 2013
New Revision: 314502
URL: http://svnweb.freebsd.org/changeset/ports/314502

Log:
  - Fix dependency on updated gimp-2.8
  - Trim header
  
  PR:		ports/176890
  Submitted by:	Christoph Moench-Tegeder <cmt@burggraben.net> (maintainer)

Modified:
  head/graphics/gimpfx-foundry/Makefile

Modified: head/graphics/gimpfx-foundry/Makefile
==============================================================================
--- head/graphics/gimpfx-foundry/Makefile	Sun Mar 17 23:10:18 2013	(r314501)
+++ head/graphics/gimpfx-foundry/Makefile	Sun Mar 17 23:29:22 2013	(r314502)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:   gimpfx-foundry
-# Date created:        7 February 2008
-# Whom:                Christoph Moench-Tegeder <cmt@burggraben.net>
-#
+# Created by: Christoph Moench-Tegeder <cmt@burggraben.net>
 # $FreeBSD$
-#
 
 PORTNAME=	gimpfx-foundry
 PORTVERSION=	2.6
@@ -13,9 +9,11 @@ MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}
 DISTNAME=	${PORTNAME}-${PORTVERSION}-1
 
 MAINTAINER=	cmt@burggraben.net
-COMMENT=	A collection of scripts for The Gimp 2.6
+COMMENT=	Collection of scripts for The Gimp 2.6
 
-RUN_DEPENDS=	gimp-2.6:${PORTSDIR}/graphics/gimp-app
+# Maintainer has requested this use a specific version
+# as the plugins may not always be backwards-compatible
+RUN_DEPENDS=	gimp-2.8:${PORTSDIR}/graphics/gimp-app
 
 NO_BUILD=	yes
 NO_WRKSUBDIR=	yes
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"