Bug 177005 - [MAINTAINER] games/3dpong: Removed dependency graphics/netpbm, icon from SF site
Summary: [MAINTAINER] games/3dpong: Removed dependency graphics/netpbm, icon from SF site
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-15 22:50 UTC by nemysis
Modified: 2013-04-28 23:40 UTC (History)
0 users

See Also:


Attachments
3dpong-0.5_6.patch (3.18 KB, patch)
2013-03-15 22:50 UTC, nemysis
no flags Details | Diff
3dpong.diff (3.00 KB, patch)
2013-03-26 02:27 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-03-15 22:50:00 UTC
Makefile change:
+		SF/nemysisfreebsdp/:icons
+		${PORTNAME}.png:icons
-BUILD_DEPENDS=	giftopnm:${PORTSDIR}/graphics/netpbm
+		"${PORTNAME}" "Game;ArcadeGame;" false
-post-build:
+	${INSTALL_DATA} ${_DISTDIR}/${PORTNAME}.png ${PREFIX}/share/pixmaps/

Added file(s):
- pkg-plist

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
looks fine.

Port is now safe with NOPORTDOCS=yes in /etc/make.conf

port test: clean
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-15 22:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

beech@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Beech Rintoul freebsd_committer freebsd_triage 2013-03-24 18:51:16 UTC
State Changed
From-To: open->patched

In progress
Comment 3 nemysis 2013-03-26 02:27:04 UTC
Build log

https://redports.org/buildarchive/20130326020901-22852/

- Changed Icons
- Fix desktop entry
- Remove dependency for graphics/netpbm
- Fix examples
- Makefile tweaks
- Bump portrevision
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-04-28 23:30:50 UTC
Author: beech
Date: Sun Apr 28 22:30:41 2013
New Revision: 316762
URL: http://svnweb.freebsd.org/changeset/ports/316762

Log:
  - Changed Icons
  - Fix desktop entry
  - Remove dependency for graphics/netpbm
  - Fix examples
  - Makefile tweaks
  - Bump portrevision
  
  PR:		ports/177005
  Submitted by:	nemysis <nemysis@gmx.ch> (maintainer)

Modified:
  head/games/3dpong/Makefile
  head/games/3dpong/distinfo

Modified: head/games/3dpong/Makefile
==============================================================================
--- head/games/3dpong/Makefile	Sun Apr 28 22:16:02 2013	(r316761)
+++ head/games/3dpong/Makefile	Sun Apr 28 22:30:41 2013	(r316762)
@@ -2,13 +2,13 @@
 
 PORTNAME=	3dpong
 PORTVERSION=	0.5
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	games
 MASTER_SITES=	ftp://ftp.tuxpaint.org/unix/x/3dpong/src/ \
 		ftp://ftp.billsgames.com/unix/x/3dpong/src/ \
-		http://www.newbreedsoftware.com/images/prodicons/:icons
+		SF/nemysisfreebsdp/:icons
 DISTFILES=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX} \
-		${PORTNAME}.gif:icons
+		${PORTNAME}.png:icons
 DIST_SUBDIR=	${PORTNAME}
 EXTRACT_ONLY=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX}
 
@@ -17,8 +17,6 @@ COMMENT=	X Window 3D Pong game for 1 or 
 
 LICENSE=	GPLv2
 
-BUILD_DEPENDS=	giftopnm:${PORTSDIR}/graphics/netpbm
-
 USE_XORG=	x11
 USE_GMAKE=	yes
 MAKE_ARGS=	CC="${CC}" CFLAGS="${CFLAGS} -I${LOCALBASE}/include" \
@@ -28,39 +26,37 @@ MAN6=		${PORTNAME}.6
 
 PLIST_FILES=	bin/${PORTNAME} \
 		share/pixmaps/${PORTNAME}.png \
-		share/examples/${PORTNAME}/${PORTNAME}-handball.sh \
-		share/examples/${PORTNAME}/${PORTNAME}-vs-computer.sh
-PLIST_DIRS=	share/examples/${PORTNAME}
+		%%DATADIR%%/hit.au \
+		%%DATADIR%%/score.au \
+		%%DATADIR%%/wall.au
+PLIST_DIRS=	%%DATADIR%%
 
-PORTDATA=	*
 PORTDOCS=	AUTHORS.txt CHANGES.txt README.txt TODO.txt
+PORTEXAMPLES=	*
 
 DESKTOP_ENTRIES="3D Pong" "${COMMENT}" "${PORTNAME}" \
-		"${PORTNAME}" "Game;ArcadeGame;" ${FALSE}
+		"${PORTNAME}" "Game;ArcadeGame;" false
 
 .include <bsd.port.options.mk>
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|cat sounds/|cat ${DATADIR}/|g' ${WRKSRC}/src/3dpong.c
 
-post-build:
-	@(cd ${WRKSRC} && \
-		${LOCALBASE}/bin/giftopnm ${DISTDIR}/${DIST_SUBDIR}/${PORTNAME}.gif | \
-		${LOCALBASE}/bin/pnmtopng > ${PORTNAME}.png)
-
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
 
 	${MKDIR} ${DATADIR}
 	${INSTALL_DATA} ${WRKSRC}/sounds/*.au ${DATADIR}
 	${INSTALL_MAN} ${WRKSRC}/src/${MAN6} ${MAN6PREFIX}/man/man6
-	${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.png ${PREFIX}/share/pixmaps
+	${INSTALL_DATA} ${_DISTDIR}/${PORTNAME}.png ${PREFIX}/share/pixmaps
 
 .if ${PORT_OPTIONS:MDOCS}
 	${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/docs/|} ${DOCSDIR}
 .endif
 
-	@(cd ${WRKSRC}/examples && ${COPYTREE_SHARE} \* ${EXAMPLESDIR})
+.if ${PORT_OPTIONS:MEXAMPLES}
+	@(cd ${WRKSRC}/examples && ${COPYTREE_SHARE} . ${EXAMPLESDIR})
+.endif
 
 .include <bsd.port.mk>

Modified: head/games/3dpong/distinfo
==============================================================================
--- head/games/3dpong/distinfo	Sun Apr 28 22:16:02 2013	(r316761)
+++ head/games/3dpong/distinfo	Sun Apr 28 22:30:41 2013	(r316762)
@@ -1,4 +1,4 @@
 SHA256 (3dpong/3dpong-0.5.tar.gz) = b1557818319f482c1e0795192f013ecf998c9f1013033b542676d1bf743a6bc5
 SIZE (3dpong/3dpong-0.5.tar.gz) = 37004
-SHA256 (3dpong/3dpong.gif) = 52524304fd79bb31740ac59a6ce249cc8461112adca0e4f3ab57ff4ab5623a1f
-SIZE (3dpong/3dpong.gif) = 321
+SHA256 (3dpong/3dpong.png) = fad29ba55c9d0c3fd3240b8b7add7350de4775a652d52e3bd8e9b4135e23941b
+SIZE (3dpong/3dpong.png) = 270
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Beech Rintoul freebsd_committer freebsd_triage 2013-04-28 23:31:03 UTC
State Changed
From-To: patched->closed

Committed, Thanks!