Bug 177285 - [patch] fix audio/audacity build with samplerate=off
Summary: [patch] fix audio/audacity build with samplerate=off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-22 20:50 UTC by r4721@tormail.org
Modified: 2013-04-20 15:00 UTC (History)
0 users

See Also:


Attachments
file.diff (410 bytes, patch)
2013-03-22 20:50 UTC, r4721@tormail.org
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description r4721@tormail.org 2013-03-22 20:50:00 UTC
when samplerate option is off, audacity builds an internal library which needs cmake which is not listed in the depends.

=== configuring in lib-src/libsoxr (/work/a/ports/audio/audacity/work/audacity-src-2.0.3/lib-src/libsoxr)
configure: running /bin/sh ./configure --disable-option-checking '--prefix=/usr/local'  '--with-lib-preference=local system' '--with-portaudio' '--enable-unicode' '--without-ffmpeg' '--without-libflac' '--without-libid3tag' '--without-jack' '--disable-ladspa' '--without-libmad' '--enable-nyquist' '--without-portmixer' '--without-libsamplerate' '--without-sbsms' '--with-sse' '--without-libtwolame' '--without-taglib' '--without-libvamp' '--without-libvorbis' '--mandir=/usr/local/man' '--infodir=/usr/local/info/' '--build=amd64-portbld-freebsd9.1' 'build_alias=amd64-portbld-freebsd9.1' 'CC=cc' 'CFLAGS=-O2 -pipe -I/work/a/ports/audio/audacity/work/audacity-src-2.0.3/lib-src/portsmf -I/work/a/ports/audio/audacity/work/audacity-src-2.0.3/lib-src/portaudio-v19/include -I/usr/local/include   -fno-strict-aliasing' 'LDFLAGS= -L/usr/local/lib -pthread' 'CPPFLAGS=-I/work/a/ports/audio/audacity/work/audacity-src-2.0.3/lib-src/portsmf -I/work/a/ports/audio/audacity/work/audacity-src-2.0.3/lib-src/
 portaudio-v19/include -I/usr/local/include  ' 'CXX=c++' 'CXXFLAGS=-O2 -pipe -I/work/a/ports/audio/audacity/work/audacity-src-2.0.3/lib-src/portsmf -I/work/a/ports/audio/audacity/work/audacity-src-2.0.3/lib-src/portaudio-v19/include -I/usr/local/include -fno-strict-aliasing -I/work/a/ports/audio/audacity/work/audacity-src-2.0.3/lib-src/portsmf -I/work/a/ports/audio/audacity/work/audacity-src-2.0.3/lib-src/portaudio-v19/include -I/usr/local/include  ' '--with-wx-config=/usr/local/bin/wxgtk2u-2.8-config' '--with-pa-include=../portaudio-v19/include' --cache-file=/dev/null --srcdir=.
./configure: cmake: not found
configure: error: ./configure failed for lib-src/libsoxr
===>  Script "configure" failed unexpectedly.

simple patch adds conditional cmake depend when samplerate=off. a build_depend is used instead of uses=cmake because the main project still uses gmake, just the one subproject needs cmake.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-22 20:50:07 UTC
Maintainer of audio/audacity,

Please note that PR ports/177285 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/177285

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-22 20:50:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2013-04-20 11:25:45 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-04-20 14:55:19 UTC
Author: pawel
Date: Sat Apr 20 13:55:07 2013
New Revision: 316143
URL: http://svnweb.freebsd.org/changeset/ports/316143

Log:
  Fix build when SAMPLERATE=off
  We can't use USES=cmake here - main project builds with gmake.
  
  PR:		ports/177285
  Submitted by:	r4721@tormail.org
  Approved by:	maintainer timeout
  Feature safe:	yes

Modified:
  head/audio/audacity/Makefile

Modified: head/audio/audacity/Makefile
==============================================================================
--- head/audio/audacity/Makefile	Sat Apr 20 13:54:06 2013	(r316142)
+++ head/audio/audacity/Makefile	Sat Apr 20 13:55:07 2013	(r316143)
@@ -124,6 +124,7 @@ CONFIGURE_ARGS+=	--without-portmixer
 LIB_DEPENDS+=		samplerate:${PORTSDIR}/audio/libsamplerate
 CONFIGURE_ARGS+=	--with-libsamplerate
 .else
+BUILD_DEPENDS+=		cmake:${PORTSDIR}/devel/cmake
 CONFIGURE_ARGS+=	--without-libsamplerate
 .endif
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Pawel Pekala freebsd_committer freebsd_triage 2013-04-20 14:55:20 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!