Bug 177298 - [PATCH] graphics/import-pictures: Convert to OptionsNG
Summary: [PATCH] graphics/import-pictures: Convert to OptionsNG
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-23 03:40 UTC by nemysis
Modified: 2013-03-24 20:20 UTC (History)
1 user (show)

See Also:


Attachments
import-pictures-1.4.patch (2.01 KB, patch)
2013-03-23 03:40 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-03-23 03:40:00 UTC
- Convert to OptionsNG
- Makefile tweaks

Removed file(s):
- pkg-plist

Port maintainer (freebsd@nagilum.org) is cc'd.

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-23 03:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

beech@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-23 03:40:09 UTC
Maintainer of graphics/import-pictures,

Please note that PR ports/177298 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/177298

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-23 03:40:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 freebsd 2013-03-23 11:44:55 UTC
I approve.

Zitat von Edwin Groothuis <edwin@freebsd.org>:

> Maintainer of graphics/import-pictures,
>
> Please note that PR ports/177298 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/177298
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
Comment 5 Beech Rintoul freebsd_committer freebsd_triage 2013-03-24 18:56:57 UTC
State Changed
From-To: feedback->open

Maintainer approved
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-03-24 20:19:49 UTC
Author: beech
Date: Sun Mar 24 20:19:41 2013
New Revision: 315157
URL: http://svnweb.freebsd.org/changeset/ports/315157

Log:
  - Convert to OptionsNG
  - Makefile tweaks
  
  PR:		ports/177298
  Submitted by:	nemysis <nemysis@gmx.ch>
  Approved by:	FreeBSD@nagilum.org (maintainer)

Deleted:
  head/graphics/import-pictures/pkg-plist
Modified:
  head/graphics/import-pictures/Makefile   (contents, props changed)

Modified: head/graphics/import-pictures/Makefile
==============================================================================
--- head/graphics/import-pictures/Makefile	Sun Mar 24 20:09:00 2013	(r315156)
+++ head/graphics/import-pictures/Makefile	Sun Mar 24 20:19:41 2013	(r315157)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:   import-pictures
-# Date created:        7 May 2008
-# Whom:                Alexander Kuehn
-#
+# Created by: Alexander Kuehn
 # $FreeBSD$
-#
 
 PORTNAME=	import-pictures
 PORTVERSION=	1.4
@@ -13,22 +9,30 @@ MASTER_SITES=	http://www.nagilum.org/uni
 MAINTAINER=	freebsd@nagilum.org
 COMMENT=	Utility to copy/move pictures from a directory
 
-RUN_DEPENDS=	p5-Image-ExifTool>=7.0:${PORTSDIR}/graphics/p5-Image-ExifTool \
-		p5-TimeDate>=1.10:${PORTSDIR}/devel/p5-TimeDate \
-		p5-Time-modules>=2006:${PORTSDIR}/devel/p5-Time-modules
+LICENSE=	GPLv2
+
+RUN_DEPENDS=	p5-Image-ExifTool>=0:${PORTSDIR}/graphics/p5-Image-ExifTool \
+		p5-TimeDate>=0:${PORTSDIR}/devel/p5-TimeDate \
+		p5-Time-modules>=0:${PORTSDIR}/devel/p5-Time-modules
 
 USE_BZIP2=	yes
 USE_GMAKE=	yes
 USE_PERL5=	yes
 
-MAN1=		import-pictures.1
+PLIST_FILES=	bin/${PORTNAME}
+
+MAN1=		${PORTNAME}.1
+
+PORTDOCS=	import-pictures.html
+
+.include <bsd.port.options.mk>
 
 post-install:
-	${INSTALL_SCRIPT} ${WRKSRC}/import-pictures ${PREFIX}/bin/
-	${INSTALL_MAN} ${WRKSRC}/import-pictures.1 ${MANPREFIX}/man/man1/
-.if !defined(NOPORTDOCS)
+	${INSTALL_SCRIPT} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
+	${INSTALL_MAN} ${WRKSRC}/${MAN1} ${MAN1PREFIX}/man/man1
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/import-pictures.html ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Beech Rintoul freebsd_committer freebsd_triage 2013-03-24 20:20:14 UTC
State Changed
From-To: open->closed

Committed, Thanks!