Bug 177347 - [patch] x11/xtrlock needs to run setuid root
Summary: [patch] x11/xtrlock needs to run setuid root
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-24 16:30 UTC by Klaus Aehlig
Modified: 2013-06-09 14:20 UTC (History)
0 users

See Also:

Attachments
xtrlock.diff (457 bytes, patch)
2013-03-24 16:30 UTC, Klaus Aehlig 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Klaus Aehlig 2013-03-24 16:30:00 UTC 
	xtrlock(1) obtains the crypted password of the user by calling
	getpwuid(3). For this to work, root priviliges are needed. Hence
	xtrlock should run as a setuid root binary (as it was, before the
	port was updated to version 2.2).

Fix: Apply the following patch.
How-To-Repeat: 
	Install x11/xtrlock and run as unpriviliged user. Instead of locking
        the screen, xtrlock outputs the error message "password entry has no pwd".
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2013-06-09 14:15:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 2 William Grzybowski freebsd_committer freebsd_triage 2013-06-09 14:15:25 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-06-09 14:15:25 UTC 
Author: wg
Date: Sun Jun  9 13:15:18 2013
New Revision: 320334
URL: http://svnweb.freebsd.org/changeset/ports/320334

Log:
  - This port needs to install with setuid bit
  
  PR:		ports/177347
  Submitted by:	Klaus Aehlig <aehlig@linta.de>
  Approved by:	culot / jpaetzel (mentors, implicit)

Modified:
  head/x11/xtrlock/Makefile

Modified: head/x11/xtrlock/Makefile
==============================================================================
--- head/x11/xtrlock/Makefile	Sun Jun  9 13:07:50 2013	(r320333)
+++ head/x11/xtrlock/Makefile	Sun Jun  9 13:15:18 2013	(r320334)
@@ -3,6 +3,7 @@
 
 PORTNAME=	xtrlock
 PORTVERSION=	2.2
+PORTREVISION=	1
 CATEGORIES=	x11
 MASTER_SITES=	DEBIAN
 DISTNAME=	${PORTNAME}_${PORTVERSION}
@@ -21,6 +22,7 @@ LDFLAGS+=	-L${LOCALBASE}/lib -lX11 -lcry
 
 MAN1=		xtrlock.1
 PLIST_FILES=	bin/xtrlock
+BINMODE=	4555
 
 post-extract:
 	@${LN} -sf xtrlock.man ${WRKSRC}/xtrlock.1
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"