177369

no flags

	The new version of ftp/curl 7.29.0 is now available
	(as talked in freebsd-ports@)

	This patch is intended to supersede ports/148094,
	ports/166870, ports/169812, and ports/172325.


	1. the configure script recently introduced a sanity check on
	   CFLAGS and CPPFLAGS
	    [1] https://github.com/bagder/curl/commit/c691037517a969891592e9dbae0a6ed615041881
	    [2] https://github.com/bagder/curl/commit/9d1effad0524bcb4763e06659b728ba134464608
	   This cause `make configure` stop:
configure: using CFLAGS: -O2 -pipe -DLDAP_DEPRECATED -fno-strict-aliasing
configure: CFLAGS error: CFLAGS may only be used to specify C compiler flags, not macro definitions. Use CPPFLAGS for: -DLDAP_DEPRECATED
configure: error: Can not continue. Fix errors mentioned immediately above this line.
===>  Script "configure" failed unexpectedly.

	   `sed -e 's/CFLAGS/CPPFLAGS/' Mk/bsd.ldap.mk` worked for me,
	   so I'd like to request portmgr@ to approve it.


	2. this patch shouldn't break slave port ftp/curl-hiphop, but
	   I'm not sure.

	   The build instruction on github says:
		> Note: If you're building a version of cURL older
		> than 7.28.0 (for whatever reason), you'll need to
		> apply the patch in src/third_party to update it
		> prior to the make step.
	    [3] https://github.com/facebook/hiphop-php/wiki/Building-and-installing-HHVM-on-Ubuntu-12.10
	    [4] https://github.com/facebook/hiphop-php/wiki/Building-and-installing-HHVM-on-CentOS-6.3

	   It is 7.29.0, the MAINTAINER might want to drop extra patch.


	3. dependent ports.
	   following (113) ports have LIB_DEPENDS with SHLIB_VER
	   specified need to be updated:
	    archivers/epkg
	    audio/gbemol
	    audio/gogglesmm
	    audio/grip
	    audio/moc
	    audio/mpdas
	    audio/mpdscribble
	    audio/musicpd
	    audio/ncmpcpp
	    audio/scmpc
	    audio/scrobbler
	    audio/vagalume
	    audio/vorbis-tools
	    audio/xmms2-scrobbler
	    biology/iolib
	    deskutils/cairo-dock
	    deskutils/fbreader
	    deskutils/google-gadgets
	    deskutils/ljit
	    deskutils/logjam
	    deskutils/mdh
	    deskutils/pinot
	    devel/aegis
	    devel/libopkele
	    devel/libwfut
	    devel/mm-common
	    devel/xmltooling
	    editors/libreoffice
	    editors/morla
	    editors/openoffice-3
	    editors/openoffice-devel
	    editors/textroom
	    emulators/virtualbox-ose
	    emulators/virtualbox-ose-legacy
	    finance/libofx
	    ftp/ocaml-ocurl
	    ftp/py-curl
	    ftp/rexx-curl
	    ftp/urlgfe
	    ftp/wmget
	    games/alienarena
	    games/crossfire-server
	    games/daimonin
	    games/deng
	    games/evq3
	    games/f1spirit-remake
	    games/ioquake3
	    games/kartofel
	    games/kuklomenos
	    games/meandmyshadow
	    games/mudmagic
	    games/nexuiz
	    games/openlierox
	    games/springlobby
	    games/supertux-devel
	    games/tmw
	    games/xmoto
	    games/xonotic
	    graphics/feh
	    graphics/gimmage
	    graphics/jp2a
	    graphics/osg
	    graphics/osg-devel
	    irc/unreal
	    japanese/mozc-server
	    lang/gambas
	    lang/hiphop-php
	    lang/q
	    misc/gkrellm-helium
	    multimedia/cclive
	    net-im/centericq
	    net-im/centerim
	    net-im/centerim-devel
	    net-im/cli-msn
	    net-p2p/gtorrentviewer
	    net-p2p/libbt
	    net-p2p/rtorrent
	    net-p2p/transmission-cli
	    net/asterisk
	    net/asterisk10
	    net/asterisk11
	    net/asterisk14
	    net/clamz
	    net/linknx
	    net/mediatomb
	    net/nepenthes
	    net/pecl-oauth
	    net/wmlj
	    polish/sms2
	    print/foomatic-db
	    science/netcdf4
	    security/opensaml2
	    security/osslsigncode
	    security/razorback-api
	    sysutils/apt
	    sysutils/fusefs-curlftpfs
	    sysutils/heartbeat
	    textproc/libnxml
	    textproc/raptor
	    textproc/rss2html
	    www/castget
	    www/mod_auth_mellon
	    www/mod_flickr
	    www/netsurf
	    www/newsbeuter
	    www/nspluginwrapper
	    www/openvrml
	    www/p5-WWW-Curl
	    www/pecl-http
	    www/rubygem-passenger
	    www/thundercache
	    www/thundersnarf
	    x11-wm/ede

	   following (49) ports have either LIB_DEPENDS or
	   BUILD_DEPENDS might need revesion bump:
	    astro/viking
	    audio/amarok-kde4
	    audio/ario
	    audio/libofa
	    audio/osd-lyrics
	    audio/streamtranscoder
	    chinese/fcitx-cloudpinyin
	    comms/gpredict
	    databases/couchdb
	    deskutils/google-gadgets
	    devel/git
	    ftp/R-cran-RCurl
	    games/0ad
	    games/klavaro
	    games/pokerth
	    games/supertuxkart
	    games/ufoai
	    games/warmux
	    graphics/darktable
	    graphics/gnash
	    graphics/mapserver
	    mail/claws-mail
	    mail/dovecot2
	    mail/milter-greylist
	    mail/milter-greylist-devel
	    math/octave
	    multimedia/freetuxtv
	    multimedia/gnome-mplayer
	    multimedia/mkvtoolnix
	    multimedia/xbmc
	    multimedia/xbmc-pvr
	    net-p2p/gnunet
	    net-p2p/jigdo
	    net/pecl-oauth
	    print/foomatic-db-engine
	    science/libkml
	    security/ykclient
	    sysutils/abgx360
	    sysutils/afflib
	    sysutils/condor
	    textproc/libkolabxml
	    textproc/liblrdf
	    textproc/zorba
	    www/cplanet
	    www/gecko-mediaplayer
	    www/mod_spdy
	    www/thundercache
	    www/webkit-gtk2
	    www/webkit-gtk3


	4. Options
	   I've tested several combinations of option, and they looks
	   okay.

	   --with-gssapi failed on some environments (where
	   security/krb5 is present), --with-gssapi-includes and
	   --with-gssapi-libs lead it work

	   Check for SSL (found in ports/172325) just didn't work

Fix: The patch follows:
	  - renaming ftp/curl/files/patch-lib::url.c (as in ports/172325)
	    would be better, kept old name as is to make patch simple
	  - Mk/bsd.ldap.mk needs modification, as mentioned above
How-To-Repeat: 	N/A