Bug 177519 - [patch] fix options handling for editors/calligra-l10n (do not always build all languages)
Summary: [patch] fix options handling for editors/calligra-l10n (do not always build a...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-31 11:40 UTC by Martin Birgmeier
Modified: 2013-04-02 19:10 UTC (History)
0 users

See Also:

Attachments
file.diff (1.24 KB, patch)
2013-03-31 11:40 UTC, Martin Birgmeier 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2013-03-31 11:40:00 UTC 
editors/calligra-l10n always includes localizations for all languages. Fix this in the same manner misc/kde4-l10n does.

Fix: Patch attached with submission follows:
How-To-Repeat: Try to build editors/calligra-l10n with only a few languages selected and observe that despite the selection, all of them are built.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-31 23:30:59 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-04-02 19:05:00 UTC 
Author: avilla
Date: Tue Apr  2 18:04:48 2013
New Revision: 315684
URL: http://svnweb.freebsd.org/changeset/ports/315684

Log:
  - Do not always build all languages.
  
  PR:		177519
  Submitted by:	Martin Birgmeier <Martin.Birgmeier@aon.at>
  Approved by:	portmgr via tabthorpe

Modified:
  head/editors/calligra-l10n/Makefile

Modified: head/editors/calligra-l10n/Makefile
==============================================================================
--- head/editors/calligra-l10n/Makefile	Tue Apr  2 17:44:30 2013	(r315683)
+++ head/editors/calligra-l10n/Makefile	Tue Apr  2 18:04:48 2013	(r315684)
@@ -33,7 +33,7 @@ zh_TW_PORT=	chinese/calligra-l10n-zh_TW
 .include "${.CURDIR}/../../misc/kde4-l10n/files/kde4-lang-names"
 nb_NAME=	Norwegian Bokmal
 
-OPTIONS_DEFINE=	ALL
+OPTIONS_DEFINE=	ALL ${LANG_OPT_ALL}
 OPTIONS_DEFAULT=ALL
 
 ALL_DESC=	All localizations
@@ -42,17 +42,20 @@ ALL_DESC=	All localizations
 ${lang}_DETECT?=	${KDE4_PREFIX}/share/locale/${lang}/LC_MESSAGES/calligra.mo
 ${lang}_PORT?=		editors/calligra-l10n-${lang}
 ${lang}_NAME?=		${lang}
-${lang}_OPTION=		${lang:S/@/_/}
-OPTIONS_DEFINE+=	${${lang}_OPTION}
-${${lang}_OPTION}_DESC=	${${lang}_NAME} localization
+
+${lang}_OPT=		${lang:S/@/_/}
+LANG_OPT_ALL+=		${${lang}_OPT}
+${${lang}_OPT}_DESC=	${${lang}_NAME} localization
+
+${${lang}_OPT}_DEP=	${${lang}_DETECT}:${PORTSDIR}/${${lang}_PORT}
 .endfor
 
 .include <bsd.port.options.mk>
 
-.for lang in ${CALLIGRA_LANG_ALL}
-.if ${PORT_OPTIONS:MALL} || ${PORT_OPTIONS:M${${lang}_OPTION}}
-RUN_DEPENDS+=	${${lang}_DETECT}:${PORTSDIR}/${${lang}_PORT}
-.endif
+.for opt in ${LANG_OPT_ALL}
+. if ${PORT_OPTIONS:M${opt}} || ${PORT_OPTIONS:MALL}
+RUN_DEPENDS+=	${${opt}_DEP}
+. endif
 .endfor
 
 do-install:
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Alberto Villa freebsd_committer freebsd_triage 2013-04-02 19:08:12 UTC 
State Changed
From-To: open->closed

Committed. Thanks!