Bug 177540 - x11/gnome2: Typo in Makefile: OPTIONS_DEFINE= XSCHEENSAVER
Summary: x11/gnome2: Typo in Makefile: OPTIONS_DEFINE= XSCHEENSAVER
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 10:40 UTC by Fredrik Nyström
Modified: 2013-04-01 11:00 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fredrik Nyström 2013-04-01 10:40:00 UTC 
To successfully build both x11/gnome2 and x11/kde4 you will need the following options:
x11/gnome2: OPTIONS_FILE_SET+=XSCREENSAVER
x11-themes/kdeartwork4: OPTIONS_FILE_SET+=GNOME

If you use make config in /usr/ports/x11/gnome2, "[x] XSCHEENSAVER" has no effect since it's mistyped in Makefile. You will still get x11/gnome-screensaver instead of x11/xscreensaver-gnome.

Not related to this bug but I think it would be nice if the gnome and kde teams could agree on a screensaver solution that does not require non default options to build both x11/gnome2 and x11/kde4.

Regards / Fredrik

Fix: 

--- x11/gnome2/Makefile (revision 315646)
+++ x11/gnome2/Makefile (working copy)
@@ -63,7 +63,7 @@
 .endif
 
 .if !defined(GNOME_SLAVE) || ${.CURDIR:T}=="gnome2-lite"
-OPTIONS_DEFINE=        XSCHEENSAVER
+OPTIONS_DEFINE=        XSCREENSAVER
 XSCREENSAVER_DESC=     Use xscreensaver as screen saver app
 #              MAPI "Depend on evolution-mapi (pulls in samba4)
 .endif
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-04-01 10:40:24 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-04-01 10:55:45 UTC 
Author: kwm
Date: Mon Apr  1 09:55:37 2013
New Revision: 315649
URL: http://svnweb.freebsd.org/changeset/ports/315649

Log:
  Fix typo in OptionNG conversion, so option is usable again.
  
  PR:		ports/177540
  Submitted by:	Fredrik Nystrom <fredrik@lysator.liu.se>
  Approved by:	portmgr (miwi)

Modified:
  head/x11/gnome2/Makefile

Modified: head/x11/gnome2/Makefile
==============================================================================
--- head/x11/gnome2/Makefile	Mon Apr  1 09:53:51 2013	(r315648)
+++ head/x11/gnome2/Makefile	Mon Apr  1 09:55:37 2013	(r315649)
@@ -63,7 +63,7 @@ USE_PYTHON=	yes
 .endif
 
 .if !defined(GNOME_SLAVE) || ${.CURDIR:T}=="gnome2-lite"
-OPTIONS_DEFINE=	XSCHEENSAVER
+OPTIONS_DEFINE=	XSCREENSAVER
 XSCREENSAVER_DESC=	Use xscreensaver as screen saver app
 #		MAPI "Depend on evolution-mapi (pulls in samba4)
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Koop Mast freebsd_committer freebsd_triage 2013-04-01 10:55:48 UTC 
State Changed
From-To: open->closed

Committed thanks!