Bug 177729 - [PATCH] sysutils/puppet: puppet agent failed when connecting to puppet master
Summary: [PATCH] sysutils/puppet: puppet agent failed when connecting to puppet master
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-09 04:50 UTC by Edward
Modified: 2013-04-25 02:50 UTC (History)
0 users

See Also:


Attachments
file.diff (379 bytes, patch)
2013-04-09 04:50 UTC, Edward
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Edward 2013-04-09 04:50:00 UTC
puppet agent display the following error message when connecting to puppet master:
Info: Retrieving plugin
Error: /File[/var/puppet/lib]: Could not evaluate: Could not retrieve information from environment production source(s) puppet://puppet-testing-port-01.example.com/plugins
Info: Caching catalog for puppet-testing-port-02.example.com
Info: Applying configuration version '1365200455'

This is because the puppet master (puppet-testing-port01.example.com) has a missing directory /usr/local/etc/puppet/modules, which doesn't create by default. The attached diff of sysutils/puppet Makefile will create the directory /usr/local/etc/puppet/modules which do away the error message.

Fix: Patch attached with submission follows:
How-To-Repeat: On a fresh installation of sysutils/puppet (without /usr/local/etc/puppet/modules) on puppet master (puppet-testing-port01.example.com), then try to connect puppet agent (puppet-testing-port02.example.com) with it.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-04-09 04:50:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->swills

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-04-25 02:43:52 UTC
Author: swills
Date: Thu Apr 25 01:43:44 2013
New Revision: 316490
URL: http://svnweb.freebsd.org/changeset/ports/316490

Log:
  - Add missing module dir
  
  PR:		ports/177729
  Submitted by:	Edward <edward@rdtan.net>

Modified:
  head/sysutils/puppet/Makefile
  head/sysutils/puppet/pkg-plist

Modified: head/sysutils/puppet/Makefile
==============================================================================
--- head/sysutils/puppet/Makefile	Thu Apr 25 01:34:24 2013	(r316489)
+++ head/sysutils/puppet/Makefile	Thu Apr 25 01:43:44 2013	(r316490)
@@ -95,6 +95,7 @@ post-install:
 		--vardir=/var/lib/puppet \
 		--logdir=/var/log/puppet \
 		> ${ETCDIR}/puppet.conf-dist
+	${MKDIR} -p ${ETCDIR}/modules
 	@${ECHO} ${RUBY_SITELIBDIR}/puppet.rb | \
 		${SED} 's,^${PREFIX}/,,' >> ${TMPPLIST}
 	@${ECHO} ${RUBY_SITELIBDIR}/semver.rb | \

Modified: head/sysutils/puppet/pkg-plist
==============================================================================
--- head/sysutils/puppet/pkg-plist	Thu Apr 25 01:34:24 2013	(r316489)
+++ head/sysutils/puppet/pkg-plist	Thu Apr 25 01:43:44 2013	(r316490)
@@ -5,9 +5,11 @@ bin/puppet
 %%RUBY_SITELIBDIR%%/hiera_puppet.rb
 %%ETCDIR%%/puppet.conf-dist
 %%ETCDIR%%/auth.conf-dist
+@dirrmtry etc/puppet/modules
 @dirrmtry etc/puppet
 @unexec rmdir /var/puppet 2>/dev/null || true
 @exec /bin/mkdir -p /var/puppet
+@exec /bin/mkdir -p etc/puppet/modules
 @exec /usr/sbin/chown -Rh puppet:puppet /var/puppet
 @dirrm %%RUBY_SITELIBDIR%%/hiera/backend
 @dirrm %%RUBY_SITELIBDIR%%/hiera
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Steve Wills freebsd_committer freebsd_triage 2013-04-25 02:43:56 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!