Bug 177952 - mail/vodmr: deprecate
Summary: mail/vodmr: deprecate
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-18 14:10 UTC by Rene Ladan
Modified: 2013-05-02 09:50 UTC (History)
0 users

See Also:


Attachments
file.diff (1.37 KB, patch)
2013-04-18 14:10 UTC, Rene Ladan
no flags Details | Diff
vodmr.diff.txt (1.46 KB, text/plain; charset=UTF-8)
2013-04-18 14:22 UTC, Rene Ladan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer freebsd_triage 2013-04-18 14:10:00 UTC
This port depends on mail/p5-vpopmail, which has been marked BROKEN since 2012-07-27 and expired on 2013-03-05.  As such, depracate this port and schedule it for removal on 2013-06-01.  An alternative for this port would be to remove the dependency on mail/p5-vpopmail.

While here, modernize the Makefile (header, options).

Fix: Patch attached with submission follows:
How-To-Repeat: # cd /usr/ports/mail/vodmr
# make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-04-18 14:10:07 UTC
Maintainer of mail/vodmr,

Please note that PR ports/177952 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/177952

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-04-18 14:10:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2013-04-18 14:17:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Track
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2013-04-18 14:22:59 UTC
Slightly revised patch (removed comment about WITHOUT_TCPSERVER and
removed indefinite article in COMMENT).
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2013-05-02 09:46:39 UTC
State Changed
From-To: feedback->closed

Committed, maintainer timeout
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-05-02 09:47:00 UTC
Author: rene
Date: Thu May  2 08:46:52 2013
New Revision: 317084
URL: http://svnweb.freebsd.org/changeset/ports/317084

Log:
  - Set expiration date to 2013-06-01, depends on expired mail/p5-vpopmail
  - Convert to optionsNG
  - Convert Makefile header
  - Remove leading indefinite article from COMMENT
  
  PR:		ports/177952
  Submitted by:	rene
  Approved by:	maintainer timeout (james@now.ie , two weeks)

Modified:
  head/mail/vodmr/Makefile   (contents, props changed)

Modified: head/mail/vodmr/Makefile
==============================================================================
--- head/mail/vodmr/Makefile	Thu May  2 08:44:44 2013	(r317083)
+++ head/mail/vodmr/Makefile	Thu May  2 08:46:52 2013	(r317084)
@@ -1,12 +1,5 @@
-# New ports collection makefile for:	vodmr
-# Date created:				12 January 2003.
-# Whom:					James Raftery <james@now.ie>
-#
+# Created by: James Raftery <james@now.ie>
 # $FreeBSD$
-#
-# Use  make -DWITHOUT_TCPSERVER ...  to install without a dependenacy
-# on djb's tcpserver.
-#
 
 PORTNAME=	vodmr
 PORTVERSION=	0.13
@@ -16,14 +9,23 @@ MASTER_SITES=	http://romana.now.ie/softw
 		http://www.lecter.phlegethon.org/vodmr/
 
 MAINTAINER=	james@now.ie
-COMMENT=	An ODMR/ATRN server for vpopmail+qmail
+COMMENT=	ODMR/ATRN server for vpopmail+qmail
+
+DEPRECATED=	depends on expired mail/p5-vpopmail
+EXPIRATION_DATE=	2013-06-01
+
+OPTIONS_DEFINE=	TCPSERVER
+OPTIONS_DEFAULT=	TCPSERVER
+TCPSERVER_DESC= Enable TCP server via sysutils/ucspi-tcp
+
+.include <bsd.port.options.mk>
 
 RUN_DEPENDS=	p5-CDB_File>=0:${PORTSDIR}/databases/p5-CDB_File \
 		p5-vpopmail>=0:${PORTSDIR}/mail/p5-vpopmail \
 		p5-Mail-Tools>=0:${PORTSDIR}/mail/p5-Mail-Tools \
 		p5-Digest-HMAC>=0:${PORTSDIR}/security/p5-Digest-HMAC
 
-.if !defined(WITHOUT_TCPSERVER)
+.if ${PORT_OPTIONS:MTCPSERVER}
 RUN_DEPENDS+=	tcpserver:${PORTSDIR}/sysutils/ucspi-tcp
 .endif
 
@@ -43,7 +45,7 @@ do-install:
 	${INSTALL_SCRIPT} ${FILESDIR}/odmrd.sh-sample ${PREFIX}/etc/rc.d
 
 post-install:
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${DOCSDIR}
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"