Bug 177973 - news/pan Reversed logic for GTK3 option
Summary: news/pan Reversed logic for GTK3 option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-19 10:00 UTC by Thomas Mueller
Modified: 2013-05-22 10:40 UTC (History)
0 users

See Also:


Attachments
file.diff (281 bytes, patch)
2013-04-19 10:00 UTC, Thomas Mueller
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Mueller 2013-04-19 10:00:00 UTC
The Makefile of news/pan handles the GTK3 option with reversed logic,
if GTK3 is 'off' the port is compiled with GTK3 support.

Fix: tmu:/usr/ports/news/pan# diff -u Makefile.orig Makefile
How-To-Repeat: tmu:/usr/ports/news/pan# make showconfig
===> The following configuration options are available for pan-0.139_1:
     GTK3=off: Use gtk+3 based UI instead of gtk+2
     GTKSPELL=on: Spell checking support (gtk+2 only)
===> Use 'make config' to modify these settings
tmu:/usr/ports/news/pan# make build-depends-list
/usr/ports/accessibility/atk
/usr/ports/devel/gettext
/usr/ports/devel/glib20
[...]
/usr/ports/x11-toolkits/gtk30
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-04-19 10:00:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-05-22 10:30:33 UTC
Author: kwm
Date: Wed May 22 09:30:19 2013
New Revision: 318756
URL: http://svnweb.freebsd.org/changeset/ports/318756

Log:
  Swith to gmime 2.6, pan prefers it over gmime 2.4.
  Fix reversed logic in the GTK3 option [1].
  
  PR:		ports/177973
  Submitted by:	Thomas Mueller <tmueller@sysgo.com>

Modified:
  head/news/pan/Makefile

Modified: head/news/pan/Makefile
==============================================================================
--- head/news/pan/Makefile	Wed May 22 09:29:56 2013	(r318755)
+++ head/news/pan/Makefile	Wed May 22 09:30:19 2013	(r318756)
@@ -4,7 +4,7 @@
 
 PORTNAME=	pan
 PORTVERSION=	0.139
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	news gnome
 MASTER_SITES=	http://pan.rebelbase.com/download/releases/${PORTVERSION}/source/
 DIST_SUBDIR=	gnome2
@@ -15,7 +15,7 @@ COMMENT=	Threaded GTK+ newsreader based 
 LICENSE=	GPLv2
 
 LIB_DEPENDS=	pcre:${PORTSDIR}/devel/pcre \
-		gmime-2.4:${PORTSDIR}/mail/gmime24
+		gmime-2.6:${PORTSDIR}/mail/gmime26
 
 USE_BZIP2=	yes
 USE_GMAKE=	yes
@@ -33,11 +33,11 @@ GTK3_DESC=	Use gtk+3 based UI instead of
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MGTK3}
-USE_GNOME+=	gtk20
-CONFIGURE_ARGS+=--without-gtk3
-.else
 USE_GNOME+=	gtk30
 CONFIGURE_ARGS+=--with-gtk3
+.else
+USE_GNOME+=	gtk20
+CONFIGURE_ARGS+=--without-gtk3
 .endif
 
 .if !${PORT_OPTIONS:MGTKSPELL} || ${PORT_OPTIONS:MGTK3}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Koop Mast freebsd_committer freebsd_triage 2013-05-22 10:30:38 UTC
State Changed
From-To: open->closed

Committed thanks!