I have this patch to bring devel/tcl-memchan up to date to the latest version 2.3. Also, I take advantage of the TEA 3.0 configure script instead of using a custom Makefile. In my opinion, this cleans up the port quite a lot. In addition, I've added a regression-test target. Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->mi mi@aldan.algebra.com => mi@ (via the GNATS Auto Assign Tool)
Maintainer of devel/tcl-memchan, Please note that PR ports/178083 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178083 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Author: mi Date: Tue Apr 23 14:22:39 2013 New Revision: 316356 URL: http://svnweb.freebsd.org/changeset/ports/316356 Log: Upgrade to 2.3 released just over 2 years ago. All of our patches are no longer needed, and the bundled configure-script is doing the right thing, so no need for custom Makefile. Introduce the regression-test target. PR: ports/178083 Submitted by: Pietro Cerutti Deleted: head/devel/tcl-memchan/files/ Modified: head/devel/tcl-memchan/Makefile head/devel/tcl-memchan/distinfo head/devel/tcl-memchan/pkg-plist Modified: head/devel/tcl-memchan/Makefile ============================================================================== --- head/devel/tcl-memchan/Makefile Tue Apr 23 14:20:25 2013 (r316355) +++ head/devel/tcl-memchan/Makefile Tue Apr 23 14:22:39 2013 (r316356) @@ -1,42 +1,30 @@ -# New ports collection makefile for: TclTrf -# Date created: May 22, 2000 -# Whom: Mikhail Teterin <mi@aldan.algebra.com> -# +# Created by: Mikhail Teterin <mi@aldan.algebra.com> # $FreeBSD$ -# PORTNAME= memchan -PORTVERSION= 2.2.1 -PORTREVISION= 1 +PORTVERSION= 2.3 CATEGORIES= devel tcl MASTER_SITES= SF PKGNAMEPREFIX= tcl- +DISTNAME= Memchan${PORTVERSION} MAINTAINER= mi@aldan.algebra.com COMMENT= Two new channel types for in-memory channels in TCL8 -BUILD_DEPENDS= tclsh${TCL_VER}:${PORTSDIR}/lang/tcl${TCL_VER:S/.//} +WRKSRC= ${WRKDIR}/${DISTNAME} -MAKEFILE= ${FILESDIR}/Makefile.bsd -MAKE_ARGS+= -j`${SYSCTL} -n hw.ncpu` +MAKE_JOBS_SAFE= yes +ALL_TARGET= binaries libraries doc-old USE_TCL= 84+ -DDIR= ${PREFIX}/lib/tcl${TCL_VER}/Trf - -MAKE_ENV+= TCL_VER=${TCL_VER} MKDIR="${MKDIR}" \ - PORTVERSION="${PORTVERSION:R}" \ - INSTALL_DATA="${INSTALL_DATA}" +GNU_CONFIGURE= yes +CONFIGURE_ARGS= --with-tcl=${TCL_LIBDIR} # Too bad, n is no longer an acceptable section for bsd.man.mk MANN= fifo.n fifo2.n memchan.n memchanapi.n null.n random.n zero.n +PLIST_SUB+= PORTVERSION=${PORTVERSION} -post-install: - cd ${WRKSRC}/doc && ${INSTALL_MAN} ${MANN} ${PREFIX}/man/mann -#.ifndef(NOPORTDOCS) -# ${MKDIR} ${DOCSDIR} -# ${CP} -pR ${WRKSRC}/doc/html/* ${DOCSDIR} -#.endif +regression-test test: + ${MAKE} -C ${WRKSRC} test .include <bsd.port.mk> - -PLIST_SUB!= ${SETENV} TCL_VER=${TCL_VER} ${MAKE} -f ${MAKEFILE} env Modified: head/devel/tcl-memchan/distinfo ============================================================================== --- head/devel/tcl-memchan/distinfo Tue Apr 23 14:20:25 2013 (r316355) +++ head/devel/tcl-memchan/distinfo Tue Apr 23 14:22:39 2013 (r316356) @@ -1,2 +1,2 @@ -SHA256 (memchan-2.2.1.tar.gz) = ae62284b6a0ce96a9a602bff9766086d23c210f333882fd7c931359310413512 -SIZE (memchan-2.2.1.tar.gz) = 1169233 +SHA256 (Memchan2.3.tar.gz) = adaa5952fe532a917372dcdbc873c082656c49b613d92b09e7938d8f276f2749 +SIZE (Memchan2.3.tar.gz) = 1786238 Modified: head/devel/tcl-memchan/pkg-plist ============================================================================== --- head/devel/tcl-memchan/pkg-plist Tue Apr 23 14:20:25 2013 (r316355) +++ head/devel/tcl-memchan/pkg-plist Tue Apr 23 14:22:39 2013 (r316356) @@ -1,4 +1,9 @@ -%%DIR%%/pkgIndex.tcl -%%DIR%%/%%SHLIB_NAME%% -%%DIR%%/%%SHLIB_LINK%% -@dirrm %%DIR%% +lib/Memchan%%PORTVERSION%%/libMemchan.so.1 +lib/Memchan%%PORTVERSION%%/libMemchanstub.a +lib/Memchan%%PORTVERSION%%/pkgIndex.tcl +include/memchan.h +include/memchanDecls.h +include/buf.h +include/bufDecls.h +include/bufIntDecls.h +@dirrm lib/Memchan%%PORTVERSION%% _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed with minor differences -- install man-pages, do not install the same documents in HTML format. Other minor things. Thank you!
On 2013-Apr-23, 14:45, mi@FreeBSD.org wrote: > Synopsis: [patch] devel/tcl-memchan -- update to 2.3 > > State-Changed-From-To: feedback->closed > State-Changed-By: mi > State-Changed-When: Tue Apr 23 14:42:45 UTC 2013 > State-Changed-Why: > Committed with minor differences -- install man-pages, do not install > the same documents in HTML format. Other minor things. Please note that the fifo.n, fifo2.n, memchan.n, random.n, and zero.n man pages conflict with the one installed by devel/tcllib. ===> Registering installation for tcl-memchan-2.3 Installing tcl-memchan-2.3...pkg: tcl-memchan-2.3 conflicts with tcllib-1.15 (installs files into the same place). Problematic file: /usr/local/man/mann/fifo.n.gz *** [fake-pkg] Error code 70 This is why I opted to install HTML documentation instead. Sorry I could have said so in the PR. -- Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp