Bug 178185 - [maintainer][patch] math/ggobi: build problem with graphviz solved
Summary: [maintainer][patch] math/ggobi: build problem with graphviz solved
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Larkin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-26 18:10 UTC by Rainer Hurling
Modified: 2013-05-06 19:30 UTC (History)
0 users

See Also:


Attachments
file.diff (1.16 KB, patch)
2013-04-26 18:10 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer freebsd_triage 2013-04-26 18:10:00 UTC
With graphics/graphviz installed, math/ggobi finds this external
installation by its configure script in plugins/GraphLayout. Then it
tries to use it instead of its internal graphviz version and fails when
trying to build the port.

This has been a longstanding problem with ggobi, not detected by tinderbox etc. As a workaround, one had to deinstall graphics/graphviz before building math/ggobi and reinstall it afterwards. That should be solved now.

While here, trimming Makefiles header.

Fix: Greg Larkin was so kind to help me with this problem. He looked into it and gave me the hint to post-configure patch the two files. Many thanks to Greg!

Patch attached with submission follows:
How-To-Repeat: Try to build math/ggobi, when graphics/graphviz is installed.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-04-26 18:10:09 UTC
Class Changed
From-To: sw-bug->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Greg Larkin freebsd_committer freebsd_triage 2013-05-01 21:03:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->glarkin

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-05-06 19:26:35 UTC
Author: glarkin
Date: Mon May  6 18:26:22 2013
New Revision: 317538
URL: http://svnweb.freebsd.org/changeset/ports/317538

Log:
  - Fix build problem with graphics/graphviz already installed [1]
  - Trim Makefile header [1]
  - Use DOCSDIR in pkg-plist
  
  PR:		ports/178185
  Submitted by:	Rainer Hurling <rhurlin@gwdg.de> (maintainer) [1]

Modified:
  head/math/ggobi/Makefile
  head/math/ggobi/pkg-plist

Modified: head/math/ggobi/Makefile
==============================================================================
--- head/math/ggobi/Makefile	Mon May  6 18:14:33 2013	(r317537)
+++ head/math/ggobi/Makefile	Mon May  6 18:26:22 2013	(r317538)
@@ -1,9 +1,5 @@
-# Ports collection makefile for:   ggobi
-# Date created:        31 January 2010
-# Whom:                rhurlin
-#
+# Created by: Rainer Hurling <rhurlin@gwdg.de>
 # $FreeBSD$
-#
 
 PORTNAME=	ggobi
 PORTVERSION=	2.1.9
@@ -33,6 +29,15 @@ post-patch:
 		${WRKSRC}/src/ggobi-renderer-factory.c \
 		${WRKSRC}/src/ggobi-renderer.c
 
+post-configure:
+# build gets irritated by the presence of an external graphviz version
+	@${REINPLACE_CMD} -e 's|#define HAVE_LIBGVC 1|/* #define HAVE_LIBGVC 1 */|' \
+		${WRKSRC}/plugins/GraphLayout/config.h
+	@${REINPLACE_CMD} -e 's|LIBGVC_CFLAGS = -I${LOCALBASE}/include/graphviz|LIBGVC_CFLAGS =|' \
+		${WRKSRC}/plugins/GraphLayout/Makefile
+	@${REINPLACE_CMD} -e 's|LIBGVC_LIBS = -L${LOCALBASE}/lib/graphviz -lgvc -lgraph -lcdt|LIBGVC_LIBS =|' \
+		${WRKSRC}/plugins/GraphLayout/Makefile
+
 post-install:
 	${MKDIR} ${PREFIX}/etc/xdg/ggobi
 	${INSTALL_DATA} ${WRKSRC}/ggobirc ${PREFIX}/etc/xdg/ggobi/ggobirc.sample

Modified: head/math/ggobi/pkg-plist
==============================================================================
--- head/math/ggobi/pkg-plist	Mon May  6 18:14:33 2013	(r317537)
+++ head/math/ggobi/pkg-plist	Mon May  6 18:26:22 2013	(r317538)
@@ -129,9 +129,9 @@ share/pixmaps/ggobi.png
 @unexec if cmp -s %D/etc/xdg/ggobi/ggobirc.sample %D/etc/xdg/ggobi/ggobirc; then rm -f %D/etc/xdg/ggobi/ggobirc; fi
 etc/xdg/ggobi/ggobirc.sample
 @exec if [ ! -f %B/ggobirc ]; then cp -p %D/%F %B/ggobirc; fi
-share/doc/ggobi/XML.pdf
-share/doc/ggobi/manual.pdf
-@dirrm share/doc/ggobi
+%%DOCSDIR%%/XML.pdf
+%%DOCSDIR%%/manual.pdf
+@dirrm %%DOCSDIR%%
 @dirrmtry share/applications
 @dirrmtry etc/xdg/ggobi
 @dirrmtry etc/xdg
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Greg Larkin freebsd_committer freebsd_triage 2013-05-06 19:26:48 UTC
State Changed
From-To: open->closed

Committed, thank you!