Bug 178334 - security/pam-pgsql: did no longer work on FreeBSD + upgrade to 0.7.3.1
Summary: security/pam-pgsql: did no longer work on FreeBSD + upgrade to 0.7.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-04 12:30 UTC by berend
Modified: 2013-05-20 11:31 UTC (History)
0 users

See Also:


Attachments
file.diff (4.90 KB, patch)
2013-05-04 12:30 UTC, berend
no flags Details | Diff
patch.txt (4.92 KB, text/plain; charset=UTF-8)
2013-05-13 03:13 UTC, berend
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description berend 2013-05-04 12:30:03 UTC
pam_pgsql should link to libcrypt, but didn't do so. If you try this port you will see:

  pam_start: system error

The reason is probably that FreeBSD's PAM linked with crypt in the past, but no longer.

Now we link explicitly.

Also this upgrades the port to 0.7.3.1.

Fix: See patch.

Patch attached with submission follows:
How-To-Repeat: Install old version.
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2013-05-11 16:48:52 UTC
State Changed
From-To: open->feedback

Build fails, please see log: 
http://people.freebsd.org/~pawel/buildlogs/pam-pgsql-0.7.3.1.log
Comment 2 berend 2013-05-13 03:13:12 UTC
Added depends on libgcrypt.

Comment 3 William Grzybowski freebsd_committer freebsd_triage 2013-05-19 17:48:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-05-20 11:29:54 UTC
Author: wg
Date: Mon May 20 10:29:45 2013
New Revision: 318589
URL: http://svnweb.freebsd.org/changeset/ports/318589

Log:
  - Update to 0.7.3.1
  - Pass maintainership to submitter
  - Remove leading article from COMMENT
  
  Changes:
  http://sourceforge.net/p/pam-pgsql/code/ci/46a971d5/tree/CHANGELOG
  
  PR:		ports/178334
  Submitted by:	Berend de Boer <berend@pobox.com>
  Approved by:	culot (mentor)

Deleted:
  head/security/pam-pgsql/files/
Modified:
  head/security/pam-pgsql/Makefile
  head/security/pam-pgsql/distinfo
  head/security/pam-pgsql/pkg-plist

Modified: head/security/pam-pgsql/Makefile
==============================================================================
--- head/security/pam-pgsql/Makefile	Mon May 20 09:04:41 2013	(r318588)
+++ head/security/pam-pgsql/Makefile	Mon May 20 10:29:45 2013	(r318589)
@@ -1,34 +1,30 @@
-# New ports collection makefile for:    pam-pgsql
-# Date created:				Nov 16, 2000
-# Whom:	      				Mikhail Teterin <mi@aldan.algebra.com>
-#
+# Created by: Mikhail Teterin <mi@aldan.algebra.com>
 # $FreeBSD$
-#
 
 PORTNAME=	pam-pgsql
-PORTVERSION=	0.6.3
-PORTREVISION=	1
+PORTVERSION=	0.7.3.1
 CATEGORIES=	security databases
-MASTER_SITES=	SF
-DISTNAME=	libpam-pgsql-${PORTVERSION}
+MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/0.7/
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A pam module for authenticating with PostgreSQL
+MAINTAINER=	berend@pobox.com
+COMMENT=	PAM module for authenticating with PostgreSQL
 
-LIB_DEPENDS=	mhash.2:${PORTSDIR}/security/mhash
+LIB_DEPENDS=	mhash:${PORTSDIR}/security/mhash \
+		gcrypt:${PORTSDIR}/security/libgcrypt
 
-USE_BZIP2=	yes
 USE_PGSQL=	yes
 GNU_CONFIGURE=	yes
-WRKSRC=		${WRKDIR}/${DISTNAME:S/lib//}
 
-post-install:
+CONFIGURE_ARGS+=	--libdir=/usr/lib
+
+.include <bsd.port.options.mk>
+
 post-install:
 	@${SED} -e 's,%%PREFIX%%,${PREFIX},' ${PKGMESSAGE}
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
-	@${INSTALL_DATA} ${WRKSRC}/README ${WRKSRC}/debian/changelog \
-		${WRKSRC}/debian/copyright ${DOCSDIR}
+	@${INSTALL_DATA} ${WRKSRC}/README ${WRKSRC}/CHANGELOG \
+		${WRKSRC}/COPYRIGHT ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>

Modified: head/security/pam-pgsql/distinfo
==============================================================================
--- head/security/pam-pgsql/distinfo	Mon May 20 09:04:41 2013	(r318588)
+++ head/security/pam-pgsql/distinfo	Mon May 20 10:29:45 2013	(r318589)
@@ -1,2 +1,2 @@
-SHA256 (libpam-pgsql-0.6.3.tar.bz2) = 0e47e8f1fda4439073fb57a88c464af8593e7d2bc61b1fda531497250711b739
-SIZE (libpam-pgsql-0.6.3.tar.bz2) = 63420
+SHA256 (pam-pgsql-0.7.3.1.tar.gz) = c9327e7636e81a2d2bbaf4f017edbd9319a08df1654c9d1875e6f933750548dd
+SIZE (pam-pgsql-0.7.3.1.tar.gz) = 301678

Modified: head/security/pam-pgsql/pkg-plist
==============================================================================
--- head/security/pam-pgsql/pkg-plist	Mon May 20 09:04:41 2013	(r318588)
+++ head/security/pam-pgsql/pkg-plist	Mon May 20 10:29:45 2013	(r318589)
@@ -1,6 +1,9 @@
 %%PORTDOCS%%%%DOCSDIR%%/README
-%%PORTDOCS%%%%DOCSDIR%%/changelog
-%%PORTDOCS%%%%DOCSDIR%%/copyright
+%%PORTDOCS%%%%DOCSDIR%%/CHANGELOG
+%%PORTDOCS%%%%DOCSDIR%%/COPYRIGHT
+%%PORTDOCS%%%%DOCSDIR%%/CREDITS
+%%PORTDOCS%%%%DOCSDIR%%/sample.sql
 %%PORTDOCS%%@dirrm %%DOCSDIR%%
 @cwd /usr
 lib/pam_pgsql.so
+lib/pam_pgsql.la
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 William Grzybowski freebsd_committer freebsd_triage 2013-05-20 11:31:02 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!