Bug 178468 - [patch] sysutils/hachoir-metadata not prefix clean and does not install optimized bytecode
Summary: [patch] sysutils/hachoir-metadata not prefix clean and does not install optim...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-09 23:50 UTC by Antoine Brodin
Modified: 2013-05-31 10:10 UTC (History)
1 user (show)

See Also:


Attachments
hachoir-metadata.diff (4.11 KB, patch)
2013-05-09 23:50 UTC, Antoine Brodin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Brodin freebsd_committer freebsd_triage 2013-05-09 23:50:00 UTC
sysutils/hachoir-metadata is not prefix clean and does not install optimized bytecode.
This is because PYDISTUTILS_INSTALLARGS+= is used before PYDISTUTILS_INSTALLARGS is available.
Patch attached.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-09 23:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lwhsu

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-05-31 10:02:52 UTC
Author: antoine
Date: Fri May 31 09:02:44 2013
New Revision: 319470
URL: http://svnweb.freebsd.org/changeset/ports/319470

Log:
  - Trim Makefile header
  - Install optimized bytecode and be prefix clean (PYDISTUTILS_INSTALLARGS+=
  has to be used after bsd.port.pre.mk is included)
  
  PR:		ports/178468
  Approved by:	maintainer timeout (3 weeks), miwi, eadler (mentors, implicit)

Modified:
  head/sysutils/hachoir-metadata/Makefile
  head/sysutils/hachoir-metadata/pkg-plist

Modified: head/sysutils/hachoir-metadata/Makefile
==============================================================================
--- head/sysutils/hachoir-metadata/Makefile	Fri May 31 08:11:55 2013	(r319469)
+++ head/sysutils/hachoir-metadata/Makefile	Fri May 31 09:02:44 2013	(r319470)
@@ -1,12 +1,9 @@
-# New ports collection makefile for:	hachoir-metadata
-# Date created:		25 January 2007
-# Whom:			Andrew Pantyukhin <infofarmer@FreeBSD.org>
-#
+# Created by: Andrew Pantyukhin <infofarmer@FreeBSD.org>
 # $FreeBSD$
-#
 
 PORTNAME=	hachoir-metadata
 PORTVERSION=	1.3.3
+PORTREVISION=	1
 CATEGORIES=	sysutils python
 MASTER_SITES=	CHEESESHOP
 
@@ -19,6 +16,8 @@ RUN_DEPENDS=	${PYTHON_SITELIBDIR}/hachoi
 USE_PYTHON=	yes
 USE_PYDISTUTILS=yes
 
+.include <bsd.port.pre.mk>
+
 PYDISTUTILS_CONFIGUREARGS+=	--disable-qt
 PYDISTUTILS_BUILDARGS+=	--disable-qt
 PYDISTUTILS_INSTALLARGS+=	--disable-qt
@@ -29,4 +28,4 @@ pre-everything::
 	@${ECHO_MSG} "py-gtk (x11-toolkits/py-gtk2) installed."
 	@${ECHO_MSG} ""
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>

Modified: head/sysutils/hachoir-metadata/pkg-plist
==============================================================================
--- head/sysutils/hachoir-metadata/pkg-plist	Fri May 31 08:11:55 2013	(r319469)
+++ head/sysutils/hachoir-metadata/pkg-plist	Fri May 31 09:02:44 2013	(r319470)
@@ -2,42 +2,62 @@ bin/hachoir-metadata
 bin/hachoir-metadata-gtk
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/__init__.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/__init__.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/__init__.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/archive.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/archive.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/archive.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/audio.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/audio.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/audio.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/config.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/config.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/config.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/file_system.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/file_system.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/file_system.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/filter.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/filter.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/filter.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/formatter.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/formatter.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/formatter.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/image.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/image.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/image.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/jpeg.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/jpeg.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/jpeg.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/metadata.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/metadata.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/metadata.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/metadata_item.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/metadata_item.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/metadata_item.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/misc.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/misc.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/misc.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/program.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/program.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/program.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/register.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/register.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/register.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/riff.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/riff.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/riff.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/safe.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/safe.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/safe.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/setter.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/setter.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/setter.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/timezone.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/timezone.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/timezone.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/version.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/version.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/version.pyo
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/video.py
 %%PYTHON_SITELIBDIR%%/hachoir_metadata/video.pyc
+%%PYTHON_SITELIBDIR%%/hachoir_metadata/video.pyo
 @dirrm %%PYTHON_SITELIBDIR%%/hachoir_metadata
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2013-05-31 10:04:28 UTC
State Changed
From-To: open->closed

Patch committed.