>Number: 178632 >Category: ports >Synopsis: [patch] net-mgmt/collectd5: minor fixes >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue May 14 16:10:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Boris Samorodov >Release: FreeBSD 9-i386 >Organization: BSDprint >Environment: FreeBSD srv.bb.tel.ru 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #7 r243514: Sun Nov 25 20:10:07 SAMT 2012 bsam@srv.bb.tel.ru:/usr/obj/usr/src/sys/BB i386 >Description: use a line space after the Makefile's header; fix a typo: --disable--rrdcached->--disable-rrdcached and do not bump PORTREVISION since the defaults are not affected. PS. Please, keep in mind that I'll submit several PRs on the port as I treat those changes differently. This one is imho apparent one. >How-To-Repeat: Well, look at the Makefile. ;-) >Fix: Index: Makefile =================================================================== --- Makefile (revision 317544) +++ Makefile (working copy) @@ -1,5 +1,6 @@ # Created by: Matt Peterson <matt@peterson.org> # $FreeBSD$ + PORTNAME= collectd PORTVERSION= 5.2.1 PORTREVISION= 1 @@ -394,7 +405,7 @@ CONFIGURE_ARGS+=--enable-rrdcached PLIST_SUB+= RRDCACHED="" .else -CONFIGURE_ARGS+=--disable--rrdcached +CONFIGURE_ARGS+=--disable-rrdcached PLIST_SUB+= RRDCACHED="@comment " .endif >Release-Note: >Audit-Trail: >Unformatted: _______________________________________________ freebsd-ports-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
. use a line space after the Makefile's header; . fix a typo: --disable--rrdcached->--disable-rrdcached and do not bump PORTREVISION since the defaults are not affected. PS. Please, keep in mind that I'll submit several PRs on the port as I treat those changes differently. This one is imho apparent one. Fix: Patch attached with submission follows: How-To-Repeat: Well, look at the Makefile. ;-)
Maintainer of net-mgmt/collectd5, Please note that PR ports/178632 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178632 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->bsam Take.
Hello, On Tue, May 14, 2013 at 04:10:08PM +0000, Edwin Groothuis wrote: > Maintainer of net-mgmt/collectd5, > > Please note that PR ports/178632 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178632 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org > Yes, this patch should be applied :-))) Greetings, -- Krzysztof Stryjek UNIX administrator/Juniper Networks Specialist email: wtp (at) bsdserwis (dot) com http://www.linkedin.com/in/KrzysztofStryjek GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C 91CD 1292 8959 DC61 0E76 In theory, there is no difference between theory and practice. In practice, there is.
Author: bsam Date: Wed May 15 11:07:39 2013 New Revision: 318237 URL: http://svnweb.freebsd.org/changeset/ports/318237 Log: . add a line space after the Makefile header; . correct a typo at CONFIGURE_ARGS (no PORTREVISION bump since no change in defaults); while here apply the last fix to accompanying port (net-mgmg/collectd). PR: ports/178632 Submitted by: bsam (me) Approved by: ports@bsdserwis.com (maintainer) Modified: head/net-mgmt/collectd/Makefile head/net-mgmt/collectd5/Makefile Modified: head/net-mgmt/collectd/Makefile ============================================================================== --- head/net-mgmt/collectd/Makefile Wed May 15 10:37:13 2013 (r318236) +++ head/net-mgmt/collectd/Makefile Wed May 15 11:07:39 2013 (r318237) @@ -362,7 +362,7 @@ PLIST_SUB+= RRD="@comment " CONFIGURE_ARGS+=--enable-rrdcached PLIST_SUB+= RRDCACHED="" .else -CONFIGURE_ARGS+=--disable--rrdcached +CONFIGURE_ARGS+=--disable-rrdcached PLIST_SUB+= RRDCACHED="@comment " .endif Modified: head/net-mgmt/collectd5/Makefile ============================================================================== --- head/net-mgmt/collectd5/Makefile Wed May 15 10:37:13 2013 (r318236) +++ head/net-mgmt/collectd5/Makefile Wed May 15 11:07:39 2013 (r318237) @@ -1,5 +1,6 @@ # Created by: Matt Peterson <matt@peterson.org> # $FreeBSD$ + PORTNAME= collectd PORTVERSION= 5.2.1 PORTREVISION= 1 @@ -394,7 +395,7 @@ PLIST_SUB+= RRD="@comment " CONFIGURE_ARGS+=--enable-rrdcached PLIST_SUB+= RRDCACHED="" .else -CONFIGURE_ARGS+=--disable--rrdcached +CONFIGURE_ARGS+=--disable-rrdcached PLIST_SUB+= RRDCACHED="@comment " .endif _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks! ;-)